Skip to contentSkip to conversation

kbuild: clear VENDOR variable to fix build error on tcsh

PATCH New Masahiro Yamada 3 participants 7 messages Oct 21, 2014 – Oct 23, 2014

lore
Share & tools
lore

Masahiro Yamada

author
#0 lore raw

PATCH 1/1 kbuild: clear VENDOR variable to fix build error on tcsh

Since the environment "VENDOR" is set in tcsh, it must be cleared in our makefile. Otherwise, boards without CONFIG_SYS_VENDOR fail to build:

Quoted 1 line

make CROSS_COMPILE=arm-linux-gnueabi- wandboard_quad_defconfig all

[ snip ]
AR arch/arm/lib/lib.a
CC arch/arm/lib/eabi_compat.o
scripts/Makefile.build:55: /home/foo/u-boot/board/unknown/wandboard/ \
Makefile: No such file or directory
make[2]: *** No rule to make target `/home/foo/u-boot/board/unknown/ \
wandboard/Makefile'. Stop.
make[1]: *** [board/unknown/wandboard] Error 2
make: *** [__build_one_by_one] Error 2

Signed-off-by Masahiro Yamada <[email protected]>
Reported-by Tom Everett <[email protected]>
Reported-by Jeroen Hofstee <[email protected]>

---

 config.mk | 2 ++
 1 file changed, 2 insertions(+)
config.mk +2 -0
index 2157537..00805bd 100644
@@ -18,6 +18,8 @@ PLATFORM_LDFLAGS :=
 LDFLAGS :=
 LDFLAGS_FINAL :=
 OBJCOPYFLAGS :=
+# clear VENDOR for tcsh
+VENDOR :=
 #########################################################################
 
 ARCH := $(CONFIG_SYS_ARCH:"%"=%)
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 kbuild: clear VENDOR variable to fix build error on tcsh

Thanks Masahiro,

Quoted 27 lines · Masahiro Yamada

Since the environment "VENDOR" is set in tcsh, it must be cleared in our makefile. Otherwise, boards without CONFIG_SYS_VENDOR fail to build:

Quoted 1 line

make CROSS_COMPILE=arm-linux-gnueabi- wandboard_quad_defconfig all

[ snip ]
AR arch/arm/lib/lib.a
CC arch/arm/lib/eabi_compat.o

   scripts/Makefile.build:55: /home/foo/u-boot/board/unknown/wandboard/ \
   Makefile: No such file or directory
   make[2]: *** No rule to make target `/home/foo/u-boot/board/unknown/ \
   wandboard/Makefile'.  Stop.
   make[1]: *** [board/unknown/wandboard] Error 2
   make: *** [__build_one_by_one] Error 2
Signed-off-by Masahiro Yamada <[email protected]>
Reported-by Tom Everett <[email protected]>
Reported-by Jeroen Hofstee <[email protected]>

---

  config.mk | 2 ++
  1 file changed, 2 insertions(+)
config.mk +0 -0
index 2157537..00805bd 100644

config.mk PLATFORM_LDFLAGS := · line 25

Quoted 8 lines
config.mk +2 -0
@@ -18,6 +18,8 @@ PLATFORM_LDFLAGS :=
  LDFLAGS :=
  LDFLAGS_FINAL :=
  OBJCOPYFLAGS :=
+# clear VENDOR for tcsh
+VENDOR :=
  #########################################################################
 
  ARCH := $(CONFIG_SYS_ARCH:"%"=%)

ah, understood now. Make does suck in the complete env as make variables but assignments will overwrite the value. make VENDOR=bla would ignore the assignment unless overridden. The ifneq below causes the VENDOR never to be assigned in some cases and hence the value from the original env is used. So

Acked-by Jeroen Hofstee <[email protected]>
Tested-by Jeroen Hofstee <[email protected]>

Regards,
Jeroen

#2 lore raw

PATCH 1/1 kbuild: clear VENDOR variable to fix build error on tcsh

In reply to Masahiro Yamada
Quoted 27 lines · Masahiro Yamada

Since the environment "VENDOR" is set in tcsh, it must be cleared in our makefile. Otherwise, boards without CONFIG_SYS_VENDOR fail to build:

Quoted 1 line

make CROSS_COMPILE=arm-linux-gnueabi- wandboard_quad_defconfig all

[ snip ]
AR arch/arm/lib/lib.a
CC arch/arm/lib/eabi_compat.o
scripts/Makefile.build:55: /home/foo/u-boot/board/unknown/wandboard/ \
Makefile: No such file or directory
make[2]: *** No rule to make target `/home/foo/u-boot/board/unknown/ \
wandboard/Makefile'. Stop.
make[1]: *** [board/unknown/wandboard] Error 2
make: *** [__build_one_by_one] Error 2

Signed-off-by Masahiro Yamada <[email protected]>
Reported-by Tom Everett <[email protected]>
Reported-by Jeroen Hofstee <[email protected]>

---

 config.mk | 2 ++
 1 file changed, 2 insertions(+)
config.mk +0 -0
index 2157537..00805bd 100644

config.mk PLATFORM_LDFLAGS := · line 25

Quoted 8 lines
config.mk +2 -0
@@ -18,6 +18,8 @@ PLATFORM_LDFLAGS :=
 LDFLAGS :=
 LDFLAGS_FINAL :=
 OBJCOPYFLAGS :=
+# clear VENDOR for tcsh
+VENDOR :=
 #########################################################################
 
 ARCH := $(CONFIG_SYS_ARCH:"%"=%)

Are there other variables that might fit into this same category?

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141021/046ffcd4/attachment.pgp>
author
#3 lore raw

PATCH 1/1 kbuild: clear VENDOR variable to fix build error on tcsh

Hi Tom,

2014-10-21 22:20 GMT+09:00 Tom Rini <[email protected]>:

Quoted 12 lines
Quoted 12 lines
config.mk +2 -0
index 2157537..00805bd 100644
@@ -18,6 +18,8 @@ PLATFORM_LDFLAGS :=
 LDFLAGS :=
 LDFLAGS_FINAL :=
 OBJCOPYFLAGS :=
+# clear VENDOR for tcsh
+VENDOR :=
 #########################################################################
Quoted 4 lines

config.mk PLATFORM_LDFLAGS := · line 25

Quoted 1 line
config.mk +0 -0
 ARCH := $(CONFIG_SYS_ARCH:"%"=%)

Are there other variables that might fit into this same category?

I am not sure but probably only this one.

Signature · 2 lines
Best Regards
Masahiro Yamada
#4 lore raw

PATCH 1/1 kbuild: clear VENDOR variable to fix build error on tcsh

Quoted 15 lines · Masahiro YAMADA

Hi Tom,

2014-10-21 22:20 GMT+09:00 Tom Rini <[email protected]>:

Quoted 12 lines
Quoted 12 lines
config.mk +2 -0
index 2157537..00805bd 100644
@@ -18,6 +18,8 @@ PLATFORM_LDFLAGS :=
 LDFLAGS :=
 LDFLAGS_FINAL :=
 OBJCOPYFLAGS :=
+# clear VENDOR for tcsh
+VENDOR :=
 #########################################################################
Quoted 6 lines
Quoted 4 lines

config.mk PLATFORM_LDFLAGS := · line 25

Quoted 1 line
config.mk +0 -0
 ARCH := $(CONFIG_SYS_ARCH:"%"=%)

Are there other variables that might fit into this same category?

I am not sure but probably only this one.

Nope, SOC is one too. I _think_ this might even somehow be related (or at least I hope it is!) to the hard to trigger on normal machines race condition multi-build problem. You can see SOC fail with am335x_evm. I'm going to play a bit more and post a v2 of this, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141021/6707402f/attachment.pgp>
#5 lore raw

PATCH 1/1 kbuild: clear VENDOR variable to fix build error on tcsh

Quoted 21 lines · Tom Rini
Quoted 20 lines · Masahiro YAMADA

Hi Tom,

2014-10-21 22:20 GMT+09:00 Tom Rini <[email protected]>:

Quoted 16 lines

config.mk PLATFORM_LDFLAGS := · line 25

Quoted 13 lines
config.mk +2 -0
index 2157537..00805bd 100644
@@ -18,6 +18,8 @@ PLATFORM_LDFLAGS :=
 LDFLAGS :=
 LDFLAGS_FINAL :=
 OBJCOPYFLAGS :=
+# clear VENDOR for tcsh
+VENDOR :=
 #########################################################################
 
 ARCH := $(CONFIG_SYS_ARCH:"%"=%)

Are there other variables that might fit into this same category?

Quoted 6 lines
Quoted 1 line

I am not sure but probably only this one.

Nope, SOC is one too. I _think_ this might even somehow be related (or at least I hope it is!) to the hard to trigger on normal machines race condition multi-build problem. You can see SOC fail with am335x_evm. I'm going to play a bit more and post a v2 of this, thanks!

I take it back, it was a problem with one of my wrapper scripts.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141021/1c493707/attachment.pgp>
#6 lore raw

PATCH 1/1 kbuild: clear VENDOR variable to fix build error on tcsh

In reply to Masahiro Yamada
Quoted 14 lines · Masahiro Yamada

Since the environment "VENDOR" is set in tcsh, it must be cleared in our makefile. Otherwise, boards without CONFIG_SYS_VENDOR fail to build:

Quoted 1 line

make CROSS_COMPILE=arm-linux-gnueabi- wandboard_quad_defconfig all

[ snip ]
AR arch/arm/lib/lib.a
CC arch/arm/lib/eabi_compat.o
scripts/Makefile.build:55: /home/foo/u-boot/board/unknown/wandboard/ \
Makefile: No such file or directory
make[2]: *** No rule to make target `/home/foo/u-boot/board/unknown/ \
wandboard/Makefile'. Stop.
make[1]: *** [board/unknown/wandboard] Error 2
make: *** [__build_one_by_one] Error 2

Quoted 3 lines
Signed-off-by Masahiro Yamada <[email protected]>
Reported-by Tom Everett <[email protected]>
Reported-by Jeroen Hofstee <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141023/b2321c90/attachment.pgp>