Skip to contentSkip to conversation

iptables: disable static for dynamic builds

PATCH New Gustavo Zacarias 3 participants 5 messages Oct 21, 2014 – Oct 22, 2014

lore
Share & tools
lore

Gustavo Zacarias

author
#0 lore raw

PATCH 1/1 iptables: disable static for dynamic builds

It leads to ugly runtime warnings, see:
http://patchwork.ozlabs.org/patch/386215/
It's also required for xtables-addons.

Signed-off-by Gustavo Zacarias <[email protected]>
---
 package/iptables/iptables.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/iptables/iptables.mk +3 -1
index f059807..2ef879d 100644
@@ -12,7 +12,9 @@ IPTABLES_DEPENDENCIES = host-pkgconf \
 	$(if $(BR2_PACKAGE_LIBNETFILTER_CONNTRACK),libnetfilter_conntrack)
 IPTABLES_LICENSE = GPLv2
 IPTABLES_LICENSE_FILES = COPYING
-IPTABLES_CONF_OPTS = --libexecdir=/usr/lib --with-kernel=$(STAGING_DIR)/usr
+# Building static causes ugly warnings on some plugins
+IPTABLES_CONF_OPTS = --libexecdir=/usr/lib --with-kernel=$(STAGING_DIR)/usr \
+	$(if $(BR2_PREFER_STATIC_LIB),,--disable-static)
 # Because of iptables-01-fix-static-link.patch
 IPTABLES_AUTORECONF = YES
Signature · 1 line
2.0.4
#1 lore raw

PATCH 1/1 iptables: disable static for dynamic builds

Dear Gustavo Zacarias,

package/iptables/iptables.mk IPTABLES_DEPENDENCIES = host-pkgconf \ · line 17

Quoted 3 lines · Gustavo Zacarias
package/iptables/iptables.mk +3 -0
+# Building static causes ugly warnings on some plugins
+IPTABLES_CONF_OPTS = --libexecdir=/usr/lib --with-kernel=$(STAGING_DIR)/usr \
+	$(if $(BR2_PREFER_STATIC_LIB),,--disable-static)

Quick related question: does iptables work properly for purely static builds?

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 iptables: disable static for dynamic builds

Quoted 10 lines · Thomas Petazzoni

Dear Gustavo Zacarias,

package/iptables/iptables.mk IPTABLES_DEPENDENCIES = host-pkgconf \ · line 17

Quoted 3 lines · Gustavo Zacarias
package/iptables/iptables.mk +3 -0
+# Building static causes ugly warnings on some plugins
+IPTABLES_CONF_OPTS = --libexecdir=/usr/lib --with-kernel=$(STAGING_DIR)/usr \
+	$(if $(BR2_PREFER_STATIC_LIB),,--disable-static)

Quick related question: does iptables work properly for purely static builds?

I haven't tried in a while, but probably yes, since the effect of both enables was quite similar, otherwise normally extensions live in /usr/lib/xtables/* as dynamic objects (where you can add new ones, which is what xtables-addons does besides adding new kernel modules, with the scenario right now being every extension linked into the iptables /usr/sbin/xtables-multi binary).
Regards.

#3 lore raw

PATCH 1/1 iptables: disable static for dynamic builds

In reply to Gustavo Zacarias

Gustavo, All,

On 2014-10-21 13:58 -0300, Gustavo Zacarias spake thusly:

Quoted 5 lines

It leads to ugly runtime warnings, see:
http://patchwork.ozlabs.org/patch/386215/
It's also required for xtables-addons.

Signed-off-by Gustavo Zacarias <[email protected]>

Seems sensible to me:

Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 26 lines
---
 package/iptables/iptables.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/iptables/iptables.mk +3 -1
index f059807..2ef879d 100644
@@ -12,7 +12,9 @@ IPTABLES_DEPENDENCIES = host-pkgconf \
 	$(if $(BR2_PACKAGE_LIBNETFILTER_CONNTRACK),libnetfilter_conntrack)
 IPTABLES_LICENSE = GPLv2
 IPTABLES_LICENSE_FILES = COPYING
-IPTABLES_CONF_OPTS = --libexecdir=/usr/lib --with-kernel=$(STAGING_DIR)/usr
+# Building static causes ugly warnings on some plugins
+IPTABLES_CONF_OPTS = --libexecdir=/usr/lib --with-kernel=$(STAGING_DIR)/usr \
+	$(if $(BR2_PREFER_STATIC_LIB),,--disable-static)
 # Because of iptables-01-fix-static-link.patch
 IPTABLES_AUTORECONF = YES
Signature · 6 lines
2.0.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
Applied
#4 lore raw

PATCH 1/1 iptables: disable static for dynamic builds

In reply to Gustavo Zacarias

Dear Gustavo Zacarias,

Quoted 8 lines · Gustavo Zacarias

It leads to ugly runtime warnings, see:
http://patchwork.ozlabs.org/patch/386215/
It's also required for xtables-addons.

Signed-off-by Gustavo Zacarias <[email protected]>
---
 package/iptables/iptables.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com