Skip to contentSkip to conversation

botan: fix mips64 build using n32 ABI

PATCH New Baruch Siach 3 participants 3 messages Oct 23, 2014

lore
Share & tools
lore

Baruch Siach

author
#0 lore raw

PATCH 1/1 botan: fix mips64 build using n32 ABI

Remove explicit -mabi parameter, and let the external toolchain wrapper set the correct -mabi.

Fixes:
http://autobuild.buildroot.net/results/8fb/8fb8621bc5175f593de4ad0f005a5c7ffd4d9241/

Cc Francois Perrad <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/botan/0001-remove-mips64-explicit-mabi.patch | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 package/botan/0001-remove-mips64-explicit-mabi.patch
package/botan/0001-remove-mips64-explicit-mabi.patch new file +18 -0
new file mode 100644
index 000000000000..3fddd54e9a06
@@ -0,0 +1,18 @@
+Remove explicit mips64 -mabi parameter
+
+This breaks when building for n32 ABI on mips64.
+
+Signed-off-by: Baruch Siach <[email protected]>
+---
+
+diff -Nuar Botan-1.10.8-orig/src/build-data/cc/gcc.txt Botan-1.10.8/src/build-data/cc/gcc.txt
+--- Botan-1.10.8-orig/src/build-data/cc/gcc.txt	2014-04-10 17:11:44.000000000 +0300
++++ Botan-1.10.8/src/build-data/cc/gcc.txt	2014-10-23 09:20:34.506722323 +0300
+@@ -92,7 +92,6 @@
+ # The 'linking' bit means "use this for both compiling *and* linking"
+ <mach_abi_linking>
+ x86_64  -> "-m64"
+-mips64  -> "-mabi=64"
+ s390    -> "-m31"
+ s390x   -> "-m64"
+ sparc32 -> "-m32 -mno-app-regs"
Signature · 1 line
2.1.1
#1 lore raw

PATCH 1/1 botan: fix mips64 build using n32 ABI

Dear Baruch Siach,

Quoted 28 lines · Baruch Siach

Remove explicit -mabi parameter, and let the external toolchain wrapper set the correct -mabi.

Fixes:
http://autobuild.buildroot.net/results/8fb/8fb8621bc5175f593de4ad0f005a5c7ffd4d9241/

Cc Francois Perrad <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
  package/botan/0001-remove-mips64-explicit-mabi.patch | 18 ++++++++++++++++++
  1 file changed, 18 insertions(+)

create mode 100644 package/botan/0001-remove-mips64-explicit-mabi.patch

package/botan/0001-remove-mips64-explicit-mabi.patch new file +8 -0
new file mode 100644
index 000000000000..3fddd54e9a06
@@ -0,0 +1,18 @@
+Remove explicit mips64 -mabi parameter
+
+This breaks when building for n32 ABI on mips64.
+
+Signed-off-by: Baruch Siach <[email protected]>
+---
+
+diff -Nuar Botan-1.10.8-orig/src/build-data/cc/gcc.txt Botan-1.10.8/src/build-data/cc/gcc.txt

package/botan/0001-remove-mips64-explicit-mabi.patch line 18

Quoted 10 lines
package/botan/0001-remove-mips64-explicit-mabi.patch new file +10 -0
+--- Botan-1.10.8-orig/src/build-data/cc/gcc.txt	2014-04-10 17:11:44.000000000 +0300
++++ Botan-1.10.8/src/build-data/cc/gcc.txt	2014-10-23 09:20:34.506722323 +0300
+@@ -92,7 +92,6 @@
+ # The 'linking' bit means "use this for both compiling *and* linking"
+ <mach_abi_linking>
+ x86_64  -> "-m64"
+-mips64  -> "-mabi=64"
+ s390    -> "-m31"
+ s390x   -> "-m64"
+ sparc32 -> "-m32 -mno-app-regs"

I sent an email to the Botan mailing list informing about this problem:

http://lists.randombit.net/pipermail/botan-devel/2014-October/001949.html

I haven't received a reply yet, but I hope they fix this problem upstream so we can do a version bump or backport the upstream patch into Buildroot.

However, your patch does the trick and fixes the problem by now, so here you have my...

Acked-by Vicente Olivert Riera <[email protected]>

Best regards,

Signature · 5 lines
Vicente Olivert Riera
Graduate Software Engineer, MIPS Processor IP
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com
#2 lore raw

PATCH 1/1 botan: fix mips64 build using n32 ABI

In reply to Baruch Siach

Dear Baruch Siach,

Quoted 6 lines · Baruch Siach

Remove explicit -mabi parameter, and let the external toolchain wrapper set the correct -mabi.

Fixes:
http://autobuild.buildroot.net/results/8fb/8fb8621bc5175f593de4ad0f005a5c7ffd4d9241/

Quoted 6 lines
Cc Francois Perrad <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/botan/0001-remove-mips64-explicit-mabi.patch | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 package/botan/0001-remove-mips64-explicit-mabi.patch

Applied, thanks. I really wonder why this botan build system decides to pass its own -mabi rather than trusting the compiler and its configuration to use the correct flags.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com