Skip to contentSkip to conversation

Some cleanup for samsung clock

PATCH Superseded Pankaj Dubey 2 participants 7 messages Sep 29, 2014 – Nov 26, 2014

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover Some cleanup for samsung clock

This patch series does some cleanup of samsung clock files and fixes one typo in clk.h

Changes since v1:
- Added patch commit message description to patch 1/3 and 2/3.

Pankaj Dubey (3):
clk: samsung: Spelling s/bwtween/between/
clk: samsung: remove unnecessary CONFIG_OF from clk.c
clk: samsung: remove unnecessary inclusion of header files from clk.h

 drivers/clk/samsung/clk.c |    5 ++---
 drivers/clk/samsung/clk.h |    6 +-----
 2 files changed, 3 insertions(+), 8 deletions(-)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v2 1/3 clk: samsung: Spelling s/bwtween/between/

Fix a typo in comment section of "struct samsung_clk_provider".

---
 drivers/clk/samsung/clk.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/samsung/clk.h +1 -1
index 66ab36b..a1ece4a 100644
@@ -25,7 +25,7 @@
  * struct samsung_clk_provider: information about clock provider
  * @reg_base: virtual address for the register base.
  * @clk_data: holds clock related data like clk* and number of clocks.
- * @lock: maintains exclusion bwtween callbacks for a given clock-provider.
+ * @lock: maintains exclusion between callbacks for a given clock-provider.
  */
 struct samsung_clk_provider {
 	void __iomem *reg_base;
Signature · 1 line
1.7.9.5
#2 lore raw

PATCH v2 2/3 clk: samsung: remove unnecessary CONFIG_OF from clk.c

In reply to Pankaj Dubey

Remove unnecessary CONFIG_OF from samsung/clk.c.

---
 drivers/clk/samsung/clk.c |    2 --
 1 file changed, 2 deletions(-)
drivers/clk/samsung/clk.c +0 -2
index deab84d..31bf391 100644
@@ -281,7 +281,6 @@ void __init samsung_clk_register_gate(struct samsung_clk_provider *ctx,
  * obtain the clock speed of all external fixed clock sources from device
  * tree and register it
  */
-#ifdef CONFIG_OF
 void __init samsung_clk_of_register_fixed_ext(struct samsung_clk_provider *ctx,
 			struct samsung_fixed_rate_clock *fixed_rate_clk,
 			unsigned int nr_fixed_rate_clk,
@@ -298,7 +297,6 @@ void __init samsung_clk_of_register_fixed_ext(struct samsung_clk_provider *ctx,
 	}
 	samsung_clk_register_fixed_rate(ctx, fixed_rate_clk, nr_fixed_rate_clk);
 }
-#endif
 
 /* utility function to get the rate of a specified clock */
 unsigned long _get_rate(const char *clk_name)
Signature · 1 line
1.7.9.5
#3 lore raw

PATCH v2 3/3 clk: samsung: remove unnecessary inclusion of header files from clk.h

In reply to Pankaj Dubey

Let's remove unnecessary include of header files from clk.h and add required one in clk.c

---
 drivers/clk/samsung/clk.c |    3 ++-
 drivers/clk/samsung/clk.h |    4 ----
 2 files changed, 2 insertions(+), 5 deletions(-)
drivers/clk/samsung/clk.c +2 -1
index 31bf391..952f9ec 100644
@@ -11,7 +11,8 @@
  * clock framework for Samsung platforms.
 */
 
-#include <linux/syscore_ops.h>
+#include <linux/of_address.h>
+
 #include "clk.h"
 
 void samsung_clk_save(void __iomem *base,
drivers/clk/samsung/clk.h +0 -4
index a1ece4a..29a5779 100644
@@ -13,12 +13,8 @@
 #ifndef __SAMSUNG_CLK_H
 #define __SAMSUNG_CLK_H
 
-#include <linux/clk.h>
 #include <linux/clkdev.h>
-#include <linux/io.h>
 #include <linux/clk-provider.h>
-#include <linux/of.h>
-#include <linux/of_address.h>
 #include "clk-pll.h"
 
 /**
Signature · 1 line
1.7.9.5
#4 lore raw

v2 cover Some cleanup for samsung clock

In reply to Pankaj Dubey

Hi Tomasz,

On Monday, September 29, 2014 1:18 PM, Pankaj Dubey wrote,

Quoted 1 line

To: linux-arm-kernel at lists.infradead.org;

linux-samsung-soc at vger.kernel.org

Quoted 5 lines

Cc: kgene.kim at samsung.com; tomasz.figa at gmail.com; s.nawrocki at samsung.com; mturquette at linaro.org; naushad at samsung.com; Pankaj Dubey
Subject: [PATCH v2 0/3] Some cleanup for samsung clock

This patch series does some cleanup of samsung clock files and fixes one

typo in clk.h

Quoted 4 lines

Changes since v1:
- Added patch commit message description to patch 1/3 and 2/3.

Quoted 9 lines

Pankaj Dubey (3):
clk: samsung: Spelling s/bwtween/between/
clk: samsung: remove unnecessary CONFIG_OF from clk.c
clk: samsung: remove unnecessary inclusion of header files from clk.h

 drivers/clk/samsung/clk.c |    5 ++---
 drivers/clk/samsung/clk.h |    6 +-----
 2 files changed, 3 insertions(+), 8 deletions(-)

It there are no comments will you please pick up this patch series.

Thanks,
Pankaj Dubey

Quoted 2 lines

--
1.7.9.5

#5 lore raw

v2 cover Some cleanup for samsung clock

Hi Pankaj,

Quoted 1 line · Pankaj Dubey

It there are no comments will you please pick up this patch series.

I've picked up these patches and I'm planning to send a pull request to Mike this week, including any other pending samsung clk patches. Tomasz is going to be busy for few days.

--
Thanks,
Sylwester

#6 lore raw

v2 cover Some cleanup for samsung clock

Hi Sylwester,

On Thursday, October 23, 2014 10:58 PM, Sylwester Nawrocki Wrote:

Quoted 11 lines

To: Pankaj Dubey; linux-arm-kernel at lists.infradead.org; linux-samsung- soc at vger.kernel.org; tomasz.figa at gmail.com
Cc: kgene.kim at samsung.com; mturquette at linaro.org; naushad at samsung.com
Subject: Re: [PATCH v2 0/3] Some cleanup for samsung clock

Hi Pankaj,

Quoted 1 line · Pankaj Dubey

It there are no comments will you please pick up this patch series.

I've picked up these patches and I'm planning to send a pull request to

Mike this

Quoted 3 lines

week, including any other pending samsung clk patches. Tomasz is going to be busy for few days.

Any update on this series?

Thanks,
Pankaj Dubey

Quoted 3 lines

--
Thanks,
Sylwester