board: wandboard: add usb storage
PATCH 1/1 board: wandboard: add usb storage
Fabio Estevam <[email protected]> (maintainer:WANDBOARD BOARD)
--- include/configs/wandboard.h | 10 ++++++++++ 1 file changed, 10 insertions(+)
include/configs/wandboard.h +10 -0
@@ -84,6 +84,16 @@#define CONFIG_CMD_FAT #define CONFIG_DOS_PARTITION +/* USB Configs */ +#define CONFIG_CMD_USB +#define CONFIG_CMD_FAT +#define CONFIG_USB_EHCI +#define CONFIG_USB_EHCI_MX6 +#define CONFIG_USB_STORAGE +#define CONFIG_USB_MAX_CONTROLLER_COUNT 2 +#define CONFIG_MXC_USB_PORTSC (PORT_PTS_UTMI | PORT_PTS_PTW) +#define CONFIG_MXC_USB_FLAGS 0 +/* Ethernet Configuration */ #define CONFIG_CMD_PING #define CONFIG_CMD_DHCP
Signature · 1 line
2.1.0
PATCH 1/1 board: wandboard: add usb storage
Fabio Estevam <[email protected]> (maintainer:WANDBOARD BOARD)
---
version 2: remove the duplicated CONFIG_CMD_FAT
--- include/configs/wandboard.h | 9 +++++++++ 1 file changed, 9 insertions(+)
include/configs/wandboard.h +9 -0
@@ -84,6 +84,15 @@#define CONFIG_CMD_FAT #define CONFIG_DOS_PARTITION +/* USB Configs */ +#define CONFIG_CMD_USB +#define CONFIG_USB_EHCI +#define CONFIG_USB_EHCI_MX6 +#define CONFIG_USB_STORAGE +#define CONFIG_USB_MAX_CONTROLLER_COUNT 2 +#define CONFIG_MXC_USB_PORTSC (PORT_PTS_UTMI | PORT_PTS_PTW) +#define CONFIG_MXC_USB_FLAGS 0 +/* Ethernet Configuration */ #define CONFIG_CMD_PING #define CONFIG_CMD_DHCP
Signature · 1 line
2.1.0
PATCH 1/1 board: wandboard: add usb storage
Hi Jeroen,
Quoted 1 line · Jeroen Hofstee
Fabio Estevam <[email protected]> (maintainer:WANDBOARD BOARD)
Patch looks good, but this commit log doesn't.
Quoted 1 line
Signed-off-by Jeroen Hofstee <[email protected]>
PATCH 1/1 board: wandboard: add usb storage
Hello Fabio,
Quoted 6 lines · Fabio Estevam
Hi Jeroen,
Quoted 1 line · Jeroen Hofstee
Fabio Estevam <[email protected]> (maintainer:WANDBOARD BOARD)
Patch looks good, but this commit log doesn't.
yes, I see, subject of the reposted patch is not correct as well. Lets try it a third time ;)
Regards,
Jeroen
PATCH v3 1/1 board: wandboard: add usb storage
In reply to Jeroen Hofstee---
version 3:
- don't blindly copy get_mainter output
- don't forget the subject-prefix
version 2:
- remove the duplicated CONFIG_CMD_FAT
--- include/configs/wandboard.h | 9 +++++++++ 1 file changed, 9 insertions(+)
include/configs/wandboard.h +9 -0
@@ -84,6 +84,15 @@#define CONFIG_CMD_FAT #define CONFIG_DOS_PARTITION +/* USB Configs */ +#define CONFIG_CMD_USB +#define CONFIG_USB_EHCI +#define CONFIG_USB_EHCI_MX6 +#define CONFIG_USB_STORAGE +#define CONFIG_USB_MAX_CONTROLLER_COUNT 2 +#define CONFIG_MXC_USB_PORTSC (PORT_PTS_UTMI | PORT_PTS_PTW) +#define CONFIG_MXC_USB_FLAGS 0 +/* Ethernet Configuration */ #define CONFIG_CMD_PING #define CONFIG_CMD_DHCP
Signature · 1 line
2.1.0
PATCH v3 1/1 board: wandboard: add usb storage
Quoted 2 lines · Jeroen Hofstee
Cc Fabio Estevam <[email protected]>Signed-off-by Jeroen Hofstee <[email protected]>
Please add Stefano on Cc next time.
PATCH v3 1/1 board: wandboard: add usb storage
Hello Fabio,
Quoted 6 lines · Fabio Estevam
Quoted 2 lines · Jeroen Hofstee
Cc Fabio Estevam <[email protected]>Signed-off-by Jeroen Hofstee <[email protected]>Acked-by Fabio Estevam <[email protected]>Please add Stefano on Cc next time.
I would have normally, but get_maintainer instructed me not to do so. Shouldn't it be adjusted then to include the responsible custodian as well if that is what we want?
Or should I use get_maintainer.pl differently? For the record, I am not a linux developer, I don't know how the script is commonly used.
Regards,
Jeroen
PATCH v3 1/1 board: wandboard: add usb storage
Quoted 6 lines · Jeroen Hofstee
Quoted 1 line
Please add Stefano on Cc next time.
I would have normally, but
get_maintainerinstructed me not to do so. Shouldn't it be adjusted then to include the responsible custodian as well if that is what we want?
Yes, I think it should.
Regards,
Fabio Estevam
PATCH v3 1/1 board: wandboard: add usb storage
In reply to Jeroen HofsteeHi Jeroen,
Quoted 7 lines · Jeroen Hofstee
Hello Fabio,
Quoted 4 lines · Fabio Estevam
Quoted 2 lines · Jeroen Hofstee
Cc Fabio Estevam <[email protected]>Signed-off-by Jeroen Hofstee <[email protected]>
Quoted 8 lines
Quoted 3 lines
Acked-by Fabio Estevam <[email protected]>Please add Stefano on Cc next time.
I would have normally, but
get_maintainerinstructed me not to do so. Shouldn't it be adjusted then to include the responsible custodian as well if that is what we want?
Yes - it looks like that the script must be still adjusted.
Quoted 3 lines
Or should I use get_maintainer.pl differently? For the record, I am not a linux developer, I don't know how the script is commonly used.
IMHO it is easier in the kernel, because each subsystem is isolated and has its own ML. On U-Boot, we are working together in the same ML and then we have to assign each single patch to the related custodian into patchork. Sending the patch directly in CC to the custodian helps this process.
Regards,
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v3 1/1 board: wandboard: add usb storage
In reply to Jeroen HofsteeQuoted 4 lines · Jeroen Hofstee
Cc Fabio Estevam <[email protected]>Signed-off-by Jeroen Hofstee <[email protected]>---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================