Skip to contentSkip to conversation

kmod: fix debuginfo is missing in shared library

PATCH Superseded Chong Lu 2 participants 4 messages Oct 24, 2014 – Oct 27, 2014

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Chong Lu

author
#0 lore raw

v2 cover kmod: fix debuginfo is missing in shared library

Change since v2:
pack kernel modules in test cases to avoid strip command failed

The following changes since commit ad065f94acb0bfb81e33935890a1db251d6e2979:

ref-manual: Minor edits to variables. (2014-10-23 15:20:20 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib chonglu/kmod
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=chonglu/kmod

Chong Lu (1):
kmod: fix debuginfo is missing in shared library

 meta/recipes-kernel/kmod/kmod/run-ptest | 1 +
 meta/recipes-kernel/kmod/kmod_git.bb    | 9 ++++++++-
 2 files changed, 9 insertions(+), 1 deletion(-)
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH v2 1/1 kmod: fix debuginfo is missing in shared library

INHIBIT_PACKAGE_STRIP variable will make debuginfo lose in shared library. Pack kernel modules in test cases to avoid strip command failed.

Signed-off-by Chong Lu <[email protected]>
---
 meta/recipes-kernel/kmod/kmod/run-ptest | 1 +
 meta/recipes-kernel/kmod/kmod_git.bb    | 9 ++++++++-
 2 files changed, 9 insertions(+), 1 deletion(-)
meta/recipes-kernel/kmod/kmod/run-ptest +1 -0
index 37adec3..4ed8715 100755
@@ -1,3 +1,4 @@
 #!/bin/sh
 touch testsuite/stamp-rootfs
+tar xf testmodule.tar
 make -k runtest-TESTS 2>/dev/null| grep -e ^PASS -e ^FAIL
meta/recipes-kernel/kmod/kmod_git.bb +8 -1
index d4c21a4..8a23ac4 100644
@@ -34,6 +34,10 @@ do_install_append () {
         # install depmod.d file for search/ dir
         install -Dm644 "${WORKDIR}/depmod-search.conf" "${D}${base_libdir}/depmod.d/search.conf"
 
+        if ${@base_contains('DISTRO_FEATURES', 'ptest', 'true', 'false', d)}; then
+                find testsuite -name \*.ko -exec tar rf testmodule.tar {} \;
+                find testsuite -name \*.ko -exec rm -f {} \;
+        fi
 }
 
 do_compile_prepend() {

@@ -44,7 +48,10 @@ do_compile_ptest () {
         oe_runmake buildtest-TESTS rootfs
 }
 
-INHIBIT_PACKAGE_STRIP = "${@bb.utils.contains("DISTRO_FEATURES", "ptest", "1", "0", d)}"
+do_install_ptest () {
+        install testmodule.tar ${D}${PTEST_PATH}
+}
+
 INSANE_SKIP_${PN}-ptest = "arch"
 
 inherit update-alternatives
Signature · 1 line
1.9.1
#2 lore raw

meta/recipes-kernel/kmod/kmod/run-ptest line 4

Quoted 7 lines · Chong Lu

+++ b/meta/recipes-kernel/kmod/kmod/run-ptest

meta/recipes-kernel/kmod/kmod/run-ptest +1 -0
@@ -1,3 +1,4 @@
 #!/bin/sh
 touch testsuite/stamp-rootfs
+tar xf testmodule.tar
 make -k runtest-TESTS 2>/dev/null| grep -e ^PASS -e ^FAIL

We should to make sure that the ptest scripts clean up after themselves, so can you change this to delete the modules after the test has ran?

Ross

author
#3 lore raw
Quoted 11 lines · Ross

On 24 October 2014 07:25, Chong Lu <[email protected] <mailto:[email protected]>> wrote:

+++ b/meta/recipes-kernel/kmod/kmod/run-ptest
@@ -1,3 +1,4 @@
#!/bin/sh
touch testsuite/stamp-rootfs
+tar xf testmodule.tar
make -k runtest-TESTS 2>/dev/null| grep -e ^PASS -e ^FAIL

Quoted 3 lines

We should to make sure that the ptest scripts clean up after themselves, so can you change this to delete the modules after the test has ran?

Ross

OK, I will send a V2.

Best Regards
Chong