dbus: drop user/group from skeleton

PATCH New Gustavo Zacarias 3 participants 11 messages Oct 27, 2014

lore

Share & tools

lore

Gustavo Zacarias

author

2014-10-27 18:18 UTC #0 lore raw

PATCH 1/8 dbus: drop user/group from skeleton

It belongs to the package.

Signed-off-by Gustavo Zacarias <[email protected]>

---
 package/dbus/dbus.mk       | 4 ++++
 system/skeleton/etc/group  | 1 -
 system/skeleton/etc/passwd | 1 -
 3 files changed, 4 insertions(+), 2 deletions(-)

package/dbus/dbus.mk +4 -0

index 28d3dd8..0fa1a0f 100644
@@ -14,6 +14,10 @@ define DBUS_PERMISSIONS
 /usr/libexec/dbus-daemon-launch-helper f 4755 0 0 - - - - -
 endef
 
+define DBUS_USERS
+dbus -1 dbus -1 * - - - D-Bus
+endef
+
 DBUS_DEPENDENCIES = host-pkgconf expat
 
 DBUS_CONF_ENV = ac_cv_have_abstract_sockets=yes

system/skeleton/etc/group +0 -1

index 98f712b..fa74ae2 100644
@@ -20,7 +20,6 @@ utmp:x:43:
 plugdev:x:46:
 staff:x:50:
 lock:x:54:
-dbus:x:81:
 netdev:x:82:
 ftp:x:83
 nogroup:x:99:

system/skeleton/etc/passwd +0 -1

index d2e426b..761d92e 100644
@@ -8,7 +8,6 @@ proxy:x:13:13:proxy:/bin:/bin/sh
 www-data:x:33:33:www-data:/var/www:/bin/sh
 backup:x:34:34:backup:/var/backups:/bin/sh
 operator:x:37:37:Operator:/var:/bin/sh
-dbus:x:81:81:dbus:/var/run/dbus:/bin/sh
 ftp:x:83:83:ftp:/home/ftp:/bin/sh
 nobody:x:99:99:nobody:/home:/bin/sh
 sshd:x:103:99:Operator:/var:/bin/sh

Signature · 1 line

2.0.4

Gustavo Zacarias

author

2014-10-27 18:18 UTC #1 lore raw

PATCH 2/8 openssh: drop user from skeleton

The sshd privilege drop user doesn't belong in the skeleton, it's exclusively used by OpenSSH.

Signed-off-by Gustavo Zacarias <[email protected]>

---
 package/openssh/openssh.mk | 4 ++++
 system/skeleton/etc/passwd | 1 -
 2 files changed, 4 insertions(+), 1 deletion(-)

package/openssh/openssh.mk +4 -0

index e2f2663..4b16c34 100644
@@ -12,6 +12,10 @@ OPENSSH_CONF_ENV = LD="$(TARGET_CC)" LDFLAGS="$(TARGET_CFLAGS)"
 OPENSSH_CONF_OPTS = --sysconfdir=/etc/ssh --disable-lastlog --disable-utmp \
 		--disable-utmpx --disable-wtmp --disable-wtmpx --disable-strip
 
+define OPENSSH_USERS
+sshd -1 sshd -1 * - - - SSH drop priv user
+endef
+
 # uClibc toolchain for ARC doesn't support PIE at the moment
 ifeq ($(BR2_arc),y)
 OPENSSH_CONF_OPTS += --without-pie

system/skeleton/etc/passwd +0 -1

index 761d92e..46e239f 100644
@@ -10,4 +10,3 @@ backup:x:34:34:backup:/var/backups:/bin/sh
 operator:x:37:37:Operator:/var:/bin/sh
 ftp:x:83:83:ftp:/home/ftp:/bin/sh
 nobody:x:99:99:nobody:/home:/bin/sh
-sshd:x:103:99:Operator:/var:/bin/sh

Signature · 1 line

2.0.4

Gustavo Zacarias

author

2014-10-27 18:18 UTC #2 lore raw

PATCH 3/8 system/skeleton: drop backup user

In reply to Gustavo Zacarias

AFAIK no package uses it and even if it did it would belong there. And it's not a standard user either.

Signed-off-by Gustavo Zacarias <[email protected]>

---
 system/skeleton/etc/passwd | 1 -
 1 file changed, 1 deletion(-)

system/skeleton/etc/passwd +0 -1

index 46e239f..2e7e77a 100644
@@ -6,7 +6,6 @@ sync:x:4:100:sync:/bin:/bin/sync
 mail:x:8:8:mail:/var/spool/mail:/bin/sh
 proxy:x:13:13:proxy:/bin:/bin/sh
 www-data:x:33:33:www-data:/var/www:/bin/sh
-backup:x:34:34:backup:/var/backups:/bin/sh
 operator:x:37:37:Operator:/var:/bin/sh
 ftp:x:83:83:ftp:/home/ftp:/bin/sh
 nobody:x:99:99:nobody:/home:/bin/sh

Signature · 1 line

2.0.4

Gustavo Zacarias

author

2014-10-27 18:18 UTC #3 lore raw

PATCH 4/8 system/skeleton: drop proxy user

In reply to Gustavo Zacarias

AFAIK no package uses it and even if it did it would belong there. And it's not a standard user either.

Signed-off-by Gustavo Zacarias <[email protected]>

---
 system/skeleton/etc/passwd | 1 -
 1 file changed, 1 deletion(-)

system/skeleton/etc/passwd +0 -1

index 2e7e77a..dc78581 100644
@@ -4,7 +4,6 @@ bin:x:2:2:bin:/bin:/bin/sh
 sys:x:3:3:sys:/dev:/bin/sh
 sync:x:4:100:sync:/bin:/bin/sync
 mail:x:8:8:mail:/var/spool/mail:/bin/sh
-proxy:x:13:13:proxy:/bin:/bin/sh
 www-data:x:33:33:www-data:/var/www:/bin/sh
 operator:x:37:37:Operator:/var:/bin/sh
 ftp:x:83:83:ftp:/home/ftp:/bin/sh

Signature · 1 line

2.0.4

Gustavo Zacarias

author

2014-10-27 18:18 UTC #4 lore raw

PATCH 5/8 system/skeleton: drop valid shell from non-login users

In reply to Gustavo Zacarias

Non-login users shouldn't have a valid shell so drop it.

Signed-off-by Gustavo Zacarias <[email protected]>

---
 system/skeleton/etc/passwd | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

system/skeleton/etc/passwd +8 -8

index dc78581..3a80341 100644
@@ -1,10 +1,10 @@
 root:x:0:0:root:/root:/bin/sh
-daemon:x:1:1:daemon:/usr/sbin:/bin/sh
-bin:x:2:2:bin:/bin:/bin/sh
-sys:x:3:3:sys:/dev:/bin/sh
+daemon:x:1:1:daemon:/usr/sbin:/bin/false
+bin:x:2:2:bin:/bin:/bin/false
+sys:x:3:3:sys:/dev:/bin/false
 sync:x:4:100:sync:/bin:/bin/sync
-mail:x:8:8:mail:/var/spool/mail:/bin/sh
-www-data:x:33:33:www-data:/var/www:/bin/sh
-operator:x:37:37:Operator:/var:/bin/sh
-ftp:x:83:83:ftp:/home/ftp:/bin/sh
-nobody:x:99:99:nobody:/home:/bin/sh
+mail:x:8:8:mail:/var/spool/mail:/bin/false
+www-data:x:33:33:www-data:/var/www:/bin/false
+operator:x:37:37:Operator:/var:/bin/false
+ftp:x:83:83:ftp:/home/ftp:/bin/false
+nobody:x:99:99:nobody:/home:/bin/false

Signature · 1 line

2.0.4

Gustavo Zacarias

author

2014-10-27 18:18 UTC #5 lore raw

PATCH 6/8 system/skeleton: drop adm user from shadow

In reply to Gustavo Zacarias

It has no counterpart in passwd so it's basically a NOP.

Signed-off-by Gustavo Zacarias <[email protected]>

---
 system/skeleton/etc/shadow | 1 -
 1 file changed, 1 deletion(-)

system/skeleton/etc/shadow +0 -1

index d5734d7..69ab451 100644
@@ -1,7 +1,6 @@
 root::10933:0:99999:7:::
 bin:*:10933:0:99999:7:::
 daemon:*:10933:0:99999:7:::
-adm:*:10933:0:99999:7:::
 lp:*:10933:0:99999:7:::
 sync:*:10933:0:99999:7:::
 shutdown:*:10933:0:99999:7:::

Signature · 1 line

2.0.4

Gustavo Zacarias

author

2014-10-27 18:19 UTC #6 lore raw

PATCH 7/8 system/skeleton: drop shutdown user from shadow

In reply to Gustavo Zacarias

It has no counterpart in passwd so it's basically a NOP.

Signed-off-by Gustavo Zacarias <[email protected]>

---
 system/skeleton/etc/shadow | 1 -
 1 file changed, 1 deletion(-)

system/skeleton/etc/shadow +0 -1

index 69ab451..3cd1649 100644
@@ -3,7 +3,6 @@ bin:*:10933:0:99999:7:::
 daemon:*:10933:0:99999:7:::
 lp:*:10933:0:99999:7:::
 sync:*:10933:0:99999:7:::
-shutdown:*:10933:0:99999:7:::
 halt:*:10933:0:99999:7:::
 uucp:*:10933:0:99999:7:::
 operator:*:10933:0:99999:7:::

Signature · 1 line

2.0.4

Gustavo Zacarias

author

2014-10-27 18:19 UTC #7 lore raw

PATCH 8/8 system/skeleton: drop lp user from shadow

In reply to Gustavo Zacarias

It has no counterpart in passwd so it's basically a NOP.

Signed-off-by Gustavo Zacarias <[email protected]>

---
 system/skeleton/etc/shadow | 1 -
 1 file changed, 1 deletion(-)

system/skeleton/etc/shadow +0 -1

index 3cd1649..972dd59 100644
@@ -1,7 +1,6 @@
 root::10933:0:99999:7:::
 bin:*:10933:0:99999:7:::
 daemon:*:10933:0:99999:7:::
-lp:*:10933:0:99999:7:::
 sync:*:10933:0:99999:7:::
 halt:*:10933:0:99999:7:::
 uucp:*:10933:0:99999:7:::

Signature · 1 line

2.0.4

Danomi Manchego

2014-10-27 19:08 UTC #8 lore raw

PATCH 8/8 system/skeleton: drop lp user from shadow

Gustavo,

Quoted 20 lines · Gustavo Zacarias

It has no counterpart in passwd so it's basically a NOP.

Signed-off-by Gustavo Zacarias <[email protected]>

---
 system/skeleton/etc/shadow | 1 -
 1 file changed, 1 deletion(-)

system/skeleton/etc/shadow +0 -2

index 3cd1649..972dd59 100644
@@ -1,7 +1,6 @@
 root::10933:0:99999:7:::
 bin:*:10933:0:99999:7:::
 daemon:*:10933:0:99999:7:::
-lp:*:10933:0:99999:7:::
 sync:*:10933:0:99999:7:::
 halt:*:10933:0:99999:7:::
 uucp:*:10933:0:99999:7:::
--

Quoted 1 line

2.0.4

I find that udev-182 logs a warning when the "lp" group isn't defined. Is it a "don't care"?

Danomi -

Gustavo Zacarias

author

2014-10-27 19:12 UTC #9 lore raw

PATCH 8/8 system/skeleton: drop lp user from shadow

Quoted 2 lines · Danomi Manchego

I find that udev-182 logs a warning when the "lp" group isn't defined. Is it a "don't care"?

That's on system/skeleton/etc/group and i've kept it, this is just the shadow copy of the (inexistant) lp user from /etc/passwd. And udev rules don't concern with the lp user at all anyway. But since you say udev-182 that means you're using an older BR version aren't you?
Regards.

Thomas Petazzoni

2014-10-27 18:28 UTC #10 lore raw

PATCH 1/8 dbus: drop user/group from skeleton

In reply to Gustavo Zacarias

Dear Gustavo Zacarias,

Quoted 8 lines · Gustavo Zacarias

It belongs to the package.
Signed-off-by Gustavo Zacarias <[email protected]>
---
 package/dbus/dbus.mk       | 4 ++++
 system/skeleton/etc/group  | 1 -
 system/skeleton/etc/passwd | 1 -
 3 files changed, 4 insertions(+), 2 deletions(-)

All 8 patches applied, thanks.

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com