staging: rtl8723au: Fix brace coding style issues reported by checkpatch

Fix all opening and closing braces issues reported by checkpatch.

Signed-off-by Nicholas Krause <[email protected]>

---
 drivers/staging/rtl8723au/core/rtw_ap.c | 138 ++++++++++----------------------
 1 file changed, 43 insertions(+), 95 deletions(-)

drivers/staging/rtl8723au/core/rtw_ap.c +43 -96

index 75ae249..3301a2c 100644
@@ -231,12 +231,10 @@ void      expire_timeout_chk23a(struct rtw_adapter *padapter)
                        psta->expire_to--;
                }
 
-               if (psta->expire_to <= 0)
-               {
+               if (psta->expire_to <= 0) {
                        struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
 
-                       if (padapter->registrypriv.wifi_spec == 1)
-                       {
+                       if (padapter->registrypriv.wifi_spec == 1) {
                                psta->expire_to = pstapriv->expire_to;
                                continue;
                        }

@@ -308,15 +306,12 @@ void      expire_timeout_chk23a(struct rtw_adapter *padapter)
                        ret = issue_nulldata23a(padapter, psta->hwaddr, 0, 3, 50);
 
                psta->keep_alive_trycnt++;
-               if (ret == _SUCCESS)
-               {
+               if (ret == _SUCCESS) {
                        DBG_8723A("asoc check, sta(" MAC_FMT ") is alive\n", MAC_ARG(psta->hwaddr));
                        psta->expire_to = pstapriv->expire_to;
                        psta->keep_alive_trycnt = 0;
                        continue;
-               }
-               else if (psta->keep_alive_trycnt <= 3)
-               {
+               } else if (psta->keep_alive_trycnt <= 3) {
                        DBG_8723A("ack check for asoc expire, keep_alive_trycnt =%d\n", psta->keep_alive_trycnt);
                        psta->expire_to = 1;
                        continue;

@@ -363,8 +358,7 @@ void add_RATid23a(struct rtw_adapter *padapter, struct sta_info *psta, u8 rssi_l
                return;
 
        /* b/g mode ra_bitmap */
-       for (i = 0; i < sizeof(psta->bssrateset); i++)
-       {
+       for (i = 0; i < sizeof(psta->bssrateset); i++) {
                if (psta->bssrateset[i])
                        tx_ra_bitmap |= rtw_get_bit_value_from_ieee_value23a(psta->bssrateset[i]&0x7f);
        }

@@ -406,8 +400,7 @@ void add_RATid23a(struct rtw_adapter *padapter, struct sta_info *psta, u8 rssi_l
        raid = networktype_to_raid23a(sta_band);
        init_rate = get_highest_rate_idx23a(tx_ra_bitmap&0x0fffffff)&0x3f;
 
-       if (psta->aid < NUM_STA)
-       {
+       if (psta->aid < NUM_STA) {
                u8 arg = 0;
 
                arg = psta->mac_id&0x1f;

@@ -436,9 +429,7 @@ void add_RATid23a(struct rtw_adapter *padapter, struct sta_info *psta, u8 rssi_l
                psta->raid = raid;
                psta->init_rate = init_rate;
 
-       }
-       else
-       {
+       } else {
                DBG_8723A("station aid %d exceed the max number\n", psta->aid);
        }
 }

@@ -453,8 +444,7 @@ static void update_bmc_sta(struct rtw_adapter *padapter)
        struct wlan_bssid_ex *pcur_network = &pmlmepriv->cur_network.network;
        struct sta_info *psta = rtw_get_bcmc_stainfo23a(padapter);
 
-       if (psta)
-       {
+       if (psta) {
                psta->aid = 0;/* default set to 0 */
                psta->mac_id = psta->aid + 1;
 

@@ -474,8 +464,7 @@ static void update_bmc_sta(struct rtw_adapter *padapter)
                psta->bssratelen = supportRateNum;
 
                /* b/g mode ra_bitmap */
-               for (i = 0; i < supportRateNum; i++)
-               {
+               for (i = 0; i < supportRateNum; i++) {
                        if (psta->bssrateset[i])
                                tx_ra_bitmap |= rtw_get_bit_value_from_ieee_value23a(psta->bssrateset[i]&0x7f);
                }

@@ -522,9 +511,7 @@ static void update_bmc_sta(struct rtw_adapter *padapter)
                psta->state = _FW_LINKED;
                spin_unlock_bh(&psta->lock);
 
-       }
-       else
-       {
+       } else {
                DBG_8723A("add_RATid23a_bmc_sta error!\n");
        }
 }

@@ -561,8 +548,7 @@ void update_sta_info23a_apmode23a(struct rtw_adapter *padapter, struct sta_info
        /* ERP */
        VCS_update23a(padapter, psta);
        /* HT related cap */
-       if (phtpriv_sta->ht_option)
-       {
+       if (phtpriv_sta->ht_option) {
                /* check if sta supports rx ampdu */
                phtpriv_sta->ampdu_enable = phtpriv_ap->ampdu_enable;
 

@@ -580,9 +566,7 @@ void update_sta_info23a_apmode23a(struct rtw_adapter *padapter, struct sta_info
 
                psta->qos_option = true;
 
-       }
-       else
-       {
+       } else {
                phtpriv_sta->ampdu_enable = false;
 
                phtpriv_sta->sgi = false;

@@ -1258,8 +1242,7 @@ void update_beacon23a(struct rtw_adapter *padapter, u8 ie_id, u8 *oui, u8 tx)
 
        spin_lock_bh(&pmlmepriv->bcn_update_lock);
 
-       switch (ie_id)
-       {
+       switch (ie_id) {
        case 0xFF:
                /* 8: TimeStamp, 2: Beacon Interval 2:Capability */
                update_bcn_fixed_ie(padapter);

@@ -1386,8 +1369,7 @@ static int rtw_ht_operation_update(struct rtw_adapter *padapter)
 void associated_clients_update23a(struct rtw_adapter *padapter, u8 updated)
 {
        /* update associated stations cap. */
-       if (updated == true)
-       {
+       if (updated == true) {
                struct list_head *phead, *plist, *ptmp;
                struct sta_info *psta;
                struct sta_priv *pstapriv = &padapter->stapriv;

@@ -1413,34 +1395,27 @@ void bss_cap_update_on_sta_join23a(struct rtw_adapter *padapter, struct sta_info
        struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
        struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
 
-       if (!(psta->flags & WLAN_STA_SHORT_PREAMBLE))
-       {
-               if (!psta->no_short_preamble_set)
-               {
+       if (!(psta->flags & WLAN_STA_SHORT_PREAMBLE)) {
+               if (!psta->no_short_preamble_set) {
                        psta->no_short_preamble_set = 1;
 
                        pmlmepriv->num_sta_no_short_preamble++;
 
                        if ((pmlmeext->cur_wireless_mode > WIRELESS_11B) &&
-                               (pmlmepriv->num_sta_no_short_preamble == 1))
-                       {
+                               (pmlmepriv->num_sta_no_short_preamble == 1)) {
                                beacon_updated = true;
                                update_beacon23a(padapter, 0xFF, NULL, true);
                        }
 
                }
-       }
-       else
-       {
-               if (psta->no_short_preamble_set)
-               {
+       } else {
+               if (psta->no_short_preamble_set) {
                        psta->no_short_preamble_set = 0;
 
                        pmlmepriv->num_sta_no_short_preamble--;
 
                        if ((pmlmeext->cur_wireless_mode > WIRELESS_11B) &&
-                               (pmlmepriv->num_sta_no_short_preamble == 0))
-                       {
+                               (pmlmepriv->num_sta_no_short_preamble == 0)) {
                                beacon_updated = true;
                                update_beacon23a(padapter, 0xFF, NULL, true);
                        }

@@ -1448,32 +1423,25 @@ void bss_cap_update_on_sta_join23a(struct rtw_adapter *padapter, struct sta_info
                }
        }
 
-       if (psta->flags & WLAN_STA_NONERP)
-       {
-               if (!psta->nonerp_set)
-               {
+       if (psta->flags & WLAN_STA_NONERP) {
+               if (!psta->nonerp_set) {
                        psta->nonerp_set = 1;
 
                        pmlmepriv->num_sta_non_erp++;
 
-                       if (pmlmepriv->num_sta_non_erp == 1)
-                       {
+                       if (pmlmepriv->num_sta_non_erp == 1) {
                                beacon_updated = true;
                                update_beacon23a(padapter, WLAN_EID_ERP_INFO, NULL, true);
                        }
                }
 
-       }
-       else
-       {
-               if (psta->nonerp_set)
-               {
+       } else {
+               if (psta->nonerp_set) {
                        psta->nonerp_set = 0;
 
                        pmlmepriv->num_sta_non_erp--;
 
-                       if (pmlmepriv->num_sta_non_erp == 0)
-                       {
+                       if (pmlmepriv->num_sta_non_erp == 0) {
                                beacon_updated = true;
                                update_beacon23a(padapter, WLAN_EID_ERP_INFO, NULL, true);
                        }

@@ -1481,42 +1449,34 @@ void bss_cap_update_on_sta_join23a(struct rtw_adapter *padapter, struct sta_info
 
        }
 
-       if (!(psta->capability & WLAN_CAPABILITY_SHORT_SLOT_TIME))
-       {
-               if (!psta->no_short_slot_time_set)
-               {
+       if (!(psta->capability & WLAN_CAPABILITY_SHORT_SLOT_TIME)) {
+               if (!psta->no_short_slot_time_set) {
                        psta->no_short_slot_time_set = 1;
 
                        pmlmepriv->num_sta_no_short_slot_time++;
 
                        if ((pmlmeext->cur_wireless_mode > WIRELESS_11B) &&
-                                (pmlmepriv->num_sta_no_short_slot_time == 1))
-                       {
+                                (pmlmepriv->num_sta_no_short_slot_time == 1)) {
                                beacon_updated = true;
                                update_beacon23a(padapter, 0xFF, NULL, true);
                        }
 
                }
-       }
-       else
-       {
-               if (psta->no_short_slot_time_set)
-               {
+       } else {
+               if (psta->no_short_slot_time_set) {
                        psta->no_short_slot_time_set = 0;
 
                        pmlmepriv->num_sta_no_short_slot_time--;
 
                        if ((pmlmeext->cur_wireless_mode > WIRELESS_11B) &&
-                                (pmlmepriv->num_sta_no_short_slot_time == 0))
-                       {
+                                (pmlmepriv->num_sta_no_short_slot_time == 0)) {
                                beacon_updated = true;
                                update_beacon23a(padapter, 0xFF, NULL, true);
                        }
                }
        }
 
-       if (psta->flags & WLAN_STA_HT)
-       {
+       if (psta->flags & WLAN_STA_HT) {
                u16 ht_capab = le16_to_cpu(psta->htpriv.ht_cap.cap_info);
 
                DBG_8723A("HT: STA " MAC_FMT " HT Capabilities "

@@ -1549,9 +1509,7 @@ void bss_cap_update_on_sta_join23a(struct rtw_adapter *padapter, struct sta_info
                                   pmlmepriv->num_sta_ht_20mhz);
                }
 
-       }
-       else
-       {
+       } else {
                if (!psta->no_ht_set) {
                        psta->no_ht_set = 1;
                        pmlmepriv->num_sta_no_ht++;

@@ -1564,8 +1522,7 @@ void bss_cap_update_on_sta_join23a(struct rtw_adapter *padapter, struct sta_info
                }
        }
 
-       if (rtw_ht_operation_update(padapter) > 0)
-       {
+       if (rtw_ht_operation_update(padapter) > 0) {
                update_beacon23a(padapter, WLAN_EID_HT_CAPABILITY, NULL, false);
                update_beacon23a(padapter, WLAN_EID_HT_OPERATION, NULL, true);
        }

@@ -1589,8 +1546,7 @@ u8 bss_cap_update_on_sta_leave23a(struct rtw_adapter *padapter, struct sta_info
                psta->no_short_preamble_set = 0;
                pmlmepriv->num_sta_no_short_preamble--;
                if (pmlmeext->cur_wireless_mode > WIRELESS_11B
-                   && pmlmepriv->num_sta_no_short_preamble == 0)
-               {
+                   && pmlmepriv->num_sta_no_short_preamble == 0) {
                        beacon_updated = true;
                        update_beacon23a(padapter, 0xFF, NULL, true);
                }

@@ -1599,8 +1555,7 @@ u8 bss_cap_update_on_sta_leave23a(struct rtw_adapter *padapter, struct sta_info
        if (psta->nonerp_set) {
                psta->nonerp_set = 0;
                pmlmepriv->num_sta_non_erp--;
-               if (pmlmepriv->num_sta_non_erp == 0)
-               {
+               if (pmlmepriv->num_sta_non_erp == 0) {
                        beacon_updated = true;
                        update_beacon23a(padapter, WLAN_EID_ERP_INFO,
                                         NULL, true);

@@ -1611,8 +1566,7 @@ u8 bss_cap_update_on_sta_leave23a(struct rtw_adapter *padapter, struct sta_info
                psta->no_short_slot_time_set = 0;
                pmlmepriv->num_sta_no_short_slot_time--;
                if (pmlmeext->cur_wireless_mode > WIRELESS_11B
-                   && pmlmepriv->num_sta_no_short_slot_time == 0)
-               {
+                   && pmlmepriv->num_sta_no_short_slot_time == 0) {
                        beacon_updated = true;
                        update_beacon23a(padapter, 0xFF, NULL, true);
                }

@@ -1633,8 +1587,7 @@ u8 bss_cap_update_on_sta_leave23a(struct rtw_adapter *padapter, struct sta_info
                pmlmepriv->num_sta_ht_20mhz--;
        }
 
-       if (rtw_ht_operation_update(padapter) > 0)
-       {
+       if (rtw_ht_operation_update(padapter) > 0) {
                update_beacon23a(padapter, WLAN_EID_HT_CAPABILITY, NULL, false);
                update_beacon23a(padapter, WLAN_EID_HT_OPERATION, NULL, true);
        }

@@ -1654,8 +1607,7 @@ u8 ap_free_sta23a(struct rtw_adapter *padapter, struct sta_info *psta, bool acti
        if (!psta)
                return beacon_updated;
 
-       if (active == true)
-       {
+       if (active == true) {
                /* tear down Rx AMPDU */
                send_delba23a(padapter, 0, psta->hwaddr);/*  recipient */
 

@@ -1783,13 +1735,10 @@ void sta_info_update23a(struct rtw_adapter *padapter, struct sta_info *psta)
                psta->qos_option = 0;
 
        /* update 802.11n ht cap. */
-       if (WLAN_STA_HT&flags)
-       {
+       if (WLAN_STA_HT&flags) {
                psta->htpriv.ht_option = true;
                psta->qos_option = 1;
-       }
-       else
-       {
+       } else {
                psta->htpriv.ht_option = false;
        }
 

@@ -1802,8 +1751,7 @@ void sta_info_update23a(struct rtw_adapter *padapter, struct sta_info *psta)
 /* called >= TSR LEVEL for USB or SDIO Interface*/
 void ap_sta_info_defer_update23a(struct rtw_adapter *padapter, struct sta_info *psta)
 {
-       if (psta->state & _FW_LINKED)
-       {
+       if (psta->state & _FW_LINKED) {
                /* add ratid */
                add_RATid23a(padapter, psta, 0);/* DM_RATR_STA_INIT */
        }
--

1.9.1

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Quoted 5 lines · Nicholas Krause

Fix all opening and closing braces issues reported by checkpatch.

Signed-off-by Nicholas Krause <[email protected]>

---
 drivers/staging/rtl8723au/core/rtw_ap.c | 138 ++++++++++----------------------
 1 file changed, 43 insertions(+), 95 deletions(-)

Good job Nick, don't let the compliment go to your head now. I am going to be very nitpicky because of past patch problems, so with that said, the patch description could be improve a little. I know that with simple changes like this, it is tough to not repeat yourself (i.e. title is the same as the description). Currently the title and patch description are ok, but personally I prefer that the patch description be more verbose and not an copy of the patch title. So in this case, a patch description of:

"Fix the curley braces that do not reside on the same line because this does not follow the kernel coding style and causes checkpatch.pl warnings."

Lots of violations
checkpatch finds are intentionally left in place because correcting them makes the code less readable, not more readable.

Quoted 3 lines · Greg Freemyer

Lots of violations
checkpatch finds are intentionally left in place because correcting them makes the code less readable, not more readable.

Yeah, but there are still hundreds of thousands of checkpatch violations throughout the kernel that if fixed would actually improve readability.

Path            Errors  Warnings
drivers         200979  361350
arch            98791   142300
sound           25938   31028
include         13651   25598
fs              96353   22483
net             3185    19216
lib             8055    6578
tools           1126    3972
kernel          656     3203
security        47      1247
mm              203     1186
scripts         824     1168
crypto          1144    1095
block           196     656
Documentation   97      259
init            29      173
virt            18      152
samples         27      118
ipc             2       77
usr             17      20
firmware        11      19

The WARNING "line over 80 characters" currently accounts for 216K of the total violations. IMHO checkpatch should just stop complaining about the 80 char limit since that's the main offender causing new kernel developers to inadvertently lessen readability with their first patch. If the 80 char warning should be mostly ignored why have it.. it's pointless. Increase it to a 21st century value or kill it.

--
Greg Donald

I actually fixed this to improve code readability not for the kernel rules for your information.

Quoted 2 lines · Nick Krause

I actually fixed this to improve code readability not for the kernel rules for your information.

I know, good job.. and here's to hoping a maintainer picks up your patch and applies it to their tree :)

But I would argue "kernel rules" and "improving code readability" are one and the same. Otherwise checkpatch and it's optional -f needn't exist.

I am trying to improve my code as much as possible now, I really am finally understanding how terrible my code was before and I hope never again to make patches that shitty.

Quoted 2 lines · nick

I am trying to improve my code as much as possible now, I really am finally understanding how terrible my code was before and I hope never again to make patches that shitty.

I don't think your recent progress has gone unnoticed. Any word on your latest patch getting picked up? It looked good to me.

You remind me of John Locke from Lost. "Don't tell me what I can't do!" :)

Greg,
Not picked up of yet. I would appreciate if this gets forwarded for me as this may help it get picked up. Further more this issues I am were causing were not technical but not listening and that's why I decided to state around and learn how to my patches properly.
Cheers Nick

Quoted 4 lines · nick

Quoted 2 lines

I am trying to improve my code as much as possible now, I really am finally understanding how terrible my code was before and I hope never again to make patches that shitty.

Quoted 6 lines

I don't think your recent progress has gone unnoticed. Any word on your latest patch getting picked up? It looked good to me.

You remind me of John Locke from Lost. "Don't tell me what I can't do!" :)

Quoted 6 lines · nick

Greg,
Not picked up of yet. I would appreciate if this gets forwarded for me as this may help it get picked up. Further more this issues I am were causing were not technical but not listening and that's why I decided to state around and learn how to my patches properly.
Cheers Nick

I saw you updated you patch Nick, thanks. I feel I can safely put my
Reviewed-by: on it. Also, if Greg KH (staging maintainer) has not picked up in the next day or so, I will submit your patch to the staging tree for you.

Quoted 12 lines · Greg Donald

Quoted 10 lines · nick

Quoted 2 lines

I am trying to improve my code as much as possible now, I really am finally understanding how terrible my code was before and I hope never again to make patches that shitty.

I don't think your recent progress has gone unnoticed. Any word on your latest patch getting picked up? It looked good to me.

You remind me of John Locke from Lost. "Don't tell me what I can't do!" :)

Greg,
That's fine, I was wondering how long Greg KH takes to get around to picking this up as he is very busy with other kernel work.
Cheers Nick

Quoted 19 lines · nick

Quoted 6 lines

Greg,
Not picked up of yet. I would appreciate if this gets forwarded for me as this may help it get picked up. Further more this issues I am were causing were not technical but not listening and that's why I decided to state around and learn how to my patches properly.
Cheers Nick

I saw you updated you patch Nick, thanks. I feel I can safely put my
Reviewed-by: on it. Also, if Greg KH (staging maintainer) has not picked up in the next day or so, I will submit your patch to the staging tree for you.

Quoted 6 lines · Greg Donald

Quoted 4 lines · nick

Quoted 2 lines

I am trying to improve my code as much as possible now, I really am finally understanding how terrible my code was before and I hope never again to make patches that shitty.

Quoted 8 lines

Quoted 6 lines

Quoted 6 lines

I don't think your recent progress has gone unnoticed. Any word on your latest patch getting picked up? It looked good to me.

You remind me of John Locke from Lost. "Don't tell me what I can't do!" :)

Quoted 4 lines · nick

Greg,
That's fine, I was wondering how long Greg KH takes to get around to picking this up as he is very busy with other kernel work.
Cheers Nick

I am Jeff and I was the one that responded...

Quoted 29 lines · Jeff Kirsher

Quoted 27 lines · nick

Quoted 6 lines

Greg,
Not picked up of yet. I would appreciate if this gets forwarded for me as this may help it get picked up. Further more this issues I am were causing were not technical but not listening and that's why I decided to state around and learn how to my patches properly.
Cheers Nick

I saw you updated you patch Nick, thanks. I feel I can safely put my
Reviewed-by: on it. Also, if Greg KH (staging maintainer) has not picked up in the next day or so, I will submit your patch to the staging tree for you.

Quoted 12 lines · Greg Donald

Quoted 10 lines · nick

Quoted 2 lines

I am trying to improve my code as much as possible now, I really am finally understanding how terrible my code was before and I hope never again to make patches that shitty.

I don't think your recent progress has gone unnoticed. Any word on your latest patch getting picked up? It looked good to me.

You remind me of John Locke from Lost. "Don't tell me what I can't do!" :)

Greg,
That's fine, I was wondering how long Greg KH takes to get around to picking this up as he is very busy with other kernel work.

Cheers Nick

Quoted 8 lines · Jeff Kirsher

Quoted 6 lines · nick

Greg,
Not picked up of yet. I would appreciate if this gets forwarded for me as this may help it get picked up. Further more this issues I am were causing were not technical but not listening and that's why I decided to state around and learn how to my patches properly.
Cheers Nick

Quoted 19 lines

I saw you updated you patch Nick, thanks. I feel I can safely put my
Reviewed-by: on it. Also, if Greg KH (staging maintainer) has not picked up in the next day or so, I will submit your patch to the staging tree for you.

Quoted 12 lines · Greg Donald

Quoted 10 lines · nick

Quoted 2 lines

I am trying to improve my code as much as possible now, I really am finally understanding how terrible my code was before and I hope never again to make patches that shitty.

I don't think your recent progress has gone unnoticed. Any word on your latest patch getting picked up? It looked good to me.

You remind me of John Locke from Lost. "Don't tell me what I can't do!" :)

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Quoted 3 lines · nick

Greg,
That's fine, I was wondering how long Greg KH takes to get around to picking this up as he is very busy with other kernel work.

it might take a long long time. i think he is very busy now. I have not seen his replies to patches in the kernel list for atleast last 3 weeks.

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Quoted 10 lines · Sudip Mukherjee

Quoted 3 lines · nick

Greg,
That's fine, I was wondering how long Greg KH takes to get around to picking this up as he is very busy with other kernel work.

it might take a long long time. i think he is very busy now. I have not seen his replies to patches in the kernel list for atleast last 3 weeks.

[snip]

Quoted 5 lines

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Nah. Greg KH is a robot. I'm firmly convinced that man doesn't sleep. If I didn't know better, I'd think he's a Cylon.

On a serious note; realistically, a two week window isn't unheard of for getting your patches to mainline. So long as you're not trying to

sneak in right as the merge window is closing, you'll make the next release. In fact, if you submit early enough, you can almost forget that you have a patch in a kernel when it's released 2 months later. Nothing like reading the release notes and finding your own patches that you've forgotten about over your morning coffee. :)

--
Peace and Blessings,
-Scott.

Quoted 21 lines · Scott Lovenberg

Quoted 10 lines · Sudip Mukherjee

Quoted 3 lines · nick

Greg,
That's fine, I was wondering how long Greg KH takes to get around to picking this up as he is very busy with other kernel work.

it might take a long long time. i think he is very busy now. I have not seen his replies to patches in the kernel list for atleast last 3 weeks.

[snip]

Quoted 5 lines

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Quoted 2 lines

Nah. Greg KH is a robot. I'm firmly convinced that man doesn't sleep. If I didn't know better, I'd think he's a Cylon.

well said.

Quoted 2 lines

On a serious note; realistically, a two week window isn't unheard of for getting your patches to mainline. So long as you're not trying to

mine is three weeks going on now. somehow i have managed to send my patches just at the beginning of the merge window. :( yesterday i saw Greg K-H releasing the stable patches , so i guess now he will be seeing the pending staging patches.

Quoted 27 lines · Sudip Mukherjee

Quoted 21 lines · Scott Lovenberg

Quoted 10 lines · Sudip Mukherjee

Quoted 3 lines · nick

Greg,
That's fine, I was wondering how long Greg KH takes to get around to picking this up as he is very busy with other kernel work.

it might take a long long time. i think he is very busy now. I have not seen his replies to patches in the kernel list for atleast last 3 weeks.

[snip]

Quoted 5 lines

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Quoted 2 lines

Nah. Greg KH is a robot. I'm firmly convinced that man doesn't sleep. If I didn't know better, I'd think he's a Cylon.

well said.

Quoted 7 lines

Quoted 2 lines

On a serious note; realistically, a two week window isn't unheard of for getting your patches to mainline. So long as you're not trying to

mine is three weeks going on now. somehow i have managed to send my patches just at the beginning of the merge window. :( yesterday i saw Greg K-H releasing the stable patches , so i guess now he will be seeing the pending staging patches.

It also depends on how many hops you are to the maintainer and how heavy their workload is. Sometimes you can directly submit to them, other times your patches will be passed through three trees before they see mainline. It all depends on what you're working on and who's in your "circle".

I don't mind waiting. I am just honestly trying to improve my rep here and actually(hopefully) get a job doing this full time.

Cheers Nick

Quoted 43 lines · Scott Lovenberg

Quoted 27 lines · Sudip Mukherjee

Quoted 21 lines · Scott Lovenberg

Quoted 10 lines · Sudip Mukherjee

Quoted 3 lines · nick

Greg,
That's fine, I was wondering how long Greg KH takes to get around to picking this up as he is very busy with other kernel work.

it might take a long long time. i think he is very busy now. I have not seen his replies to patches in the kernel list for atleast last 3 weeks.

[snip]

Quoted 5 lines

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Quoted 2 lines

Nah. Greg KH is a robot. I'm firmly convinced that man doesn't sleep. If I didn't know better, I'd think he's a Cylon.

well said.

Quoted 7 lines

Quoted 2 lines

On a serious note; realistically, a two week window isn't unheard of for getting your patches to mainline. So long as you're not trying to

mine is three weeks going on now. somehow i have managed to send my patches just at the beginning of the merge window. :( yesterday i saw Greg K-H releasing the stable patches , so i guess now he will be seeing the pending staging patches.

It also depends on how many hops you are to the maintainer and how heavy their workload is. Sometimes you can directly submit to them, other times your patches will be passed through three trees before they see mainline. It all depends on what you're working on and who's in your "circle".

Quoted 2 lines · nick

I don't mind waiting. I am just honestly trying to improve my rep here and actually(hopefully) get a job doing this full time.

great , even if i want to get into a job where i can do this full time , and hopefully everyone here does,
I dont want to discourage you , but considering your reputation (all over the world - maybe even outside this world) , that might be difficult.

Quoted 46 lines

Cheers Nick

Quoted 43 lines · Scott Lovenberg

Quoted 27 lines · Sudip Mukherjee

Quoted 21 lines · Scott Lovenberg

Quoted 10 lines · Sudip Mukherjee

Quoted 3 lines · nick

Greg,
That's fine, I was wondering how long Greg KH takes to get around to picking this up as he is very busy with other kernel work.

it might take a long long time. i think he is very busy now. I have not seen his replies to patches in the kernel list for atleast last 3 weeks.

[snip]

Quoted 5 lines

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Quoted 2 lines

Nah. Greg KH is a robot. I'm firmly convinced that man doesn't sleep. If I didn't know better, I'd think he's a Cylon.

well said.

Quoted 7 lines

Quoted 2 lines

On a serious note; realistically, a two week window isn't unheard of for getting your patches to mainline. So long as you're not trying to

mine is three weeks going on now. somehow i have managed to send my patches just at the beginning of the merge window. :( yesterday i saw Greg K-H releasing the stable patches , so i guess now he will be seeing the pending staging patches.

It also depends on how many hops you are to the maintainer and how heavy their workload is. Sometimes you can directly submit to them, other times your patches will be passed through three trees before they see mainline. It all depends on what you're working on and who's in your "circle".

-----Original Message-----
From: kernelnewbies-bounces+jharan=bytemobile.com at kernelnewbies.org [mailto:kernelnewbies- bounces+jharan=bytemobile.com at kernelnewbies.org] On Behalf Of Greg Donald
Sent: Tuesday, October 28, 2014 10:39 AM
To: Greg Freemyer
Cc: kernelnewbies; Jeff Kirsher; Nicholas Krause
Subject: Re: [PATCH] staging: rtl8723au: Fix brace coding style issues reported by checkpatch

Quoted 3 lines · Greg Freemyer

Lots of violations
checkpatch finds are intentionally left in place because correcting them makes the code less readable, not more readable.

Yeah, but there are still hundreds of thousands of checkpatch violations throughout the kernel that if fixed would actually improve readability.

Path            Errors  Warnings
drivers         200979  361350
arch            98791   142300
sound           25938   31028
include         13651   25598
fs              96353   22483
net             3185    19216
lib             8055    6578
tools           1126    3972
kernel          656     3203
security        47      1247
mm              203     1186
scripts         824     1168
crypto          1144    1095
block           196     656
Documentation   97      259
init            29      173
virt            18      152
samples         27      118
ipc             2       77
usr             17      20
firmware        11      19

The WARNING "line over 80 characters" currently accounts for 216K of the total violations. IMHO checkpatch should just stop complaining about the 80 char limit since that's the main offender causing new kernel developers to inadvertently lessen readability with their first patch. If the 80 char warning should be mostly ignored why have it.. it's pointless. Increase it to a 21st century value or kill it.

--
Greg Donald

Quoted 6 lines

it's pointless. Increase it to a 21st century value or kill it.

--
Greg Donald

But, but, but, what about all the kernel developers who are writing kernel code on VT100s and storing their sources on 80 column punch cards?

Not everybody can afford these newfangled disk drives, ya know. 8^)

Jeff Haran

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Just
increase your font size so that it fits nicely in your editor from end to end! :P

The WARNING "line over 80 characters" currently accounts for 216K of the total violations. IMHO checkpatch should just stop complaining about the 80 char limit since that's the main offender causing new

The WARNING "line over 80 characters" currently accounts for 216K of the total violations. IMHO checkpatch should just stop complaining about the 80 char limit since that's the main offender causing new kernel developers to inadvertently lessen readability with their first patch. If the 80 char warning should be mostly ignored why have it.. it's pointless. Increase it to a 21st century value or kill it.

It seems like you assuming the limit is based on terminal size?

There is some research in typography that suggests that it is easier to read text that is not on long lines.

Newspapers have a large
sheet of paper but they use short columns.

My display is frequently greater than 80 col. I see this as an opertunity to have two xterms next to each other, not to have lines that are longer.

Quoted 1 line · John de la Garza

It seems like you assuming the limit is based on terminal size?

Hmm, I thought it was because of 80 column punch cards and ancient printers that didn't wrap.

Quoted 2 lines

There is some research in typography that suggests that it is easier to read text that is not on long lines.

Developers don't actually read most of the code seen, over time our eyes become trained to rapidly scan for patterns. We've invented lots of tools like cscope, ctags, lxr, and grep to further keep us from having to actually read much code at all.

Quoted 3 lines

Newspapers have a large
sheet of paper but they use short columns.

Yeah, short columns with chaotic white-space. The text fills the column width and is both left and right justified. I doubt anyone does "text-align: justify;" to their code editor.

Who still reads newspapers? The 2 people still using punch cards?

Quoted 3 lines

My display is frequently greater than 80 col. I see this as an opertunity to have two xterms next to each other, not to have lines that are longer.

Do you hear yourself? "Oh, my eyes, my eyes, I can't be bothered to read code so far out to the right, it burns, it burns!"

Or "I can read two lines of code in two different files from two different contexts, but I cannot be bothered to read one longer line from a single file from a single context. I can multitask all day, but I cannot ever single-task, forget that drama!".

All I'm saying is since no one adheres to it religiously, and the fact that I've seen many times maintainers telling people to just ignore it, the 80 character checkpatch warning is pointless. Given that it really comes down to a per-case best effort attempt, just set an 80 column indicator in your editor and try to stay within it, if you can.

Keeping the checkpatch 80 character warning around is just academic masturbation.