ARM: sunxi: Fix Ippo-q8h-v5 defconfig filename
PATCH 1/1 ARM: sunxi: Fix Ippo-q8h-v5 defconfig filename
The defconfig for Ippo-q8h-v5 was incorrectly committed as "Ippo_q8h". This patch renames it correctly, as well as correct a typo in my name in the maintainers listing.
---
Feel free to squash this into
7b48d8c ARM: sunxi: Add Ippo-q8h-v5 A23 tablet board defconfig
Sorry for overlooking this.
--- configs/Ippo_q8h_defconfig => Ippo_q8h_v5_defconfig | 0 board/sunxi/MAINTAINERS | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) rename configs/Ippo_q8h_defconfig => Ippo_q8h_v5_defconfig (100%)
Ippo_q8h_v5_defconfig renamed from configs/Ippo_q8h_defconfig +0 -0
board/sunxi/MAINTAINERS +1 -1
@@ -52,6 +52,6 @@ S: Maintained F: configs/Colombus_defconfig IPPO-Q8H-V5 BOARD -M: CHen-Yu Tsai <[email protected]> +M: Chen-Yu Tsai <[email protected]> S: Maintained F: configs/Ippo_q8h_v5_defconfig
Signature · 1 line
2.1.1
PATCH 1/1 ARM: sunxi: Fix Ippo-q8h-v5 defconfig filename
Hi,
Quoted 7 lines · Chen-Yu Tsai
The defconfig for Ippo-q8h-v5 was incorrectly committed as "
Ippo_q8h". This patch renames it correctly, as well as correct a typo in my name in the maintainers listing.Signed-off-by Chen-Yu Tsai <[email protected]>---
Thats fast.
Quoted 3 lines
Feel free to squash this into
7b48d8c ARM: sunxi: Add Ippo-q8h-v5 A23 tablet board defconfig
I'm afraid it is too late as I've already send out a pull-req with that commit in it. If I had know you would be this fast I would have waited 5 minutes :)
Ah well. This fix is:
And queued up in u-boot-sunxi/next.
Regards,
Hans
Quoted 25 lines
Sorry for overlooking this.
--- configs/Ippo_q8h_defconfig => Ippo_q8h_v5_defconfig | 0 board/sunxi/MAINTAINERS | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) rename configs/Ippo_q8h_defconfig => Ippo_q8h_v5_defconfig (100%)Ippo_q8h_v5_defconfig renamed from configs/Ippo_q8h_defconfig +0
-0board/sunxi/MAINTAINERS +1
-1@@ -52,6 +52,6 @@ S: Maintained F: configs/Colombus_defconfig IPPO-Q8H-V5 BOARD -M: CHen-Yu Tsai <[email protected]> +M: Chen-Yu Tsai <[email protected]> S: Maintained F: configs/Ippo_q8h_v5_defconfig
PATCH 1/1 ARM: sunxi: Fix Ippo-q8h-v5 defconfig filename
Hi,
Quoted 17 lines · Hans de Goede
Hi,
Quoted 7 lines · Chen-Yu Tsai
The defconfig for Ippo-q8h-v5 was incorrectly committed as "
Ippo_q8h". This patch renames it correctly, as well as correct a typo in my name in the maintainers listing.Signed-off-by Chen-Yu Tsai <[email protected]>---
Thats fast.
Quoted 3 lines
Feel free to squash this into
7b48d8c ARM: sunxi: Add Ippo-q8h-v5 A23 tablet board defconfig
Quoted 7 lines
I'm afraid it is too late as I've already send out a pull-req with that commit in it. If I had know you would be this fast I would have waited 5 minutes :)
Ah well. This fix is:
Acked-by Hans de Goede <[email protected]>
Erm, you've accidentally not only renamed it but also moved it from u-boot/configs to just u-boot. Will fix myself.
Regards,
Hans
PATCH 1/1 ARM: sunxi: Fix Ippo-q8h-v5 defconfig filename
In reply to Hans de GoedeHi Hans,
Quoted 21 lines · On Fri, 24 Oct 2014 10:11:25 +0200 Hans de Goede <[email protected]> wrote:
Hi,
Quoted 7 lines · Chen-Yu Tsai
The defconfig for Ippo-q8h-v5 was incorrectly committed as "
Ippo_q8h". This patch renames it correctly, as well as correct a typo in my name in the maintainers listing.Signed-off-by Chen-Yu Tsai <[email protected]>---
Thats fast.
Quoted 3 lines
Feel free to squash this into
7b48d8c ARM: sunxi: Add Ippo-q8h-v5 A23 tablet board defconfig
I'm afraid it is too late as I've already send out a pull-req with that commit in it. If I had know you would be this fast I would have waited 5 minutes :)
Quoted 6 lines
Ah well. This fix is:
Acked-by Hans de Goede <[email protected]>And queued up in u-boot-sunxi/next.
No. This is almost like a bug fix.
Please apply it on master and send a PR to Tom asap.
Without this patch, tools/genboardscfg.py spits warnings:
$ tools/genboardscfg.py WARNING: no status info for 'Ippo_q8h' WARNING: no maintainers for 'Ippo_q8h'
It is up to you to apply trivial changes to your next branch, but please notice global changes are always happening on the upstream, for ex.
http://patchwork.ozlabs.org/patch/404351/
Of course, it is OK if you want to fix conflicts by yourself lator.
Best Regards
Masahiro Yamada
PATCH 1/1 ARM: sunxi: Fix Ippo-q8h-v5 defconfig filename
Hi,
Quoted 37 lines · Masahiro Yamada
Hi Hans,
Quoted 21 lines · On Fri, 24 Oct 2014 10:11:25 +0200 Hans de Goede <[email protected]> wrote:
Hi,
Quoted 7 lines · Chen-Yu Tsai
The defconfig for Ippo-q8h-v5 was incorrectly committed as "
Ippo_q8h". This patch renames it correctly, as well as correct a typo in my name in the maintainers listing.Signed-off-by Chen-Yu Tsai <[email protected]>---
Thats fast.
Quoted 3 lines
Feel free to squash this into
7b48d8c ARM: sunxi: Add Ippo-q8h-v5 A23 tablet board defconfig
I'm afraid it is too late as I've already send out a pull-req with that commit in it. If I had know you would be this fast I would have waited 5 minutes :)
Quoted 6 lines
Ah well. This fix is:
Acked-by Hans de Goede <[email protected]>And queued up in u-boot-sunxi/next.
No. This is almost like a bug fix.
Quoted 7 lines
Please apply it on master and send a PR to Tom asap.
Without this patch,
tools/genboardscfg.pyspits warnings:$ tools/genboardscfg.py WARNING: no status info for 'Ippo_q8h' WARNING: no maintainers for 'Ippo_q8h'
IMHO these 2 innocent warnings are not a good reason 2 rush out a fix, and since the fix actually was buggy (which I've already fixed in u-boot-sunxi/next but the original fix was no good), it is a good thing this was not rushed out.
Regards,
Hans