Skip to contentSkip to conversation

novena: Fix ethernet PHY reset sequence

PATCH New picmaster at mail.bg 3 participants 3 messages Oct 12, 2014 – Oct 30, 2014

lore
Share & tools
lore

picmaster at mail.bg

author
#0 lore raw

PATCH 1/1 novena: Fix ethernet PHY reset sequence

From: Nikolay Dimitrov <[email protected]>

This patch fixes conflict between PHY pins becoming outputs after reset and imx6 still driving the pins. It also fixes the reset timing as recommended by the PHY datasheet.

Signed-off-by Nikolay Dimitrov <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Sean Cross <[email protected]>
Cc Marek Vasut <[email protected]>
---
 board/kosagi/novena/novena.c     |    3 --
 board/kosagi/novena/novena_spl.c |   64 +++++++++++++++++++++++++++-----------
 2 files changed, 46 insertions(+), 21 deletions(-)
board/kosagi/novena/novena.c +0 -3
index 2361a3c..6add9e5 100644
@@ -237,9 +237,6 @@ int board_early_init_f(void)
 	setup_display();
 #endif
 
-	/* Bring Ethernet PHY out of reset. */
-	gpio_set_value(IMX_GPIO_NR(3, 23), 1);
-
 	return 0;
 }
board/kosagi/novena/novena_spl.c +46 -18

85 lines not on this page · raw message

Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 novena: Fix ethernet PHY reset sequence

Quoted 10 lines · On Sun, Oct 12, 2014 at 7:47 AM, <[email protected]> wrote:

From: Nikolay Dimitrov <[email protected]>

This patch fixes conflict between PHY pins becoming outputs after reset and imx6 still driving the pins. It also fixes the reset timing as recommended by the PHY datasheet.

Signed-off-by Nikolay Dimitrov <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Sean Cross <[email protected]>
Cc Marek Vasut <[email protected]>
Reviewed-by Fabio Estevam <[email protected]>
#2 lore raw

PATCH 1/1 novena: Fix ethernet PHY reset sequence

In reply to picmaster at mail.bg
Quoted 11 lines · picmaster at mail.bg

From: Nikolay Dimitrov <[email protected]>

This patch fixes conflict between PHY pins becoming outputs after reset and imx6 still driving the pins. It also fixes the reset timing as recommended by the PHY datasheet.

Signed-off-by Nikolay Dimitrov <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Sean Cross <[email protected]>
Cc Marek Vasut <[email protected]>

---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================