mtd, cfi, ubi: add missing writebufsize initialization

PATCH New Heiko Schocher 2 participants 3 messages Oct 31, 2014 Memory technology devices (MTD)

Share & tools

Heiko Schocher

author

2014-10-31 09:39 UTC #0 lore raw

PATCH 1/1 mtd, cfi, ubi: add missing writebufsize initialization

ff94bc40af3481d47546595ba73c136de6af6929 "mtd, ubi, ubifs: resync with Linux-3.14" introduced the writebufsize field in struct mtd_info, which
is not initialized in the cfi_flash driver, which leads in
not working ubi on cfi flashes. Fix it

Signed-off-by Heiko Schocher <[email protected]>

Reported-by Andrew Ruder <[email protected]>

---
@Andrew: could you test this patch, if it solves your issue?

 drivers/mtd/cfi_mtd.c | 1 +
 1 file changed, 1 insertion(+)

drivers/mtd/cfi_mtd.c +1 -0

index ac805ff..894858e 100644
@@ -226,6 +226,7 @@ int cfi_mtd_init(void)
 		mtd->flags		= MTD_CAP_NORFLASH;
 		mtd->size		= fi->size;
 		mtd->writesize		= 1;
+		mtd->writebufsize = mtd->writesize;
 
 		mtd->_erase		= cfi_mtd_erase;
 		mtd->_read		= cfi_mtd_read;

Signature · 1 line

1.8.3.1

Stefan Roese

2014-10-31 09:44 UTC #1 lore raw

PATCH 1/1 mtd, cfi, ubi: add missing writebufsize initialization

Hi Heiko,

Quoted 19 lines · Heiko Schocher

ff94bc40af3481d47546595ba73c136de6af6929 "mtd, ubi, ubifs: resync with Linux-3.14" introduced the writebufsize field in struct mtd_info, which
is not initialized in the cfi_flash driver, which leads in
not working ubi on cfi flashes. Fix it
Signed-off-by Heiko Schocher <[email protected]>
Reported-by Andrew Ruder <[email protected]>
---
@Andrew: could you test this patch, if it solves your issue?
  drivers/mtd/cfi_mtd.c | 1 +
  1 file changed, 1 insertion(+)
drivers/mtd/cfi_mtd.c +0 -0
index ac805ff..894858e 100644

drivers/mtd/cfi_mtd.c int cfi_mtd_init(void) · line 230

Quoted 5 lines

drivers/mtd/cfi_mtd.c +1 -0

@@ -226,6 +226,7 @@ int cfi_mtd_init(void)
  		mtd->flags		= MTD_CAP_NORFLASH;
  		mtd->size		= fi->size;
  		mtd->writesize		= 1;
+		mtd->writebufsize = mtd->writesize;

Small nitpicking comment: Could you please align the "=" to those lines above? Thanks!

Other than that:

Acked-by Stefan Roese <[email protected]>

Thanks,
Stefan

Heiko Schocher

author

2014-10-31 09:45 UTC #2 lore raw

PATCH 1/1 mtd, cfi, ubi: add missing writebufsize initialization

Hello Stefan,

Am 31.10.2014 10:44, schrieb Stefan Roese:

Quoted 17 lines

Hi Heiko,
Quoted 14 lines · Heiko Schocher
ff94bc40af3481d47546595ba73c136de6af6929 "mtd, ubi, ubifs: resync with Linux-3.14" introduced the writebufsize field in struct mtd_info, which
is not initialized in the cfi_flash driver, which leads in
not working ubi on cfi flashes. Fix it
Signed-off-by Heiko Schocher <[email protected]>
Reported-by Andrew Ruder <[email protected]>
---
@Andrew: could you test this patch, if it solves your issue?
drivers/mtd/cfi_mtd.c | 1 +
1 file changed, 1 insertion(+)

Quoted 12 lines

drivers/mtd/cfi_mtd.c int cfi_mtd_init(void) · line 230
Quoted 10 lines
drivers/mtd/cfi_mtd.c +1 -0
index ac805ff..894858e 100644
@@ -226,6 +226,7 @@ int cfi_mtd_init(void)
 mtd->flags = MTD_CAP_NORFLASH;
 mtd->size = fi->size;
 mtd->writesize = 1;
+ mtd->writebufsize = mtd->writesize;
 
Small nitpicking comment: Could you please align the "=" to those lines above? Thanks!

Hups ... sorry.

Quoted 3 lines

Other than that:
Acked-by Stefan Roese <[email protected]>

Thanks!

bye,
Heiko

Signature · 2 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany