Skip to contentSkip to conversation

ASoC: CS42L51_I2C depends on I2C

PATCH Applied Randy Dunlap 3 participants 3 messages Oct 31, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: CS42L51_I2C depends on I2C

From: Randy Dunlap <[email protected]>

Fix build errors when CONFIG_I2C is not enabled by making the driver depend on I2C.

../sound/soc/codecs/cs42l51-i2c.c:55:1: warning: data definition has no type or storage class [enabled by default]
module_i2c_driver(cs42l51_i2c_driver);
^
../sound/soc/codecs/cs42l51-i2c.c:55:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int] ../sound/soc/codecs/cs42l51-i2c.c:55:1: warning: parameter names (without types) in function declaration [enabled by default] ../sound/soc/codecs/cs42l51-i2c.c:45:26: warning: 'cs42l51_i2c_driver' defined but not used [-Wunused-variable]

 static struct i2c_driver cs42l51_i2c_driver = {
                          ^
---
 sound/soc/codecs/Kconfig |    1 +
 1 file changed, 1 insertion(+)
sound/soc/codecs/Kconfig +1 -0
@@ -338,6 +338,7 @@ config SND_SOC_CS42L51
 
 config SND_SOC_CS42L51_I2C
 	tristate "Cirrus Logic CS42L51 CODEC (I2C)"
+	depends on I2C
 	select SND_SOC_CS42L51
 
 config SND_SOC_CS42L52
maintainer Applied
#2 lore raw
In reply to Randy Dunlap
Quoted 4 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix build errors when CONFIG_I2C is not enabled by making the driver depend on I2C.

Applied, please do try to follow the changelog style for the subsystem.