Skip to contentSkip to conversation

usb: option: Add ID for Peiker LTE NAD

PATCH In review Matthias Klein 3 participants 4 messages Nov 1, 2014 – Nov 4, 2014

Subsystems (2)
USB USB serial
lore
Share & tools
lore

Matthias Klein

author
#0 lore raw

PATCH 1/1 usb: option: Add ID for Peiker LTE NAD

Add ID of the Peiker LTE NAD for legacy serial interface

Signed-off-by Matthias Klein <[email protected]>
---
 drivers/usb/serial/option.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/serial/option.c +1 -0
index d1a3f60..d7f1042 100644
@@ -1091,6 +1091,7 @@ static const struct usb_device_id option_ids[] = {
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6613)}, /* Onda H600/ZTE MF330 */
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x0023)}, /* ONYX 3G device */
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000)}, /* SIMCom SIM5218 */
+	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9025)}, /* Peiker LTE NAD */
 	{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) },
 	{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) },
 	{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6003),
Signature · 1 line
2.1.2
#1 lore raw
Quoted 12 lines · Matthias Klein

Add ID of the Peiker LTE NAD for legacy serial interface

Signed-off-by Matthias Klein <[email protected]>
---
  drivers/usb/serial/option.c | 1 +
  1 file changed, 1 insertion(+)
drivers/usb/serial/option.c +0 -0
index d1a3f60..d7f1042 100644

drivers/usb/serial/option.c static const struct usb_device_id option_ids[] = { · line 1097

Quoted 7 lines
drivers/usb/serial/option.c +1 -0
@@ -1091,6 +1091,7 @@ static const struct usb_device_id option_ids[] = {
  	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6613)}, /* Onda H600/ZTE MF330 */
  	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x0023)}, /* ONYX 3G device */
  	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000)}, /* SIMCom SIM5218 */
+	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9025)}, /* Peiker LTE NAD */
  	{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) },
  	{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) },
  	{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6003),

05c6:9025 already has its net interface (#4) supported by the qmi_wwan driver so your patch is wrong. There is also an ADB interface which I don't think should be driven by option.

author
#2 lore raw

Am 02.11.2014 um 04:35 schrieb Lars Melin:

Quoted 8 lines · Matthias Klein
Quoted 7 lines

Add ID of the Peiker LTE NAD for legacy serial interface

Signed-off-by Matthias Klein <[email protected]>
---
  drivers/usb/serial/option.c | 1 +
  1 file changed, 1 insertion(+)
Quoted 17 lines
Quoted 7 lines
drivers/usb/serial/option.c +0 -0
index d1a3f60..d7f1042 100644
@@ -1091,6 +1091,7 @@ static const struct usb_device_id option_ids[] = {
      { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6613)}, /* Onda H600/ZTE

MF330 */

Quoted 6 lines
      { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x0023)}, /* ONYX 3G device */
      { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000)}, /* SIMCom SIM5218 */
+    { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9025)}, /* Peiker LTE NAD */
      { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) },
      { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) },
      { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6003),

05c6:9025 already has its net interface (#4) supported by the qmi_wwan driver so your patch is wrong. There is also an ADB interface which I don't think should be driven by option.

The ID is right, and it can be used with the option driver or qmi_wwan. Ignore my patch, I will move to qmi_wwan in the future ...

#3 lore raw
Quoted 28 lines · Matthias Klein

Am 02.11.2014 um 04:35 schrieb Lars Melin:

Quoted 17 lines · Matthias Klein
Quoted 16 lines

Add ID of the Peiker LTE NAD for legacy serial interface

Signed-off-by Matthias Klein <[email protected]>
---
  drivers/usb/serial/option.c | 1 +
  1 file changed, 1 insertion(+)
drivers/usb/serial/option.c +0 -0
index d1a3f60..d7f1042 100644
@@ -1091,6 +1091,7 @@ static const struct usb_device_id option_ids[] = {
      { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6613)}, /* Onda H600/ZTE

MF330 */

      { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x0023)}, /* ONYX 3G device */
      { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000)}, /* SIMCom SIM5218 */
Quoted 10 lines
Quoted 4 lines

+ { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9025)}, /* Peiker LTE NAD */

      { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) },
      { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) },
      { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6003),

05c6:9025 already has its net interface (#4) supported by the qmi_wwan driver so your patch is wrong.
There is also an ADB interface which I don't think should be driven by option.

Quoted 2 lines

The ID is right, and it can be used with the option driver or qmi_wwan. Ignore my patch, I will move to qmi_wwan in the future ...

The serial functions should still be supported by the option driver. Both serial and QMI can be used at the same time, and applications like ModemManager will take advantage of this.

What you need to to is to make sure the option driver ignores all the USB interfaces it cannot handle. How to best do that depends on the descriptors - specifically which class codes they use.

"lsusb -vd 05c6:9025" should tell you more about that.

Assuming that all serial interfaces and the QMI interface all use ff/ff/ff, while the ADB interface probably use ff/42/01, then something like this should work:

{ USB_DEVICE_AND_INTERFACE_INFO(QUALCOMM_VENDOR_ID, 0x9025, 0xff, 0xff, 0xff), /* Peiker LTE NAD */
.driver_info = (kernel_ulong_t)&net_intf4_blacklist },

Bjørn