dbus: Remove DBUS_USERS duplicate
PATCH 1/6 dbus: Remove DBUS_USERS duplicate
--- package/dbus/dbus.mk | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
package/dbus/dbus.mk +2 -5
@@ -15,9 +15,10 @@ define DBUS_PERMISSIONS endef define DBUS_USERS -dbus -1 dbus -1 * - - - D-Bus + dbus -1 dbus -1 * /var/run/dbus - dbus DBus messagebus user endef + DBUS_DEPENDENCIES = host-pkgconf expat DBUS_CONF_ENV = ac_cv_have_abstract_sockets=yes
@@ -33,10 +34,6 @@ DBUS_CONF_OPTS = --with-dbus-user=dbus \ --with-system-socket=/var/run/dbus/system_bus_socket \ --with-system-pid-file=/var/run/messagebus.pid -define DBUS_USERS - dbus -1 dbus -1 * /var/run/dbus - dbus DBus messagebus user -endef - ifeq ($(BR2_PREFER_STATIC_LIB),y) DBUS_CONF_OPTS += LIBS='-pthread' endif
Signature · 1 line
2.1.1
PATCH 2/6 package/*/*.mk: Fix indent
Fix indent for LIBFOO_USERS and LIBFOO_PERMISSIONS as per the manual example.
--- package/bind/bind.mk | 2 +- package/busybox/busybox.mk | 4 ++-- package/dbus/dbus.mk | 2 +- package/exim/exim.mk | 2 +- package/openntpd/openntpd.mk | 2 +- package/openssh/openssh.mk | 2 +- package/sudo/sudo.mk | 2 +- package/tvheadend/tvheadend.mk | 2 +- 8 files changed, 9 insertions(+), 9 deletions(-)
package/bind/bind.mk +1 -1
@@ -88,7 +88,7 @@ BIND_POST_INSTALL_TARGET_HOOKS += BIND_TARGET_REMOVE_TOOLS endif define BIND_USERS -named -1 named -1 * /etc/bind - - BIND daemon + named -1 named -1 * /etc/bind - - BIND daemon endef $(eval $(autotools-package))
package/busybox/busybox.mk +2 -2
@@ -50,8 +50,8 @@ BUSYBOX_KCONFIG_EDITORS = menuconfig xconfig gconfig BUSYBOX_KCONFIG_OPTS = $(BUSYBOX_MAKE_OPTS) define BUSYBOX_PERMISSIONS -/bin/busybox f 4755 0 0 - - - - - -/usr/share/udhcpc/default.script f 755 0 0 - - - - - + /bin/busybox f 4755 0 0 - - - - - + /usr/share/udhcpc/default.script f 755 0 0 - - - - - endef # If mdev will be used for device creation enable it and copy S10mdev to /etc/init.d
package/dbus/dbus.mk +1 -1
@@ -11,7 +11,7 @@ DBUS_LICENSE_FILES = COPYING DBUS_INSTALL_STAGING = YES define DBUS_PERMISSIONS -/usr/libexec/dbus-daemon-launch-helper f 4755 0 0 - - - - - + /usr/libexec/dbus-daemon-launch-helper f 4755 0 0 - - - - - endef define DBUS_USERS
package/exim/exim.mk +1 -1
@@ -105,7 +105,7 @@ define EXIM_INSTALL_TARGET_CMDS endef define EXIM_USERS -exim 88 mail 8 * - - - exim + exim 88 mail 8 * - - - exim endef define EXIM_INSTALL_INIT_SYSV
package/openntpd/openntpd.mk +1 -1
@@ -16,7 +16,7 @@ define OPENNTPD_INSTALL_INIT_SYSV endef define OPENNTPD_USERS -_ntp -1 _ntp -1 * - - - Network Time Protocol daemon + _ntp -1 _ntp -1 * - - - Network Time Protocol daemon endef $(eval $(autotools-package))
package/openssh/openssh.mk +1 -1
@@ -13,7 +13,7 @@ OPENSSH_CONF_OPTS = --sysconfdir=/etc/ssh --disable-lastlog --disable-utmp \ --disable-utmpx --disable-wtmp --disable-wtmpx --disable-strip define OPENSSH_USERS -sshd -1 sshd -1 * - - - SSH drop priv user + sshd -1 sshd -1 * - - - SSH drop priv user endef # uClibc toolchain for ARC doesn't support PIE at the moment
package/sudo/sudo.mk +1 -1
@@ -29,7 +29,7 @@ endef SUDO_POST_CONFIGURE_HOOKS += SUDO_BUILD_MKSIGNAME_MKSIGLIST_HOST define SUDO_PERMISSIONS -/usr/bin/sudo f 4755 0 0 - - - - - + /usr/bin/sudo f 4755 0 0 - - - - - endef $(eval $(autotools-package))
package/tvheadend/tvheadend.mk +1 -1
@@ -85,7 +85,7 @@ define TVHEADEND_INSTALL_INIT_SYSV endef define TVHEADEND_USERS -tvheadend -1 tvheadend -1 * /home/tvheadend - video TVHeadend daemon + tvheadend -1 tvheadend -1 * /home/tvheadend - video TVHeadend daemon endef $(eval $(generic-package))
Signature · 1 line
2.1.1
PATCH 2/6 package/*/*.mk: Fix indent
Quoted 3 lines · Maxime Hadjinlian
Fix indent for
LIBFOO_USERSandLIBFOO_PERMISSIONSas per the manual example.Signed-off-by Maxime Hadjinlian <[email protected]>
(verified whitespace-only with git diff --ignore-all-space).
Regards,
Arnout
Quoted 118 lines
--- package/bind/bind.mk | 2 +- package/busybox/busybox.mk | 4 ++-- package/dbus/dbus.mk | 2 +- package/exim/exim.mk | 2 +- package/openntpd/openntpd.mk | 2 +- package/openssh/openssh.mk | 2 +- package/sudo/sudo.mk | 2 +- package/tvheadend/tvheadend.mk | 2 +- 8 files changed, 9 insertions(+), 9 deletions(-)package/bind/bind.mk +1
-1@@ -88,7 +88,7 @@ BIND_POST_INSTALL_TARGET_HOOKS += BIND_TARGET_REMOVE_TOOLS endif define BIND_USERS -named -1 named -1 * /etc/bind - - BIND daemon + named -1 named -1 * /etc/bind - - BIND daemon endef $(eval $(autotools-package))package/busybox/busybox.mk +2
-2@@ -50,8 +50,8 @@ BUSYBOX_KCONFIG_EDITORS = menuconfig xconfig gconfig BUSYBOX_KCONFIG_OPTS = $(BUSYBOX_MAKE_OPTS) define BUSYBOX_PERMISSIONS -/bin/busybox f 4755 0 0 - - - - - -/usr/share/udhcpc/default.script f 755 0 0 - - - - - + /bin/busybox f 4755 0 0 - - - - - + /usr/share/udhcpc/default.script f 755 0 0 - - - - - endef # If mdev will be used for device creation enable it and copy S10mdev to /etc/init.dpackage/dbus/dbus.mk +1
-1@@ -11,7 +11,7 @@ DBUS_LICENSE_FILES = COPYING DBUS_INSTALL_STAGING = YES define DBUS_PERMISSIONS -/usr/libexec/dbus-daemon-launch-helper f 4755 0 0 - - - - - + /usr/libexec/dbus-daemon-launch-helper f 4755 0 0 - - - - - endef define DBUS_USERSpackage/exim/exim.mk +1
-1@@ -105,7 +105,7 @@ define EXIM_INSTALL_TARGET_CMDS endef define EXIM_USERS -exim 88 mail 8 * - - - exim + exim 88 mail 8 * - - - exim endef define EXIM_INSTALL_INIT_SYSVpackage/openntpd/openntpd.mk +1
-1@@ -16,7 +16,7 @@ define OPENNTPD_INSTALL_INIT_SYSV endef define OPENNTPD_USERS -_ntp -1 _ntp -1 * - - - Network Time Protocol daemon + _ntp -1 _ntp -1 * - - - Network Time Protocol daemon endef $(eval $(autotools-package))package/openssh/openssh.mk +1
-1@@ -13,7 +13,7 @@ OPENSSH_CONF_OPTS = --sysconfdir=/etc/ssh --disable-lastlog --disable-utmp \ --disable-utmpx --disable-wtmp --disable-wtmpx --disable-strip define OPENSSH_USERS -sshd -1 sshd -1 * - - - SSH drop priv user + sshd -1 sshd -1 * - - - SSH drop priv user endef # uClibc toolchain for ARC doesn't support PIE at the momentpackage/sudo/sudo.mk +1
-1@@ -29,7 +29,7 @@ endef SUDO_POST_CONFIGURE_HOOKS += SUDO_BUILD_MKSIGNAME_MKSIGLIST_HOST define SUDO_PERMISSIONS -/usr/bin/sudo f 4755 0 0 - - - - - + /usr/bin/sudo f 4755 0 0 - - - - - endef $(eval $(autotools-package))package/tvheadend/tvheadend.mk +1
-1@@ -85,7 +85,7 @@ define TVHEADEND_INSTALL_INIT_SYSV endef define TVHEADEND_USERS -tvheadend -1 tvheadend -1 * /home/tvheadend - video TVHeadend daemon + tvheadend -1 tvheadend -1 * /home/tvheadend - video TVHeadend daemon endef $(eval $(generic-package))
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 2/6 package/*/*.mk: Fix indent
In reply to Maxime HadjinlianQuoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Maxime" == Maxime Hadjinlian <[email protected]> writes:
Fix indent for
LIBFOO_USERSandLIBFOO_PERMISSIONSas per the manual example.Signed-off-by Maxime Hadjinlian <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 3/6 package/*/*.mk: Fix indent
In reply to Maxime HadjinlianChange LIBFOO_PERMISSIONS everywhere to be a space-separated list. As nothing was specified in the manual but all our lists are space separated, there is no reason that this one should be made an exception.
--- package/busybox/busybox.mk | 4 ++-- package/nginx/nginx.mk | 2 +- package/sudo/sudo.mk | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
package/busybox/busybox.mk +2 -2
@@ -50,8 +50,8 @@ BUSYBOX_KCONFIG_EDITORS = menuconfig xconfig gconfig BUSYBOX_KCONFIG_OPTS = $(BUSYBOX_MAKE_OPTS) define BUSYBOX_PERMISSIONS - /bin/busybox f 4755 0 0 - - - - - - /usr/share/udhcpc/default.script f 755 0 0 - - - - - + /bin/busybox f 4755 0 0 - - - - - + /usr/share/udhcpc/default.script f 755 0 0 - - - - - endef # If mdev will be used for device creation enable it and copy S10mdev to /etc/init.d
package/nginx/nginx.mk +1 -1
@@ -25,7 +25,7 @@ NGINX_CONF_OPTS = \ # So, we just need to create the directories used by nginx with the right # ownership. define NGINX_PERMISSIONS - /var/lib/nginx d 755 33 33 - - - - - + /var/lib/nginx d 755 33 33 - - - - - endef # disable external libatomic_ops because its detection fails.
package/sudo/sudo.mk +1 -1
@@ -29,7 +29,7 @@ endef SUDO_POST_CONFIGURE_HOOKS += SUDO_BUILD_MKSIGNAME_MKSIGLIST_HOST define SUDO_PERMISSIONS - /usr/bin/sudo f 4755 0 0 - - - - - + /usr/bin/sudo f 4755 0 0 - - - - - endef $(eval $(autotools-package))
Signature · 1 line
2.1.1
PATCH 3/6 package/*/*.mk: Fix indent
Quoted 16 lines · Maxime Hadjinlian
Change
LIBFOO_PERMISSIONSeverywhere to be a space-separated list. As nothing was specified in the manual but all our lists are space separated, there is no reason that this one should be made an exception.Signed-off-by Maxime Hadjinlian <[email protected]>--- package/busybox/busybox.mk | 4 ++-- package/nginx/nginx.mk | 2 +- package/sudo/sudo.mk | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)package/busybox/busybox.mk +0
-0
package/busybox/busybox.mk BUSYBOX_KCONFIG_EDITORS = menuconfig xconfig gconfig · line 54
Quoted 7 lines
package/busybox/busybox.mk +2
-2@@ -50,8 +50,8 @@ BUSYBOX_KCONFIG_EDITORS = menuconfig xconfig gconfig BUSYBOX_KCONFIG_OPTS = $(BUSYBOX_MAKE_OPTS) define BUSYBOX_PERMISSIONS - /bin/busybox f 4755 0 0 - - - - - - /usr/share/udhcpc/default.script f 755 0 0 - - - - - + /bin/busybox f 4755 0 0 - - - - - + /usr/share/udhcpc/default.script f 755 0 0 - - - - -
I don't like this change - the alignment really helps a lot in this case.
However, it should be based on spaces, not tabs. tabwidth may be different for
different people so tabs are not suitable for alignment.
The rest of the patch looks OK to me.
Regards,
Arnout
Quoted 30 lines
package/busybox/busybox.mk +0
-0endef # If mdev will be used for device creation enable it and copy S10mdev to /etc/init.dpackage/nginx/nginx.mk +1
-1@@ -25,7 +25,7 @@ NGINX_CONF_OPTS = \ # So, we just need to create the directories used by nginx with the right # ownership. define NGINX_PERMISSIONS - /var/lib/nginx d 755 33 33 - - - - - + /var/lib/nginx d 755 33 33 - - - - - endef # disable external libatomic_ops because its detection fails.package/sudo/sudo.mk +1
-1@@ -29,7 +29,7 @@ endef SUDO_POST_CONFIGURE_HOOKS += SUDO_BUILD_MKSIGNAME_MKSIGLIST_HOST define SUDO_PERMISSIONS - /usr/bin/sudo f 4755 0 0 - - - - - + /usr/bin/sudo f 4755 0 0 - - - - - endef $(eval $(autotools-package))
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 4/6 makedevs: Rework README
In reply to Maxime HadjinlianMake all the example as a space separated list.
The definition of the different type was modified to look like the same section on the manual.
--- package/makedevs/README | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
package/makedevs/README +9 -9
@@ -6,7 +6,7 @@ You can do all sorts of interesting things with a device table file. For example, if you want to adjust the permissions on a particular file you can just add an entry like: - /sbin/foobar f 2755 0 0 - - - - - + /sbin/foobar f 2755 0 0 - - - - - and (assuming the file /sbin/foobar exists) it will be made setuid root (regardless of what its permissions are on the host filesystem.
@@ -15,20 +15,20 @@ Furthermore, you can use a single table entry to create a many device minors. For example, if I wanted to create /dev/hda and /dev/hda[0-15] I could just use the following two table entries: - /dev/hda b 640 0 0 3 0 0 0 - - /dev/hda b 640 0 0 3 1 1 1 15 + /dev/hda b 640 0 0 3 0 0 0 - + /dev/hda b 640 0 0 3 1 1 1 15 Device table entries take the form of: -<name> <type> <mode> <uid> <gid> <major> <minor> <start> <inc> <count> +<name> <type> <mode> <uid> <gid> <major> <minor> <start> <inc> <count> where name is the file name, type can be one of: - f A regular file - d Directory - c Character special device file - b Block special device file - p Fifo (named pipe) + f: A regular file + d: Directory + c: Character special device file + b: Block special device file + p: Fifo (named pipe) uid is the user id for the target file, gid is the group id for the target file. The rest of the entries (major, minor, etc) apply only
Signature · 1 line
2.1.1
PATCH 5/6 manual: Rework makedevs syntax
In reply to Maxime HadjinlianState that it should be a space separated list and fix the example. Also reduce the number of dash used to 4.
--- docs/manual/makedev-syntax.txt | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-)
docs/manual/makedev-syntax.txt +13 -11
@@ -11,13 +11,14 @@ create and how to create them, in order to avoid calls to mknod. This syntax is derived from the makedev utility, and more complete documentation can be found in the +package/makedevs/README+ file. -It takes the form of a line for each file, with the following layout: +It takes the form of a space separated list of fields, one file per +line; the fields are: |=========================================================== |name |type |mode |uid |gid |major |minor |start |inc |count |=========================================================== -There are a few non-trivial blocks here: +There are a few non-trivial blocks: - +name+ is the path to the file you want to create/modify - +type+ is the type of the file, being one of:
@@ -35,22 +36,23 @@ There are a few non-trivial blocks here: Let's say you want to change the permissions of a given file; using this syntax, you will need to put: -------------------------------------------------------------------- -/usr/bin/foobar f 644 0 0 - - - - - -------------------------------------------------------------------- + +---- +/usr/bin/foobar f 644 0 0 - - - - - +---- On the other hand, if you want to create the device file +/dev/hda+ and the corresponding 15 files for the partitions, you will need for +/dev/hda+: -------------------------------------------------------------------- -/dev/hda b 640 0 0 3 0 0 0 - -------------------------------------------------------------------- +---- +/dev/hda b 640 0 0 3 0 0 0 - +---- and then for device files corresponding to the partitions of +/dev/hda+, +/dev/hdaX+, +X+ ranging from 1 to 15: -------------------------------------------------------------------- -/dev/hda b 640 0 0 3 1 1 1 15 -------------------------------------------------------------------- +---- +/dev/hda b 640 0 0 3 1 1 1 15 +----
Signature · 1 line
2.1.1
PATCH 6/6 manual: Various tidy changes
In reply to Maxime HadjinlianChanges performed all over the manual:
- In AsciiDoc, you only need 4 dashes to make a code block.
- Remove trailing spaces.
- Adding '// vim: set syntax=asciidoc:' when missing.
- Adding empty lines were needed.
- When an example of an external command is done, harmoize the use of the scheme:
' $ cmd'
--- docs/manual/adding-packages-autotools.txt | 6 +-- docs/manual/adding-packages-cmake.txt | 4 +- docs/manual/adding-packages-directory.txt | 53 +++++++++++++++------------ docs/manual/adding-packages-generic.txt | 24 ++++++------ docs/manual/adding-packages-hooks.txt | 4 +- docs/manual/adding-packages-kconfig.txt | 4 +- docs/manual/adding-packages-luarocks.txt | 4 +- docs/manual/adding-packages-perl.txt | 4 +- docs/manual/adding-packages-python.txt | 4 +- docs/manual/adding-packages-tips.txt | 4 +- docs/manual/adding-packages-virtual.txt | 24 ++++++------ docs/manual/beyond-buildroot.txt | 4 +- docs/manual/ccache-support.txt | 4 +- docs/manual/common-usage.txt | 48 ++++++++++++------------ docs/manual/contribute.txt | 28 +++++++------- docs/manual/customize-directory-structure.txt | 12 +++--- docs/manual/customize-outside-br.txt | 25 +++++++------ docs/manual/customize-packages.txt | 16 ++++---- docs/manual/customize-patches.txt | 1 + docs/manual/download-location.txt | 4 +- docs/manual/faq-troubleshooting.txt | 12 +++--- docs/manual/legal-notice.txt | 4 +- docs/manual/make-tips.txt | 20 +++++----- docs/manual/makeusers-syntax.txt | 1 + docs/manual/package-make-target.txt | 4 +- docs/manual/patch-policy.txt | 12 +++--- docs/manual/quickstart.txt | 20 +++++----- docs/manual/rebuilding-packages.txt | 6 +-- docs/manual/using-buildroot-debugger.txt | 12 +++--- docs/manual/using-buildroot-development.txt | 20 +++++----- docs/manual/writing-rules.txt | 32 ++++++++-------- 31 files changed, 214 insertions(+), 206 deletions(-)
docs/manual/adding-packages-autotools.txt +3 -3
@@ -10,7 +10,7 @@ First, let's see how to write a +.mk+ file for an autotools-based package, with an example : ------------------------- +---- 01: ################################################################################ 02: # 03: # libfoo
@@ -26,7 +26,7 @@ package, with an example : 13: LIBFOO_DEPENDENCIES = libglib2 host-pkgconf 14: 15: $(eval $(autotools-package)) ------------------------- +---- On line 7, we declare the version of the package.
@@ -125,7 +125,7 @@ cases, typical packages will therefore only use a few of them. variables to pass to the 'autoreconf' program if +LIBFOO_AUTORECONF=YES+. These are passed in the environment of the 'autoreconf' command. By default, empty. - + * +LIBFOO_AUTORECONF_OPTS+ to specify additional options passed to the 'autoreconf' program if +LIBFOO_AUTORECONF=YES+. By default, empty.
docs/manual/adding-packages-cmake.txt +2 -2
@@ -10,7 +10,7 @@ First, let's see how to write a +.mk+ file for a CMake-based package, with an example : ------------------------- +---- 01: ################################################################################ 02: # 03: # libfoo
@@ -26,7 +26,7 @@ with an example : 13: LIBFOO_DEPENDENCIES = libglib2 host-pkgconf 14: 15: $(eval $(cmake-package)) ------------------------- +---- On line 7, we declare the version of the package.
docs/manual/adding-packages-directory.txt +29 -24
143 lines not on this page · raw message
docs/manual/adding-packages-generic.txt +12 -12
@@ -12,7 +12,7 @@ system is based on hand-written Makefiles or shell scripts. ==== +generic-package+ tutorial ------------------------------- +---- 01: ################################################################################ 02: # 03: # libfoo
@@ -56,7 +56,7 @@ system is based on hand-written Makefiles or shell scripts. 41: endef 42: 43: $(eval $(generic-package)) --------------------------------- +---- The Makefile begins on line 7 to 11 with metadata information: the version of the package (+LIBFOO_VERSION+), the name of the
@@ -103,9 +103,9 @@ Package divine installs shell script '$(STAGING_DIR)/usr/bin/divine-config'. So its fixup would be: --------------------------------- +---- DIVINE_CONFIG_SCRIPTS = divine-config --------------------------------- +---- ================================ .Config script: 'imagemagick' package:
@@ -115,11 +115,11 @@ Package imagemagick installs the following scripts: So it's fixup would be: --------------------------------- +---- IMAGEMAGICK_CONFIG_SCRIPTS = \ Magick-config Magick++-config \ MagickCore-config MagickWand-config Wand-config --------------------------------- +---- ================================ On line 14, we specify the list of dependencies this package relies
@@ -166,10 +166,10 @@ for the host. It is possible to call both of them in a single +.mk+ file: once to create the rules to generate a target package and once to create the rules to generate a host package: ----------------------- +---- $(eval $(generic-package)) $(eval $(host-generic-package)) ----------------------- +---- This might be useful if the compilation of the target package requires some tools to be installed on the host. If the package name is
@@ -371,9 +371,9 @@ information is (assuming the package name is +libfoo+) : The recommended way to define these variables is to use the following syntax: ----------------------- +---- LIBFOO_VERSION = 2.32 ----------------------- +---- Now, the variables that define what should be performed at the different steps of the build process.
@@ -431,13 +431,13 @@ different steps of the build process. The preferred way to define these variables is: ----------------------- +---- define LIBFOO_CONFIGURE_CMDS action 1 action 2 action 3 endef ----------------------- +---- In the action definitions, you can use the following variables:
docs/manual/adding-packages-hooks.txt +2 -2
@@ -50,14 +50,14 @@ These variables are 'lists' of variable names containing actions to be performed at this hook point. This allows several hooks to be registered at a given hook point. Here is an example: ----------------------- +---- define LIBFOO_POST_PATCH_FIXUP action1 action2 endef LIBFOO_POST_PATCH_HOOKS += LIBFOO_POST_PATCH_FIXUP ----------------------- +---- ==== Using the +POST_RSYNC+ hook The +POST_RSYNC+ hook is run only for packages that use a local source,
docs/manual/adding-packages-kconfig.txt +2 -2
@@ -24,11 +24,11 @@ In order to use the +kconfig-package+ infrastructure for a Buildroot package, the minimally required lines in the +.mk+ file, in addition to the variables required by the +generic-package+ infrastructure, are: ------------------------------- +---- FOO_KCONFIG_FILE = reference-to-source-configuration-file $(eval $(kconfig-package)) ------------------------------- +---- This snippet creates the following make targets:
docs/manual/adding-packages-luarocks.txt +2 -2
@@ -10,7 +10,7 @@ First, let's see how to write a +.mk+ file for a LuaRocks-based package, with an example : ------------------------- +---- 01: ################################################################################ 02: # 03: # luafoo
@@ -26,7 +26,7 @@ with an example : 13: LUAFOO_LICENSE_FILES = COPYING 14: 15: $(eval $(luarocks-package)) ------------------------- +---- On line 7, we declare the version of the package (the same as in the rockspec, which is the concatenation of the upstream version and the rockspec revision,
docs/manual/adding-packages-perl.txt +2 -2
@@ -10,7 +10,7 @@ First, let's see how to write a +.mk+ file for a Perl/CPAN package, with an example : ------------------------- +---- 01: ################################################################################ 02: # 03: # perl-foo-bar
@@ -25,7 +25,7 @@ with an example : 12: PERL_FOO_BAR_LICENSE_FILES = LICENSE 13: 14: $(eval $(perl-package)) ------------------------- +---- On line 7, we declare the version of the package.
docs/manual/adding-packages-python.txt +2 -2
@@ -14,7 +14,7 @@ recognizable by the usage of a +setup.py+ script. First, let's see how to write a +.mk+ file for a Python package, with an example : ------------------------- +---- 01: ################################################################################ 02: # 03: # python-foo
@@ -31,7 +31,7 @@ with an example : 14: PYTHON_FOO_SETUP_TYPE = distutils 15: 16: $(eval $(python-package)) ------------------------- +---- On line 7, we declare the version of the package.
docs/manual/adding-packages-tips.txt +2 -2
@@ -41,10 +41,10 @@ However, it is possible to download tarballs directly from the repository on GitHub. As GitHub is known to have changed download mechanisms in the past, the 'github' helper function should be used as shown below. ------------------------- +---- FOO_VERSION = v1.0 # tag or full commit ID FOO_SITE = $(call github,<user>,<package>,$(FOO_VERSION)) ------------------------- +---- .Notes - The FOO_VERSION can either be a tag or a commit ID.
docs/manual/adding-packages-virtual.txt +12 -12
@@ -26,14 +26,14 @@ First, let's create the virtual package. The +Config.in+ file of virtual package 'something-virtual' should contain: ---------------------------- +---- 01: config BR2_PACKAGE_HAS_SOMETHING_VIRTUAL 02: bool 03: 04: config BR2_PACKAGE_PROVIDES_SOMETHING_VIRTUAL 05: depends on BR2_PACKAGE_HAS_SOMETHING_VIRTUAL 06: string ---------------------------- +---- In this file, we declare two options, +BR2_PACKAGE_HAS_SOMETHING_VIRTUAL+ and +BR2_PACKAGE_PROVIDES_SOMETHING_VIRTUAL+, whose values will be used by the
@@ -43,7 +43,7 @@ providers. The +.mk+ for the virtual package should just evaluate the +virtual-package+ macro: ---------------------------- +---- 01: ################################################################################ 02: # 03: # something-virtual
@@ -51,7 +51,7 @@ The +.mk+ for the virtual package should just evaluate the +virtual-package+ mac 05: ################################################################################ 06: 07: $(eval $(virtual-package)) ---------------------------- +---- The ability to have target and host packages is also available, with the +host-virtual-package+ macro.
@@ -64,7 +64,7 @@ modifications. The +Config.in+ file of the package 'some-provider', which provides the functionalities of 'something-virtual', should contain: ---------------------------- +---- 01: config BR2_PACKAGE_SOME_PROVIDER 02: bool "some-provider" 03: select BR2_PACKAGE_HAS_SOMETHING_VIRTUAL
@@ -77,7 +77,7 @@ functionalities of 'something-virtual', should contain: 10: config BR2_PACKAGE_PROVIDES_SOMETHING_VIRTUAL 11: default "some-provider" 12: endif ---------------------------- +---- On line 3, we select +BR2_PACKAGE_HAS_SOMETHING_VIRTUAL+, and on line 11, we set the value of +BR2_PACKAGE_PROVIDES_SOMETHING_VIRTUAL+ to the name of the
@@ -92,9 +92,9 @@ The +.mk+ file should also declare an additional variable +SOME_PROVIDER_PROVIDES+ to contain the names of all the virtual packages it is an implementation of: ---------------------------- +---- 01: SOME_PROVIDER_PROVIDES = something-virtual ---------------------------- +---- Of course, do not forget to add the proper build and runtime dependencies for this package!
@@ -107,14 +107,14 @@ if you implement a new provider for an existing virtual package. When adding a package that requires a certain +FEATURE+ provided by a virtual package, you have to use +depends on BR2_PACKAGE_HAS_FEATURE+, like so: ---------------------------- +---- config BR2_PACKAGE_HAS_FEATURE bool config BR2_PACKAGE_FOO bool "foo" depends on BR2_PACKAGE_HAS_FEATURE ---------------------------- +---- ==== Notes on depending on a specific provider
@@ -124,7 +124,7 @@ provider. Let's take an example with two providers for a +FEATURE+: ---------------------------- +---- config BR2_PACKAGE_HAS_FEATURE bool
@@ -135,7 +135,7 @@ config BR2_PACKAGE_FOO config BR2_PACKAGE_BAR bool "bar" select BR2_PACKAGE_HAS_FEATURE ---------------------------- +---- And you are adding a package that needs +FEATURE+ as provided by +foo+, but not as provided by +bar+.
docs/manual/beyond-buildroot.txt +2 -2
@@ -13,9 +13,9 @@ images_ menu. After a complete build, just run the following commands to setup the NFS-root directory: -------------------- +---- sudo tar -xavf /path/to/output_dir/rootfs.tar -C /path/to/nfs_root_dir -------------------- +---- Remember to add this path to +/etc/exports+.
docs/manual/ccache-support.txt +2 -2
@@ -26,10 +26,10 @@ misses, etc.) by running +make ccache-stats+. The make target +ccache-options+ and the +CCACHE_OPTIONS+ variable provide more generic access to the ccache. For example ------------------ +---- # set cache limit size make CCACHE_OPTIONS="--max-size=5G" ccache-options # zero statistics counters make CCACHE_OPTIONS="--zero-stats" ccache-options ------------------ +----
docs/manual/common-usage.txt +24 -24
127 lines not on this page · raw message
docs/manual/contribute.txt +14 -14
@@ -72,9 +72,9 @@ basically two things that can be done: can be removed. In the commit message of a patch fixing an autobuild failure, add a reference to the build result directory, as follows: ---------------------- +---- Fixes http://autobuild.buildroot.org/results/51000a9d4656afe9e0ea6f07b9f8ed374c2e4069 ---------------------- +---- === Reviewing and testing patches
@@ -153,10 +153,10 @@ When browsing patches in the patchwork management interface, an +mbox+ link is provided at the top of the page. Copy this link address and run the following commands: ---------------------- +---- $ git checkout -b <test-branch-name> $ wget -O - <mbox-url> | git am ---------------------- +---- Another option for applying patches is to create a bundle. A bundle is a set of patches that you can group together using the patchwork
@@ -187,18 +187,18 @@ changes committed in your local git view, _rebase_ your development branch on top of the upstream tree before generating a patch set. To do so, run: ---------------------- +---- $ git fetch --all --tags $ git rebase origin/master ---------------------- +---- Now, you are ready to generate then submit your patch set. To generate it, run: ---------------------- +---- $ git format-patch -M -n -s -o outgoing origin/master ---------------------- +---- This will generate patch files in the +outgoing+ subdirectory, automatically adding the +Signed-off-by+ line.
@@ -208,9 +208,9 @@ before submitting them, using your favorite text editor. Lastly, send/submit your patch set to the Buildroot mailing list: ---------------------- +---- $ git send-email --to buildroot at buildroot.org outgoing/* ---------------------- +---- Note that +git+ should be configured to use your mail account. To configure +git+, see +man git-send-email+ or google it.
@@ -261,7 +261,7 @@ be preserved forever in the +git+ history of the project. Hereafter the recommended layout: ---------------- +---- Patch title: short explanation, max 72 chars A paragraph that explains the problem, and how it manifests itself. If
@@ -284,7 +284,7 @@ Changes v2 -> v3: Changes v1 -> v2: - alpha bravo (suggested by John) - charly delta ---------------- +---- Any patch revision should include the version number. The version number is simply composed of the letter +v+ followed by an +integer+ greater or
@@ -293,10 +293,10 @@ equal to two (i.e. "PATCH v2", "PATCH v3" ...). This can be easily handled with +git format-patch+ by using the option +--subject-prefix+: ---------------------- +---- $ git format-patch --subject-prefix "PATCH v4" \ -M -s -o outgoing origin/master ---------------------- +---- [[reporting-bugs]] === Reporting issues/bugs or getting help
docs/manual/customize-directory-structure.txt +6 -6
@@ -15,7 +15,7 @@ Orthogonal to this directory structure, you can choose _where_ you place this structure itself: either inside the Buildroot tree, or outside of it using +BR2_EXTERNAL+. Both options are valid, the choice is up to you. ------ +---- +-- board/ | +-- <company>/ | +-- <boardname>/
@@ -49,7 +49,7 @@ it using +BR2_EXTERNAL+. Both options are valid, the choice is up to you. | +-- Config.in (if using BR2_EXTERNAL) +-- external.mk (if using BR2_EXTERNAL) ------- +---- Details on the files shown above are given further in this chapter.
@@ -77,7 +77,7 @@ more than two layers. An example directory structure for where a user has two customization layers 'common' and 'fooboard' is: ------ +---- +-- board/ +-- <company>/ +-- common/
@@ -96,14 +96,14 @@ layers 'common' and 'fooboard' is: | +-- ... +-- patches/ +-- ... ------ +---- For example, if the user has the +BR2_GLOBAL_PATCH_DIR+ configuration option set as: ------ +---- BR2_GLOBAL_PATCH_DIR="board/<company>/common/patches board/<company>/fooboard/patches" ------ +---- then first the patches from the 'common' layer would be applied, followed by the patches from the 'fooboard' layer.
docs/manual/customize-outside-br.txt +13 -12
@@ -1,4 +1,5 @@ // -*- mode:doc -*- ; +// vim: set syntax=asciidoc: [[outside-br-custom]] === Keeping customizations outside of Buildroot
@@ -31,29 +32,29 @@ to the Buildroot output directory. Some examples: ------ +---- buildroot/ $ make BR2_EXTERNAL=/path/to/foobar menuconfig ------ +---- From now on, external definitions from the +/path/to/foobar+ directory will be used: ------ +---- buildroot/ $ make buildroot/ $ make legal-info ------ +---- We can switch to another external definitions directory at any time: ------ +---- buildroot/ $ make BR2_EXTERNAL=/where/we/have/barfoo xconfig ------ +---- Or disable the usage of external definitions: ------ +---- buildroot/ $ make BR2_EXTERNAL= xconfig ------ +---- +BR2_EXTERNAL+ allows three different things:
@@ -80,16 +81,16 @@ The main usage of this is to store package recipes. The recommended way to do this is to write a +$(BR2_EXTERNAL)/Config.in+ file that looks like: + ------- +---- source "$BR2_EXTERNAL/package/package1/Config.in" source "$BR2_EXTERNAL/package/package2/Config.in" ------- +---- + Then, have a +$(BR2_EXTERNAL)/external.mk+ file that looks like: + ------- +---- include $(sort $(wildcard $(BR2_EXTERNAL)/package/*/*.mk)) ------- +---- + And then in +$(BR2_EXTERNAL)/package/package1+ and +$(BR2_EXTERNAL)/package/package2+ create normal Buildroot
docs/manual/customize-packages.txt +8 -8
@@ -33,27 +33,27 @@ includes these additional +.mk+ files. Therefore, create a file +package/<company>/<company>.mk+ with following contents (assuming you have only one extra directory level below +package/<company>/+): ------ +---- include $(sort $(wildcard package/<company>/*/*.mk)) ------ +---- If you are using +BR2_EXTERNAL+, create a file +$(BR2_EXTERNAL)/external.mk+ with following contents (again assuming only one extra level): ------ +---- include $(sort $(wildcard $(BR2_EXTERNAL)/package/*/*.mk)) ------ +---- For the +Config.in+ files, create a file +package/<company>/Config.in+ that includes the +Config.in+ files of all your packages. An exhaustive list has to be provided since wildcards are not supported in the source command of kconfig. For example: ------ +---- source "package/<company>/package1/Config.in" source "package/<company>/package2/Config.in" ------ +---- Include this new file +package/<company>/Config.in+ from +package/Config.in+, preferably in a company-specific menu to make
@@ -62,10 +62,10 @@ merges with future Buildroot versions easier. If you are using +BR2_EXTERNAL+, create a file +$(BR2_EXTERNAL)/Config.in+ with similar contents: ------ +---- source "$BR2_EXTERNAL/package/package1/Config.in" source "$BR2_EXTERNAL/package/package2/Config.in" ------ +---- You do not have to add an include for this +$(BR2_EXTERNAL)/Config.in+ file as it is included automatically.
docs/manual/customize-patches.txt +1 -0
@@ -1,4 +1,5 @@ // -*- mode:doc -*- ; +// vim: set syntax=asciidoc: [[customize-patches]] === Adding project-specific patches
docs/manual/download-location.txt +2 -2
@@ -16,9 +16,9 @@ shared download location. This can be achieved by pointing the set, then the value of +BR2_DL_DIR+ in the Buildroot configuration is overridden. The following line should be added to +<~/.bashrc>+. ------------------ +---- $ export BR2_DL_DIR <shared download location> ------------------ +---- The download location can also be set in the +.config+ file, with the +BR2_DL_DIR+ option. Unlike most options in the .config file, this value
docs/manual/faq-troubleshooting.txt +6 -6
@@ -10,19 +10,19 @@ If the boot process seems to hang after the following messages (messages not necessarily exactly similar, depending on the list of packages selected): ------------------------- +---- Freeing init memory: 3972K Initializing random number generator... done. Starting network... Starting dropbear sshd: generating rsa key... generating dsa key... OK ------------------------- +---- then it means that your system is running, but didn't start a shell on the serial console. In order to have the system start a shell on your -serial console, you have to go into the Buildroot configuration, in -+System configuration+, modify +Run a getty (login prompt) after boot+ -and set the appropriate port and baud rate in the +getty options+ -submenu. This will automatically tune the +/etc/inittab+ file of the +serial console, you have to go into the Buildroot configuration, in ++System configuration+, modify +Run a getty (login prompt) after boot+ +and set the appropriate port and baud rate in the +getty options+ +submenu. This will automatically tune the +/etc/inittab+ file of the generated system so that a shell starts on the correct serial port. [[faq-no-compiler-on-target]]
docs/manual/legal-notice.txt +2 -2
@@ -24,9 +24,9 @@ To make this easier for you, Buildroot can collect for you some material you will probably need. To produce this material, after you have configured Buildroot with +make menuconfig+, +make xconfig+ or +make gconfig+, run: --------------------- +---- make legal-info --------------------- +---- Buildroot will collect legally-relevant material in your output directory, under the +legal-info/+ subdirectory.
docs/manual/make-tips.txt +10 -10
@@ -8,15 +8,15 @@ This is a collection of tips that help you make the most of Buildroot. .Display all commands executed by make: --------------------- +---- $ make V=1 <target> --------------------- +---- .Display all available targets: --------------------- +---- $ make help --------------------- +---- Not all targets are always available, some settings in the +.config+ file may hide some targets:
@@ -37,19 +37,19 @@ configuration options are changed. To delete all build products (including build directories, host, staging and target trees, the images and the toolchain): --------------------- +---- $ make clean --------------------- +---- .Generating the manual: The present manual sources are located in the 'docs/manual' directory. To generate the manual: ---------------------------------- +---- $ make manual-clean $ make manual ---------------------------------- +---- The manual outputs will be generated in 'output/docs/manual'.
@@ -61,9 +61,9 @@ The manual outputs will be generated in 'output/docs/manual'. To delete all build products as well as the configuration: --------------------- +---- $ make distclean --------------------- +---- .Notes If +ccache+ is enabled, running +make clean+ or +distclean+ does
docs/manual/makeusers-syntax.txt +1 -0
@@ -1,4 +1,5 @@ // -*- mode:doc -*- ; +// vim: set syntax=asciidoc: [[makeuser-syntax]] == Makeusers syntax documentation
docs/manual/package-make-target.txt +2 -2
@@ -12,9 +12,9 @@ For packages relying on the Buildroot infrastructure, there are numerous special make targets that can be called independently like this: ------------- +---- make <package>-<target> ------------- +---- The package build targets are (in the order they are executed):
docs/manual/patch-policy.txt +6 -6
@@ -101,7 +101,7 @@ Otherwise, concatenate the header with the output of the At the end, the patch should look like: ---------------- +---- configure.ac: add C++ support test Signed-off-by: John Doe <[email protected]>
@@ -121,7 +121,7 @@ AC_PROG_MAKE_SET + AC_LANG_POP([C++])]) + +AM_CONDITIONAL([CXX_WORKS], [test "x$rw_cv_prog_cxx_works" = "xyes"]) ---------------- +---- === Integrating patches found on the Web
@@ -132,15 +132,15 @@ Depending on whether the patch has been obtained from the project repository itself, or from somewhere on the web, add one of the following tags: ---------------- +---- Backported from: <some commit id> ---------------- +---- or ---------------- +---- Fetch from: <some url> ---------------- +---- It is also sensible to add a few words about any changes to the patch that may have been necessary.
docs/manual/quickstart.txt +10 -10
@@ -15,27 +15,27 @@ http://www.busybox.net/[BusyBox]. From the buildroot directory, run --------------------- +---- $ make menuconfig --------------------- +---- for the original curses-based configurator, or --------------------- +---- $ make nconfig --------------------- +---- for the new curses-based configurator, or --------------------- +---- $ make xconfig --------------------- +---- for the Qt-based configurator, or --------------------- +---- $ make gconfig --------------------- +---- for the GTK-based configurator.
@@ -56,9 +56,9 @@ read by the top-level Makefile. To start the build process, simply run: --------------------- +---- $ make --------------------- +---- You *should never* use +make -jN+ with Buildroot: top-level parallel make is currently not supported. Instead, use the +BR2_JLEVEL+ option
docs/manual/rebuilding-packages.txt +3 -3
@@ -76,9 +76,9 @@ necessary, and you will save more and more time. For reference, a full rebuild is achieved by running: ---------------- -$ make clean all ---------------- +---- + $ make clean all +---- [[rebuild-pkg]] === Understanding how to rebuild packages
docs/manual/using-buildroot-debugger.txt +6 -6
@@ -24,9 +24,9 @@ To achieve this: Now, to start debugging a program called +foo+, you should run on the target: ----------------------------- +---- gdbserver :2345 foo ----------------------------- +---- This will cause +gdbserver+ to listen on TCP port 2345 for a connection from the cross gdb.
@@ -34,9 +34,9 @@ from the cross gdb. Then, on the host, you should start the cross gdb using the following command line: ----------------------------- +---- <buildroot>/output/host/usr/bin/<tuple>-gdb -x <buildroot>/output/staging/usr/share/buildroot/gdbinit foo ----------------------------- +---- Of course, +foo+ must be available in the current directory, built with debugging symbols. Typically you start this command from the
@@ -48,6 +48,6 @@ cross gdb where to find the libraries of the target. Finally, to connect to the target from the cross gdb: ----------------------------- +---- (gdb) target remote <target ip address>:2345 ----------------------------- +----
docs/manual/using-buildroot-development.txt +10 -10
@@ -35,17 +35,17 @@ tree, but a different location can be specified through the In this _override_ file, Buildroot expects to find lines of the form: ------------------- +---- <pkg1>_OVERRIDE_SRCDIR = /path/to/pkg1/sources <pkg2>_OVERRIDE_SRCDIR = /path/to/pkg2/sources ------------------- +---- For example: ------------------- +---- LINUX_OVERRIDE_SRCDIR = /home/bob/linux/ BUSYBOX_OVERRIDE_SRCDIR = /home/bob/busybox/ ------------------- +---- When Buildroot finds that for a given package, an +<pkg>_OVERRIDE_SRCDIR+ has been defined, it will no longer attempt to
@@ -67,17 +67,17 @@ process of just this package. In the example of the +linux+ package above, the developer can then make a source code change in +/home/bob/linux+ and then run: ------------------------ -make linux-rebuild all ------------------------ +---- + $ make linux-rebuild all +---- and in a matter of seconds gets the updated Linux kernel image in +output/images+. Similarly, a change can be made to the BusyBox source code in +/home/bob/busybox+, and after: ------------------------ -make busybox-rebuild all ------------------------ +---- + $ make busybox-rebuild all +---- the root filesystem image in +output/images+ contains the updated BusyBox.
docs/manual/writing-rules.txt +16 -16
@@ -23,7 +23,7 @@ Buildroot. An entry has the following pattern: ---------------------- +---- config BR2_PACKAGE_LIBFOO bool "libfoo" depends on BR2_PACKAGE_LIBBAZ
@@ -32,7 +32,7 @@ config BR2_PACKAGE_LIBFOO This is a comment that explains what libfoo is. http://foosoftware.org/libfoo/ ---------------------- +---- * The +bool+, +depends on+, +select+ and +help+ lines are indented with one tab.
@@ -53,31 +53,31 @@ http://kernel.org/doc/Documentation/kbuild/kconfig-language.txt[]. preferably in lowercase, enclosed between separators made of 80 hashes. A blank line is mandatory after the header: + ---------------------- +---- ################################################################################ # # libfoo # ################################################################################ ---------------------- +---- + * Assignment: use +=+ preceded and followed by one space: + ---------------------- +---- LIBFOO_VERSION = 1.0 LIBFOO_CONF_OPTS += --without-python-support ---------------------- +---- + Do not align the +=+ signs. * Indentation: use tab only: + ---------------------- +---- define LIBFOO_REMOVE_DOC $(RM) -fr $(TARGET_DIR)/usr/share/libfoo/doc \ $(TARGET_DIR)/usr/share/man/man3/libfoo* endef ---------------------- +---- + Note that commands inside a +define+ block should always start with a tab, so _make_ recognizes them as commands.
@@ -88,21 +88,21 @@ so _make_ recognizes them as commands. + YES: + ---------------------- +---- ifeq ($(BR2_PACKAGE_PYTHON),y) LIBFOO_CONF_OPTS += --with-python-support LIBFOO_DEPENDENCIES += python else LIBFOO_CONF_OPTS += --without-python-support endif ---------------------- +---- + NO: + ---------------------- +---- LIBFOO_CONF_OPTS += --with$(if $(BR2_PACKAGE_PYTHON),,out)-python-support LIBFOO_DEPENDENCIES += $(if $(BR2_PACKAGE_PYTHON),python,) ---------------------- +---- ** Keep configure options and dependencies close together.
@@ -111,18 +111,18 @@ LIBFOO_DEPENDENCIES += $(if $(BR2_PACKAGE_PYTHON),python,) + YES: + ---------------------- +---- ifneq ($(BR2_LIBFOO_INSTALL_DATA),y) define LIBFOO_REMOVE_DATA $(RM) -fr $(TARGET_DIR)/usr/share/libfoo/data endef LIBFOO_POST_INSTALL_TARGET_HOOKS += LIBFOO_REMOVE_DATA endif ---------------------- +---- + NO: + ---------------------- +---- define LIBFOO_REMOVE_DATA $(RM) -fr $(TARGET_DIR)/usr/share/libfoo/data endef
@@ -130,7 +130,7 @@ endef ifneq ($(BR2_LIBFOO_INSTALL_DATA),y) LIBFOO_POST_INSTALL_TARGET_HOOKS += LIBFOO_REMOVE_DATA endif ---------------------- +---- === The documentation
Signature · 1 line
2.1.1
PATCH 6/6 manual: Various tidy changes
Quoted 10 lines · Maxime Hadjinlian
Changes performed all over the manual:
- In AsciiDoc, you only need 4 dashes to make a code block.
- Remove trailing spaces.
- Adding '// vim: set syntax=asciidoc:' when missing.
- Adding empty lines were needed.
- When an example of an external command is done, harmoize the use of the scheme:
' $ cmd'Signed-off-by Maxime Hadjinlian <[email protected]>
Seriously, are you combining 5 distinct changes into a 400-line patch? This
doesn't stand a chance of getting reviewed...
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 6/6 manual: Various tidy changes
Quoted 11 lines · Arnout Vandecappelle
Quoted 9 lines · Maxime Hadjinlian
Changes performed all over the manual:
- In AsciiDoc, you only need 4 dashes to make a code block.
- Remove trailing spaces.
- Adding '// vim: set syntax=asciidoc:' when missing.
- Adding empty lines were needed.
- When an example of an external command is done, harmoize the use of the scheme:
' $ cmd'
Quoted 3 lines
Quoted 1 line
Signed-off-by Maxime Hadjinlian <[email protected]>Seriously, are you combining 5 distinct changes into a 400-line patch?
This
Quoted 1 line
doesn't stand a chance of getting reviewed...
Fair enough. Almost all the patch is about the dashes. Did not realize it was so huge. I'll re spin this into a short series.
Quoted 5 lines
Regards,
Arnout
Quoted 7 lines
--
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20141103/4c6db349/attachment.html>
PATCH 1/6 dbus: Remove DBUS_USERS duplicate
In reply to Maxime HadjinlianQuoted 3 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Maxime" == Maxime Hadjinlian <[email protected]> writes:
Signed-off-by Maxime Hadjinlian <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard