Skip to contentSkip to conversation

common.h: Add prototype of arch_preboot_os

PATCH New Nobuhiro Iwamatsu 2 participants 3 messages Nov 4, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 common.h: Add prototype of arch_preboot_os

When we used arch_preboot_os() function because prototype of this is not declared, following warning is output.

-----
warning: function declaration isn't a prototype [-Wstrict-prototypes]
-----

This adds prototype of arch_preboot_os() to include/common.h.

---
 include/common.h | 3 +++
 1 file changed, 3 insertions(+)
include/common.h +3 -0
index d5020c8..8ee9ca5 100644
@@ -318,6 +318,9 @@ void board_show_dram(ulong size);
  */
 int arch_fixup_fdt(void *blob);
 
+/* Set arch specific config before boot */
+void arch_preboot_os(void);
+
 /* common/flash.c */
 void flash_perror (int);
 
Signature · 1 line
2.1.1
#1 lore raw

PATCH 1/1 common.h: Add prototype of arch_preboot_os

Quoted 2 lines · Nobuhiro Iwamatsu

When we used arch_preboot_os() function because prototype of this is not declared, following warning is output.

Or.. you just need to include the correct file:

$ grep -nr arch_preboot_os include/
include/bootm.h:57:void arch_preboot_os(void);
Quoted 27 lines

-----
warning: function declaration isn't a prototype [-Wstrict-prototypes]
-----

This adds prototype of arch_preboot_os() to include/common.h.

---
 include/common.h | 3 +++
 1 file changed, 3 insertions(+)
include/common.h +3 -0
index d5020c8..8ee9ca5 100644
@@ -318,6 +318,9 @@ void board_show_dram(ulong size);
  */
 int arch_fixup_fdt(void *blob);
 
+/* Set arch specific config before boot */
+void arch_preboot_os(void);
+
 /* common/flash.c */
 void flash_perror (int);
 
Signature · 2 lines
Regards,
Igor.
#2 lore raw

PATCH 1/1 common.h: Add prototype of arch_preboot_os

Hi!

2014-11-04 16:50 GMT+09:00 Igor Grinberg <[email protected]>:

Quoted 8 lines · Nobuhiro Iwamatsu
Quoted 2 lines

When we used arch_preboot_os() function because prototype of this is not declared, following warning is output.

Or.. you just need to include the correct file:

$ grep -nr arch_preboot_os include/
include/bootm.h:57:void arch_preboot_os(void);

Oh, I see.
Thanks for your check.

Best regards,
Nobuhiro

Signature · 1 line
Nobuhiro Iwamatsu