Skip to contentSkip to conversation

drivers: net: ethernet: xilinx: xilinx_emaclite: revert the original commit "1db3ddff1602edf2390b7667dcbaa0f71512e3ea"

PATCH Applied Chen Gang 3 participants 3 messages Nov 4, 2014 – Nov 5, 2014

Subsystems (3)
Networking Network drivers Arm/Zynq architecture
lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 drivers: net: ethernet: xilinx: xilinx_emaclite: revert the original commit "1db3ddff1602edf2390b7667dcbaa0f71512e3ea"

Microblaze is a fpga soft core, it can be customized easily, which may cause many various hardware version strings.

So the original fix patch based on hard-coded compatible version strings is not a good idea (although it is correct for current issue). For it, there will be a new solving way soon (which based on the device tree).

The original issue is related with qemu, so can only change the hardware version string in qemu for it, then keep the original driver no touch ( qemu is for virtualization which has much easier life than real world).

Signed-off-by Chen Gang <[email protected]>
---
 drivers/net/ethernet/xilinx/xilinx_emaclite.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/ethernet/xilinx/xilinx_emaclite.c +0 -1
index 298fad3..28dbbdc 100644
@@ -1236,7 +1236,6 @@ static struct of_device_id xemaclite_of_match[] = {
 	{ .compatible = "xlnx,opb-ethernetlite-1.01.b", },
 	{ .compatible = "xlnx,xps-ethernetlite-1.00.a", },
 	{ .compatible = "xlnx,xps-ethernetlite-2.00.a", },
-	{ .compatible = "xlnx,xps-ethernetlite-2.00.b", },
 	{ .compatible = "xlnx,xps-ethernetlite-2.01.a", },
 	{ .compatible = "xlnx,xps-ethernetlite-3.00.a", },
 	{ /* end of list */ },

-- [email protected]
1.9.3

Acked-by on v1 1/1
#1 lore raw
Quoted 12 lines · Chen Gang

Microblaze is a fpga soft core, it can be customized easily, which may cause many various hardware version strings.

So the original fix patch based on hard-coded compatible version strings is not a good idea (although it is correct for current issue). For it, there will be a new solving way soon (which based on the device tree).

The original issue is related with qemu, so can only change the hardware version string in qemu for it, then keep the original driver no touch ( qemu is for virtualization which has much easier life than real world).

Quoted 4 lines
Signed-off-by Chen Gang <[email protected]>
---
 drivers/net/ethernet/xilinx/xilinx_emaclite.c | 1 -
 1 file changed, 1 deletion(-)
Acked-by Michal Simek <[email protected]>

Thanks,
Michal

maintainer Applied
#2 lore raw

From: Michal Simek <[email protected]>
Date: Wed, 5 Nov 2014 08:19:41 +0100

Quoted 13 lines · Chen Gang
Quoted 12 lines

Microblaze is a fpga soft core, it can be customized easily, which may cause many various hardware version strings.

So the original fix patch based on hard-coded compatible version strings is not a good idea (although it is correct for current issue). For it, there will be a new solving way soon (which based on the device tree).

The original issue is related with qemu, so can only change the hardware version string in qemu for it, then keep the original driver no touch ( qemu is for virtualization which has much easier life than real world).

Quoted 6 lines
Quoted 4 lines
Signed-off-by Chen Gang <[email protected]>
---
 drivers/net/ethernet/xilinx/xilinx_emaclite.c | 1 -
 1 file changed, 1 deletion(-)
Acked-by Michal Simek <[email protected]>

Applied, thanks.