mountstats: Don't display retrans stats unless there are re-xmits
Subsystems (2)
PATCH 1/1 mountstats: Don't display retrans stats unless there are re-xmits
Clean up display of RPC statistics by omitting retransmit statistics when there have been no retransmissions.
Signed-off-by Chuck Lever <[email protected]>
--- tools/mountstats/mountstats.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
tools/mountstats/mountstats.py +5 -2
@@ -272,8 +272,11 @@ class DeviceData: print('%s:' % op) print('\t%d ops (%d%%)' % \ (count, ((count * 100) / sends)), end=' ') - print('\t%d retrans (%d%%)' % (retrans, ((retrans * 100) / count)), end=' ') - print('\t%d major timeouts' % stats[2]) + if retrans != 0: + print('\t%d retrans (%d%%)' % (retrans, ((retrans * 100) / count)), end=' ') + print('\t%d major timeouts' % stats[2]) + else: + print('') print('\tavg bytes sent per op: %d\tavg bytes received per op: %d' % \ (stats[3] / count, stats[4] / count)) print('\tbacklog wait: %f' % (float(stats[5]) / count), end=' ')
Quoted 4 lines · Chuck Lever
Clean up display of RPC statistics by omitting retransmit statistics when there have been no retransmissions.
Signed-off-by Chuck Lever <[email protected]>
Committed...
steved.
Quoted 23 lines
--- tools/mountstats/mountstats.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)tools/mountstats/mountstats.py +5
-2@@ -272,8 +272,11 @@ class DeviceData: print('%s:' % op) print('\t%d ops (%d%%)' % \ (count, ((count * 100) / sends)), end=' ') - print('\t%d retrans (%d%%)' % (retrans, ((retrans * 100) / count)), end=' ') - print('\t%d major timeouts' % stats[2]) + if retrans != 0: + print('\t%d retrans (%d%%)' % (retrans, ((retrans * 100) / count)), end=' ') + print('\t%d major timeouts' % stats[2]) + else: + print('') print('\tavg bytes sent per op: %d\tavg bytes received per op: %d' % \ (stats[3] / count, stats[4] / count)) print('\tbacklog wait: %f' % (float(stats[5]) / count), end=' ')