CONFIG_LCD_BMP_RLE8 and MCC200 dead code?
Hi all,
I've been trying to do some cleanup in common/lcd.c, and noticed some unused code:
One is the CONFIG_LCD_BMP_REL8 stuff. This code was added 2 years ago in patch 45d7f52511f43b71b623a502fdf31feb905f70a1, and so far it has no users (sandbox.h defines it, but only to fix a compilation error, see commit 0156444cf7e77e92fed7a61d6c6123b349f1d600).
The other case is MCC200 specific #ifdefs. It handles 1bpp BMPs, which I don't think is likely to be used by current and future boards, and the board itself is old, and has no maintainer. Perhaps this board can be removed?
Signature · 2 lines
Regards, Nikita Kiryanov
Dear Nikita,
Quoted 3 lines · In message <[email protected]> you wrote:
I've been trying to do some cleanup in
common/lcd.c, and noticed some unused code:
Thanks!
Quoted 4 lines
The other case is MCC200 specific #ifdefs. It handles 1bpp BMPs, which I don't think is likely to be used by current and future boards, and the board itself is old, and has no maintainer. Perhaps this board can be removed?
I agree. We should remove the MCC200 and PRS200 boards.
Can you submit such a patch, please? TIA...
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de It is your destiny. - Darth Vader
Hi Wolfgang,
Quoted 9 lines · Wolfgang Denk
Dear Nikita,
Quoted 3 lines · In message <[email protected]> you wrote:
I've been trying to do some cleanup in
common/lcd.c, and noticed some unused code:Thanks!
Quoted 8 lines
Quoted 4 lines
The other case is MCC200 specific #ifdefs. It handles 1bpp BMPs, which I don't think is likely to be used by current and future boards, and the board itself is old, and has no maintainer. Perhaps this board can be removed?
I agree. We should remove the MCC200 and PRS200 boards.
Can you submit such a patch, please? TIA...
Sure. I'll prepare one tomorrow..
Quoted 5 lines
Best regards,
Wolfgang Denk
Signature · 2 lines
Regards, Nikita Kiryanov
Hi Nikita,
Quoted 10 lines · Nikita Kiryanov
Hi all,
I've been trying to do some cleanup in
common/lcd.c, and noticed some unused code:One is the
CONFIG_LCD_BMP_REL8stuff. This code was added 2 years ago in patch45d7f52511f43b71b623a502fdf31feb905f70a1, and so far it has no users (sandbox.hdefines it, but only to fix a compilation error, see commit0156444cf7e77e92fed7a61d6c6123b349f1d600).
No this is not dead code, we use it. It will be enabled on a few other boards before long, but the exynos upsteaming was stalled for a while.
Regards,
Simon