ARM: OMAP3+: VCVP mapping fixes to get DVFS working

PATCH New Tero Kristo 4 participants 12 messages Oct 10, 2014 – Nov 7, 2014

Subsystems (4)

Arm (32-bit) Arm sub-architectures OMAP2+ support Voltage and current regulator framework

lore

Share & tools

lore

Tero Kristo

author

2014-10-10 14:06 UTC #0 lore raw

cover ARM: OMAP3+: VCVP mapping fixes to get DVFS working

Hi,

Seems like MPU DVFS does not scale the voltages currently with DT boot, due to missing mapping between regulator -> VCVP. Fixed this by adding support for platform data in the TWL regulator DT case + adding platform data quirk for the same. This same already works in the legacy boot, the platform data is passed fine.

Tested on omap3-beagle by measuring the MPU voltage rail.

OMAP4+ platforms do not currently register DVFS regulator, so this set by itself does not fix OMAP4 (needs the TPS MPU regulator added to DT etc. for OMAP4460.)

-Tero

Tero Kristo

author

2014-10-10 14:06 UTC #1 lore raw

PATCH 1/2 ARM: OMAP3+: TWL: add support for mapping platform data via pdata-quirks

Device tree based boot does not currently support DVFS voltage scaling, as the VC/VP mapping is broken. This patch adds support to provide platform data in the device tree boot case also, basically to pass the function pointers to the vc/vp core for voltage changes.

Signed-off-by Tero Kristo <[email protected]>

Cc Mark Brown <[email protected]>

Cc Liam Girdwood <[email protected]>

---
 arch/arm/mach-omap2/pdata-quirks.c |    8 ++--
 arch/arm/mach-omap2/twl-common.c   |   88 ++++++++++++++++++++++++++++++++----
 arch/arm/mach-omap2/twl-common.h   |    2 +
 3 files changed, 84 insertions(+), 14 deletions(-)

arch/arm/mach-omap2/pdata-quirks.c +4 -4

index 90c88d4..03e4a86 100644
@@ -311,10 +311,10 @@ void omap_auxdata_legacy_init(struct device *dev)
 	if (dev->platform_data)
 		return;
 
-	if (strcmp("twl4030-gpio", dev_name(dev)))
-		return;
-
-	dev->platform_data = &twl_gpio_auxdata;
+	if (!strcmp("twl4030-gpio", dev_name(dev)))
+		dev->platform_data = &twl_gpio_auxdata;
+	else
+		dev->platform_data = omap_twl_match_regulator(dev);
 }
 
 /*

arch/arm/mach-omap2/twl-common.c +78 ~~-10~~

125 lines not on this page · raw message

arch/arm/mach-omap2/twl-common.h +2 -0

index 24b65d0..b392ade 100644
@@ -55,6 +55,8 @@ void omap4_pmic_init(const char *pmic_type,
 		    struct twl4030_platform_data *pmic_data,
 		    struct i2c_board_info *devices, int nr_devices);
 
+void *omap_twl_match_regulator(struct device *dev);
+
 void omap3_pmic_get_config(struct twl4030_platform_data *pmic_data,
 			   u32 pdata_flags, u32 regulators_flags);

Signature · 1 line

1.7.9.5

Mark Brown

maintainer

2014-11-07 15:22 UTC #2 lore raw

PATCH 1/2 ARM: OMAP3+: TWL: add support for mapping platform data via pdata-quirks

arch/arm/mach-omap2/pdata-quirks.c void omap_auxdata_legacy_init(struct device *dev) · line 317

Quoted 5 lines · Tero Kristo

arch/arm/mach-omap2/pdata-quirks.c +4 -1

-	dev->platform_data = &twl_gpio_auxdata;
+	if (!strcmp("twl4030-gpio", dev_name(dev)))
+		dev->platform_data = &twl_gpio_auxdata;
+	else
+		dev->platform_data = omap_twl_match_regulator(dev);

Looking at this idiom here I'd expect that we'd be adding another string
comparison here?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141107/de6c774f/attachment.sig>

Tero Kristo

author

2014-11-07 17:13 UTC #3 lore raw

PATCH 1/2 ARM: OMAP3+: TWL: add support for mapping platform data via pdata-quirks

Quoted 10 lines · Mark Brown

arch/arm/mach-omap2/pdata-quirks.c void omap_auxdata_legacy_init(struct device *dev) · line 317
Quoted 5 lines · Tero Kristo
arch/arm/mach-omap2/pdata-quirks.c +4 -1
-	dev->platform_data = &twl_gpio_auxdata;
+	if (!strcmp("twl4030-gpio", dev_name(dev)))
+		dev->platform_data = &twl_gpio_auxdata;
+	else
+		dev->platform_data = omap_twl_match_regulator(dev);
Looking at this idiom here I'd expect that we'd be adding another string comparison here?

We are actually doing an of_match_node call within the twl_match_regulator. However, we had a short offline discussion with Tony, and this whole function should be fixed to check node compatibility instead of dev_name. I will be posting a new version that does this once I have time to look at it.

What do you think of patch #2 though? Thats more interesting for the regulator driver purposes and if you NAK that one, the floor goes under this whole approach.

-Tero

Tero Kristo

author

2014-10-10 14:06 UTC #4 lore raw

PATCH 2/2 regulator: twl: use platform data in the DT based boot also

In reply to Tero Kristo

This allows to pass platform information during a DT boot also, currently this is completely ignored. Needed for supporting the platform specific regulator set_voltage / get_voltage ops for the SMPS regulators.

Signed-off-by Tero Kristo <[email protected]>

Cc Liam Girdwood <[email protected]>

Cc Mark Brown <[email protected]>

---
 drivers/regulator/twl-regulator.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/regulator/twl-regulator.c +1 -1

index 0b4f866..2c4fa06 100644
@@ -1103,9 +1103,9 @@ static int twlreg_probe(struct platform_device *pdev)
 	if (match) {
 		template = match->data;
 		id = template->desc.id;
+		drvdata = dev_get_platdata(&pdev->dev);
 		initdata = of_get_regulator_init_data(&pdev->dev,
 						      pdev->dev.of_node);
-		drvdata = NULL;
 	} else {
 		id = pdev->id;
 		initdata = dev_get_platdata(&pdev->dev);

Signature · 1 line

1.7.9.5

Enric Balletbo Serra

2014-10-16 14:21 UTC #5 lore raw

cover ARM: OMAP3+: VCVP mapping fixes to get DVFS working

In reply to Tero Kristo

Hi,

2014-10-10 16:06 GMT+02:00 Tero Kristo <[email protected]>:

Quoted 14 lines

Hi,
Seems like MPU DVFS does not scale the voltages currently with DT boot, due to missing mapping between regulator -> VCVP. Fixed this by adding support for platform data in the TWL regulator DT case + adding platform data quirk for the same. This same already works in the legacy boot, the platform data is passed fine.
Tested on omap3-beagle by measuring the MPU voltage rail.
OMAP4+ platforms do not currently register DVFS regulator, so this set by itself does not fix OMAP4 (needs the TPS MPU regulator added to DT etc. for OMAP4460.)

Quoted 6 lines

-Tero
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Tony proposed in the IRC apply this patch series in order to solve the following error messages with kernel 3.17

[    2.522949] omap2_set_init_voltage: unable to find boot up OPP for
vdd_mpu_iva
[    2.533721] omap2_set_init_voltage: unable to set vdd_mpu_iva
[    2.541564] omap2_set_init_voltage: unable to find boot up OPP for vdd_core
[    2.551208] omap2_set_init_voltage: unable to set vdd_core

I'm using omap3-igep0020, I didn't mesure the MPU voltage rail but should these patches solve these errors ? Did you resolve these errors on your Beagleboard ?

Cheers,
Enric

Tero Kristo

author

2014-10-17 05:55 UTC #6 lore raw

cover ARM: OMAP3+: VCVP mapping fixes to get DVFS working

Quoted 33 lines · Enric Balletbo Serra

Hi,
2014-10-10 16:06 GMT+02:00 Tero Kristo <[email protected]>:
Quoted 14 lines
Hi,
Seems like MPU DVFS does not scale the voltages currently with DT boot, due to missing mapping between regulator -> VCVP. Fixed this by adding support for platform data in the TWL regulator DT case + adding platform data quirk for the same. This same already works in the legacy boot, the platform data is passed fine.
Tested on omap3-beagle by measuring the MPU voltage rail.
OMAP4+ platforms do not currently register DVFS regulator, so this set by itself does not fix OMAP4 (needs the TPS MPU regulator added to DT etc. for OMAP4460.)
Quoted 6 lines
-Tero
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Tony proposed in the IRC apply this patch series in order to solve the following error messages with kernel 3.17
[    2.522949] omap2_set_init_voltage: unable to find boot up OPP for
vdd_mpu_iva
[    2.533721] omap2_set_init_voltage: unable to set vdd_mpu_iva
[    2.541564] omap2_set_init_voltage: unable to find boot up OPP for vdd_core
[    2.551208] omap2_set_init_voltage: unable to set vdd_core

Quoted 3 lines

I'm using omap3-igep0020, I didn't mesure the MPU voltage rail but should these patches solve these errors ? Did you resolve these errors on your Beagleboard ?

These prints are caused by something else: namely the fact that beagleboard rev C4+ boots up at 720MHz. This OPP is not supported by the kernel and quelches out the warning prints.

This should be fixed by modifying the OPP tables under the dtsi files, however the nasty thing is not all beagleboards support 720MHz OPP. You either need to specify a dts file for beagle-revC4 or do some kernel magic to manually disable the 720MHz OPP on non-supported boards.

-Tero

Enric Balletbo Serra

2014-10-17 11:55 UTC #7 lore raw

cover ARM: OMAP3+: VCVP mapping fixes to get DVFS working

2014-10-17 7:55 GMT+02:00 Tero Kristo <[email protected]>:

Quoted 43 lines · Enric Balletbo Serra

Quoted 37 lines
Hi,
2014-10-10 16:06 GMT+02:00 Tero Kristo <[email protected]>:
Quoted 15 lines
Hi,
Seems like MPU DVFS does not scale the voltages currently with DT boot, due to missing mapping between regulator -> VCVP. Fixed this by adding support for platform data in the TWL regulator DT case + adding platform data quirk for the same. This same already works in the legacy boot, the platform data is passed fine.
Tested on omap3-beagle by measuring the MPU voltage rail.
OMAP4+ platforms do not currently register DVFS regulator, so this set by itself does not fix OMAP4 (needs the TPS MPU regulator added to DT etc. for OMAP4460.)
Quoted 6 lines
-Tero
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Tony proposed in the IRC apply this patch series in order to solve the following error messages with kernel 3.17
[    2.522949] omap2_set_init_voltage: unable to find boot up OPP for
vdd_mpu_iva
[    2.533721] omap2_set_init_voltage: unable to set vdd_mpu_iva
[    2.541564] omap2_set_init_voltage: unable to find boot up OPP for
vdd_core
[    2.551208] omap2_set_init_voltage: unable to set vdd_core
Quoted 3 lines
I'm using omap3-igep0020, I didn't mesure the MPU voltage rail but should these patches solve these errors ? Did you resolve these errors on your Beagleboard ?

Quoted 9 lines

These prints are caused by something else: namely the fact that beagleboard rev C4+ boots up at 720MHz. This OPP is not supported by the kernel and quelches out the warning prints.
This should be fixed by modifying the OPP tables under the dtsi files, however the nasty thing is not all beagleboards support 720MHz OPP. You either need to specify a dts file for beagle-revC4 or do some kernel magic to manually disable the 720MHz OPP on non-supported boards.

Adding and modifying some printk looks the problem is because it can't find the device opp.

[    2.532836] cpu cpu0: dev_pm_opp_find_freq_ceil: can't find device opp
[    2.542755] omap2_set_init_voltage: unable to find boot up OPP for
vdd_mpu_iva (clk = dpll1_ck - freq = 600000000)
[    2.554931] omap2_set_init_voltage: unable to set vdd_mpu_iva

[    2.562957] platform 68000000.ocp: dev_pm_opp_find_freq_ceil: can't
find device opp
[    2.573333] omap2_set_init_voltage: unable to find boot up OPP for
vdd_core (clk = l3_ick - freq = 200000000)
[    2.584442] omap2_set_init_voltage: unable to set vdd_core

The of_init_opp_table who reads the 'operating-points" from dtb is called after. Should be called before?

[    2.592834] cpu cpu0: of_init_opp_table: init_opp_table

Quoted 1 line

-Tero

Tero Kristo

author

2014-10-17 12:35 UTC #8 lore raw

cover ARM: OMAP3+: VCVP mapping fixes to get DVFS working

Quoted 69 lines · Enric Balletbo Serra

2014-10-17 7:55 GMT+02:00 Tero Kristo <[email protected]>:
Quoted 43 lines · Enric Balletbo Serra
Quoted 37 lines
Hi,
2014-10-10 16:06 GMT+02:00 Tero Kristo <[email protected]>:
Quoted 15 lines
Hi,
Seems like MPU DVFS does not scale the voltages currently with DT boot, due to missing mapping between regulator -> VCVP. Fixed this by adding support for platform data in the TWL regulator DT case + adding platform data quirk for the same. This same already works in the legacy boot, the platform data is passed fine.
Tested on omap3-beagle by measuring the MPU voltage rail.
OMAP4+ platforms do not currently register DVFS regulator, so this set by itself does not fix OMAP4 (needs the TPS MPU regulator added to DT etc. for OMAP4460.)
Quoted 6 lines
-Tero
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Tony proposed in the IRC apply this patch series in order to solve the following error messages with kernel 3.17
[    2.522949] omap2_set_init_voltage: unable to find boot up OPP for
vdd_mpu_iva
[    2.533721] omap2_set_init_voltage: unable to set vdd_mpu_iva
[    2.541564] omap2_set_init_voltage: unable to find boot up OPP for
vdd_core
[    2.551208] omap2_set_init_voltage: unable to set vdd_core
Quoted 3 lines
I'm using omap3-igep0020, I didn't mesure the MPU voltage rail but should these patches solve these errors ? Did you resolve these errors on your Beagleboard ?
Quoted 9 lines
These prints are caused by something else: namely the fact that beagleboard rev C4+ boots up at 720MHz. This OPP is not supported by the kernel and quelches out the warning prints.
This should be fixed by modifying the OPP tables under the dtsi files, however the nasty thing is not all beagleboards support 720MHz OPP. You either need to specify a dts file for beagle-revC4 or do some kernel magic to manually disable the 720MHz OPP on non-supported boards.
Adding and modifying some printk looks the problem is because it can't find the device opp.
[    2.532836] cpu cpu0: dev_pm_opp_find_freq_ceil: can't find device opp
[    2.542755] omap2_set_init_voltage: unable to find boot up OPP for
vdd_mpu_iva (clk = dpll1_ck - freq = 600000000)
[    2.554931] omap2_set_init_voltage: unable to set vdd_mpu_iva
[    2.562957] platform 68000000.ocp: dev_pm_opp_find_freq_ceil: can't
find device opp
[    2.573333] omap2_set_init_voltage: unable to find boot up OPP for
vdd_core (clk = l3_ick - freq = 200000000)
[    2.584442] omap2_set_init_voltage: unable to set vdd_core

Quoted 5 lines

The of_init_opp_table who reads the 'operating-points" from dtb is called after. Should be called before?
[    2.592834] cpu cpu0: of_init_opp_table: init_opp_table

What is the board revision you got? Looks like it boots up at 600/200MHz.

You can also try tweaking around the tables under opp3xxx_data.c, not sure if these are initialized in the correct order either. However, the lack of these tables and the warnings mentioned do not prevent cpufreq from working, cpufreq is dependant on the DT tables. That being said, I am not sure if the legacy OPP tables are even needed anymore on DT boot...

-Tero

Enric Balletbo Serra

2014-10-17 12:48 UTC #9 lore raw

cover ARM: OMAP3+: VCVP mapping fixes to get DVFS working

2014-10-17 14:35 GMT+02:00 Tero Kristo <[email protected]>:

Quoted 82 lines · Enric Balletbo Serra

Quoted 81 lines
2014-10-17 7:55 GMT+02:00 Tero Kristo <[email protected]>:
Quoted 57 lines · Enric Balletbo Serra
Quoted 44 lines
Hi,
2014-10-10 16:06 GMT+02:00 Tero Kristo <[email protected]>:
Quoted 19 lines
Hi,
Seems like MPU DVFS does not scale the voltages currently with DT boot, due to missing mapping between regulator -> VCVP. Fixed this by adding support for platform data in the TWL regulator DT case + adding platform
data quirk for the same. This same already works in the legacy boot, the
platform data is passed fine.
Tested on omap3-beagle by measuring the MPU voltage rail.
OMAP4+ platforms do not currently register DVFS regulator, so this set by
itself does not fix OMAP4 (needs the TPS MPU regulator added to DT etc. for OMAP4460.)
Quoted 7 lines
-Tero
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Tony proposed in the IRC apply this patch series in order to solve the following error messages with kernel 3.17
[    2.522949] omap2_set_init_voltage: unable to find boot up OPP for
vdd_mpu_iva
[    2.533721] omap2_set_init_voltage: unable to set vdd_mpu_iva
[    2.541564] omap2_set_init_voltage: unable to find boot up OPP for
vdd_core
[    2.551208] omap2_set_init_voltage: unable to set vdd_core
Quoted 3 lines
I'm using omap3-igep0020, I didn't mesure the MPU voltage rail but should these patches solve these errors ? Did you resolve these errors on your Beagleboard ?
These prints are caused by something else: namely the fact that beagleboard
rev C4+ boots up at 720MHz. This OPP is not supported by the kernel and quelches out the warning prints.
Quoted 6 lines
This should be fixed by modifying the OPP tables under the dtsi files, however the nasty thing is not all beagleboards support 720MHz OPP. You either need to specify a dts file for beagle-revC4 or do some kernel magic
to manually disable the 720MHz OPP on non-supported boards.
Adding and modifying some printk looks the problem is because it can't find the device opp.
[    2.532836] cpu cpu0: dev_pm_opp_find_freq_ceil: can't find device opp
[    2.542755] omap2_set_init_voltage: unable to find boot up OPP for
vdd_mpu_iva (clk = dpll1_ck - freq = 600000000)
[    2.554931] omap2_set_init_voltage: unable to set vdd_mpu_iva
[    2.562957] platform 68000000.ocp: dev_pm_opp_find_freq_ceil: can't
find device opp
[    2.573333] omap2_set_init_voltage: unable to find boot up OPP for
vdd_core (clk = l3_ick - freq = 200000000)
[    2.584442] omap2_set_init_voltage: unable to set vdd_core

Quoted 8 lines

Quoted 5 lines
The of_init_opp_table who reads the 'operating-points" from dtb is called after. Should be called before?
[    2.592834] cpu cpu0: of_init_opp_table: init_opp_table
What is the board revision you got? Looks like it boots up at 600/200MHz.

Well, about board revision I'm using IGEPv2 not Beagleboard. And my board should be able to run up to 1GHz. Is 1GHz supported ?

Quoted 6 lines

You can also try tweaking around the tables under opp3xxx_data.c, not sure if these are initialized in the correct order either. However, the lack of these tables and the warnings mentioned do not prevent cpufreq from working, cpufreq is dependant on the DT tables. That being said, I am not sure if the legacy OPP tables are even needed anymore on DT boot...

Right, I've checked and cpufreq seems to work. Does this means that following call is not needed anymore ?

arch/arm/mach-omap2/opp3xxx_data.c:171:omap_device_initcall(omap3_opp_init);

Thanks,
Enric

Quoted 2 lines

-Tero

Nishanth Menon

2014-10-17 13:54 UTC #10 lore raw

cover ARM: OMAP3+: VCVP mapping fixes to get DVFS working

Quoted 86 lines · Enric Balletbo Serra

2014-10-17 14:35 GMT+02:00 Tero Kristo <[email protected]>:
Quoted 85 lines · Enric Balletbo Serra
Quoted 84 lines
2014-10-17 7:55 GMT+02:00 Tero Kristo <[email protected]>:
Quoted 57 lines · Enric Balletbo Serra
Quoted 44 lines
Hi,
2014-10-10 16:06 GMT+02:00 Tero Kristo <[email protected]>:
Quoted 19 lines
Hi,
Seems like MPU DVFS does not scale the voltages currently with DT boot, due to missing mapping between regulator -> VCVP. Fixed this by adding support for platform data in the TWL regulator DT case + adding platform
data quirk for the same. This same already works in the legacy boot, the
platform data is passed fine.
Tested on omap3-beagle by measuring the MPU voltage rail.
OMAP4+ platforms do not currently register DVFS regulator, so this set by
itself does not fix OMAP4 (needs the TPS MPU regulator added to DT etc. for OMAP4460.)
Quoted 7 lines
-Tero
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Tony proposed in the IRC apply this patch series in order to solve the following error messages with kernel 3.17
[    2.522949] omap2_set_init_voltage: unable to find boot up OPP for
vdd_mpu_iva
[    2.533721] omap2_set_init_voltage: unable to set vdd_mpu_iva
[    2.541564] omap2_set_init_voltage: unable to find boot up OPP for
vdd_core
[    2.551208] omap2_set_init_voltage: unable to set vdd_core
Quoted 3 lines
I'm using omap3-igep0020, I didn't mesure the MPU voltage rail but should these patches solve these errors ? Did you resolve these errors on your Beagleboard ?
These prints are caused by something else: namely the fact that beagleboard
rev C4+ boots up at 720MHz. This OPP is not supported by the kernel and quelches out the warning prints.
Quoted 6 lines
This should be fixed by modifying the OPP tables under the dtsi files, however the nasty thing is not all beagleboards support 720MHz OPP. You either need to specify a dts file for beagle-revC4 or do some kernel magic
to manually disable the 720MHz OPP on non-supported boards.
Adding and modifying some printk looks the problem is because it can't find the device opp.
[    2.532836] cpu cpu0: dev_pm_opp_find_freq_ceil: can't find device opp
[    2.542755] omap2_set_init_voltage: unable to find boot up OPP for
vdd_mpu_iva (clk = dpll1_ck - freq = 600000000)
[    2.554931] omap2_set_init_voltage: unable to set vdd_mpu_iva
[    2.562957] platform 68000000.ocp: dev_pm_opp_find_freq_ceil: can't
find device opp
[    2.573333] omap2_set_init_voltage: unable to find boot up OPP for
vdd_core (clk = l3_ick - freq = 200000000)
[    2.584442] omap2_set_init_voltage: unable to set vdd_core
The of_init_opp_table who reads the 'operating-points" from dtb is called after. Should be called before?

Quoted 8 lines

Quoted 5 lines
Quoted 2 lines
[    2.592834] cpu cpu0: of_init_opp_table: init_opp_table
What is the board revision you got? Looks like it boots up at 600/200MHz.
Well, about board revision I'm using IGEPv2 not Beagleboard. And my board should be able to run up to 1GHz. Is 1GHz supported ?

NO. 1GHz cannot not be supported by the chip until we have avs class1.5 and ABB integrated into a proper cpufreq/dvfs solution.

we have tried multiple times in upstream to present a solution

you are welcome to read up on
https://bugzilla.kernel.org/show_bug.cgi?id=58541 to see why similar frequency was not enabled on omap4 (as an example).

Quoted 8 lines

Quoted 7 lines
You can also try tweaking around the tables under opp3xxx_data.c, not sure if these are initialized in the correct order either. However, the lack of these tables and the warnings mentioned do not prevent cpufreq from working, cpufreq is dependant on the DT tables. That being said, I am not sure if the legacy OPP tables are even needed anymore on DT boot...

Quoted 4 lines

Right, I've checked and cpufreq seems to work. Does this means that following call is not needed anymore ?
arch/arm/mach-omap2/opp3xxx_data.c:171:omap_device_initcall(omap3_opp_init);

only after we have pure DT only boot for OMAP3. we are supposed to support legacy mode for omap3 as well for now.

Signature · 2 lines

Regards,
Nishanth Menon

Tero Kristo

author

2014-10-17 13:56 UTC #11 lore raw

cover ARM: OMAP3+: VCVP mapping fixes to get DVFS working

In reply to Enric Balletbo Serra

Quoted 86 lines · Enric Balletbo Serra

2014-10-17 14:35 GMT+02:00 Tero Kristo <[email protected]>:
Quoted 85 lines · Enric Balletbo Serra
Quoted 84 lines
2014-10-17 7:55 GMT+02:00 Tero Kristo <[email protected]>:
Quoted 57 lines · Enric Balletbo Serra
Quoted 44 lines
Hi,
2014-10-10 16:06 GMT+02:00 Tero Kristo <[email protected]>:
Quoted 19 lines
Hi,
Seems like MPU DVFS does not scale the voltages currently with DT boot, due to missing mapping between regulator -> VCVP. Fixed this by adding support for platform data in the TWL regulator DT case + adding platform
data quirk for the same. This same already works in the legacy boot, the
platform data is passed fine.
Tested on omap3-beagle by measuring the MPU voltage rail.
OMAP4+ platforms do not currently register DVFS regulator, so this set by
itself does not fix OMAP4 (needs the TPS MPU regulator added to DT etc. for OMAP4460.)
Quoted 7 lines
-Tero
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Tony proposed in the IRC apply this patch series in order to solve the following error messages with kernel 3.17
[    2.522949] omap2_set_init_voltage: unable to find boot up OPP for
vdd_mpu_iva
[    2.533721] omap2_set_init_voltage: unable to set vdd_mpu_iva
[    2.541564] omap2_set_init_voltage: unable to find boot up OPP for
vdd_core
[    2.551208] omap2_set_init_voltage: unable to set vdd_core
Quoted 3 lines
I'm using omap3-igep0020, I didn't mesure the MPU voltage rail but should these patches solve these errors ? Did you resolve these errors on your Beagleboard ?
These prints are caused by something else: namely the fact that beagleboard
rev C4+ boots up at 720MHz. This OPP is not supported by the kernel and quelches out the warning prints.
Quoted 6 lines
This should be fixed by modifying the OPP tables under the dtsi files, however the nasty thing is not all beagleboards support 720MHz OPP. You either need to specify a dts file for beagle-revC4 or do some kernel magic
to manually disable the 720MHz OPP on non-supported boards.
Adding and modifying some printk looks the problem is because it can't find the device opp.
[    2.532836] cpu cpu0: dev_pm_opp_find_freq_ceil: can't find device opp
[    2.542755] omap2_set_init_voltage: unable to find boot up OPP for
vdd_mpu_iva (clk = dpll1_ck - freq = 600000000)
[    2.554931] omap2_set_init_voltage: unable to set vdd_mpu_iva
[    2.562957] platform 68000000.ocp: dev_pm_opp_find_freq_ceil: can't
find device opp
[    2.573333] omap2_set_init_voltage: unable to find boot up OPP for
vdd_core (clk = l3_ick - freq = 200000000)
[    2.584442] omap2_set_init_voltage: unable to set vdd_core
The of_init_opp_table who reads the 'operating-points" from dtb is called after. Should be called before?

Quoted 8 lines

Quoted 5 lines
Quoted 2 lines
[    2.592834] cpu cpu0: of_init_opp_table: init_opp_table
What is the board revision you got? Looks like it boots up at 600/200MHz.
Well, about board revision I'm using IGEPv2 not Beagleboard. And my board should be able to run up to 1GHz. Is 1GHz supported ?

Oh I see. Kernel doesn't support anything above 600MHz yet for OMAP3, as none of the OPPs have kernel data.

Quoted 8 lines

Quoted 7 lines
You can also try tweaking around the tables under opp3xxx_data.c, not sure if these are initialized in the correct order either. However, the lack of these tables and the warnings mentioned do not prevent cpufreq from working, cpufreq is dependant on the DT tables. That being said, I am not sure if the legacy OPP tables are even needed anymore on DT boot...

Quoted 4 lines

Right, I've checked and cpufreq seems to work. Does this means that following call is not needed anymore ?
arch/arm/mach-omap2/opp3xxx_data.c:171:omap_device_initcall(omap3_opp_init);

That is still needed, as some boards do not have DT data for them. That initializes the legacy OPPs in that case.

-Tero