drivers: input: mouse: Use "static inline" instead of "inline" in "lifebook.h"
Subsystems (2)
PATCH 1/1 drivers: input: mouse: Use "static inline" instead of "inline" in "lifebook.h"
For inline function in header file, better to be "static inline", or may cause building break under the latest upstream gcc (although, probably, it should be the gcc's issue).
The related error (with allmodconfig under tile):
MODPOST 4002 modules
ERROR: "lifebook_detect" [drivers/input/mouse/psmouse.ko] undefined!
--- drivers/input/mouse/lifebook.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/input/mouse/lifebook.h +3 -3
@@ -16,14 +16,14 @@ void lifebook_module_init(void);int lifebook_detect (struct psmouse *psmouse,bool set_properties);int lifebook_init (struct psmouse *psmouse);#else -inline void lifebook_module_init (void ) +static inline void lifebook_module_init (void ) { } -inline int lifebook_detect (struct psmouse *psmouse,bool set_properties) +static inline int lifebook_detect (struct psmouse *psmouse,bool set_properties) {return -ENOSYS ; } -inline int lifebook_init (struct psmouse *psmouse) +static inline int lifebook_init (struct psmouse *psmouse) {return -ENOSYS ; }
Signature · 1 line
1.9.3
After this patch, our tile can pass allmodconfig building. :-)
Thanks.
Quoted 37 lines · Chen Gang
For inline function in header file, better to be "static inline", or may cause building break under the latest upstream gcc (although, probably, it should be the gcc's issue).
The related error (with allmodconfig under tile):
MODPOST 4002 modules
ERROR: "lifebook_detect" [drivers/input/mouse/psmouse.ko] undefined!Signed-off-by Chen Gang <[email protected]>--- drivers/input/mouse/lifebook.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/input/mouse/lifebook.h +3
-3@@ -16,14 +16,14 @@ void lifebook_module_init(void);int lifebook_detect (struct psmouse *psmouse,bool set_properties);int lifebook_init (struct psmouse *psmouse);#else -inline void lifebook_module_init (void ) +static inline void lifebook_module_init (void ) { } -inline int lifebook_detect (struct psmouse *psmouse,bool set_properties) +static inline int lifebook_detect (struct psmouse *psmouse,bool set_properties) {return -ENOSYS ; } -inline int lifebook_init (struct psmouse *psmouse) +static inline int lifebook_init (struct psmouse *psmouse) {return -ENOSYS ; }
Signature · 3 lines
Chen Gang Open share and attitude like air water and life which God blessed