Skip to contentSkip to conversation

ot1200: fix card detect for usdhc4

PATCH New Christian Gmeiner 2 participants 4 messages Nov 11, 2014 – Nov 17, 2014

lore
Share & tools
lore

Christian Gmeiner

author
#0 lore raw

PATCH 1/1 ot1200: fix card detect for usdhc4

Today I got the final board and found out that a different connector is used as the one on my development board. The new connector has swaped pins for cd and wp.

This change is tested on a production ready baord.

Signed-off-by Christian Gmeiner <[email protected]>
---
 board/bachmann/ot1200/ot1200.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
board/bachmann/ot1200/ot1200.c +2 -2
index 2ed8cf7..007c1ef 100644
@@ -159,8 +159,8 @@ int board_mmc_getcd(struct mmc *mmc)
 		gpio_direction_input(IMX_GPIO_NR(4, 5));
 		ret = gpio_get_value(IMX_GPIO_NR(4, 5));
 	} else {
-		gpio_direction_input(IMX_GPIO_NR(1, 4));
-		ret = !gpio_get_value(IMX_GPIO_NR(1, 4));
+		gpio_direction_input(IMX_GPIO_NR(1, 5));
+		ret = !gpio_get_value(IMX_GPIO_NR(1, 5));
 	}
 
 	return ret;
Signature · 1 line
1.9.3
#1 lore raw

PATCH 1/1 ot1200: fix card detect for usdhc4

Hi Christian,

Quoted 3 lines · Christian Gmeiner

Today I got the final board and found out that a different connector is used as the one on my development board. The new connector has swaped pins for cd and wp.

It is always so..final board is different from development board ;-)

Quoted 2 lines

This change is tested on a production ready baord.

baord --> board

Maybe your disappointment in the commit message can be removed, and let that the production board has swaped pins.

Quoted 12 lines
Signed-off-by Christian Gmeiner <[email protected]>
---
 board/bachmann/ot1200/ot1200.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
board/bachmann/ot1200/ot1200.c +0 -0
index 2ed8cf7..007c1ef 100644

board/bachmann/ot1200/ot1200.c int board_mmc_getcd(struct mmc *mmc) · line 166

Quoted 10 lines
board/bachmann/ot1200/ot1200.c +2 -2
@@ -159,8 +159,8 @@ int board_mmc_getcd(struct mmc *mmc)
 		gpio_direction_input(IMX_GPIO_NR(4, 5));
 		ret = gpio_get_value(IMX_GPIO_NR(4, 5));
 	} else {
-		gpio_direction_input(IMX_GPIO_NR(1, 4));
-		ret = !gpio_get_value(IMX_GPIO_NR(1, 4));
+		gpio_direction_input(IMX_GPIO_NR(1, 5));
+		ret = !gpio_get_value(IMX_GPIO_NR(1, 5));
 	}
 
 	return ret;

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#2 lore raw

PATCH 1/1 ot1200: fix card detect for usdhc4

In reply to Christian Gmeiner
Quoted 6 lines · Christian Gmeiner

Today I got the final board and found out that a different connector is used as the one on my development board. The new connector has swaped pins for cd and wp.

This change is tested on a production ready baord.

I fixed it myself.

Quoted 11 lines
Signed-off-by Christian Gmeiner <[email protected]>
---
 board/bachmann/ot1200/ot1200.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
board/bachmann/ot1200/ot1200.c +0 -0
index 2ed8cf7..007c1ef 100644

board/bachmann/ot1200/ot1200.c int board_mmc_getcd(struct mmc *mmc) · line 166

Quoted 10 lines
board/bachmann/ot1200/ot1200.c +2 -2
@@ -159,8 +159,8 @@ int board_mmc_getcd(struct mmc *mmc)
 		gpio_direction_input(IMX_GPIO_NR(4, 5));
 		ret = gpio_get_value(IMX_GPIO_NR(4, 5));
 	} else {
-		gpio_direction_input(IMX_GPIO_NR(1, 4));
-		ret = !gpio_get_value(IMX_GPIO_NR(1, 4));
+		gpio_direction_input(IMX_GPIO_NR(1, 5));
+		ret = !gpio_get_value(IMX_GPIO_NR(1, 5));
 	}
 
 	return ret;

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
author
#3 lore raw

PATCH 1/1 ot1200: fix card detect for usdhc4

Hi Stefano

2014-11-13 16:34 GMT+01:00 Stefano Babic <[email protected]>:

Quoted 10 lines · Christian Gmeiner
Quoted 6 lines

Today I got the final board and found out that a different connector is used as the one on my development board. The new connector has swaped pins for cd and wp.

This change is tested on a production ready baord.

I fixed it myself.

Thanks a lot!

Quoted 19 lines
Quoted 19 lines
Signed-off-by Christian Gmeiner <[email protected]>
---
 board/bachmann/ot1200/ot1200.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
board/bachmann/ot1200/ot1200.c +2 -2
index 2ed8cf7..007c1ef 100644
@@ -159,8 +159,8 @@ int board_mmc_getcd(struct mmc *mmc)
              gpio_direction_input(IMX_GPIO_NR(4, 5));
              ret = gpio_get_value(IMX_GPIO_NR(4, 5));
      } else {
-             gpio_direction_input(IMX_GPIO_NR(1, 4));
-             ret = !gpio_get_value(IMX_GPIO_NR(1, 4));
+             gpio_direction_input(IMX_GPIO_NR(1, 5));
+             ret = !gpio_get_value(IMX_GPIO_NR(1, 5));
      }
Quoted 5 lines

board/bachmann/ot1200/ot1200.c int board_mmc_getcd(struct mmc *mmc) · line 166

Quoted 2 lines
board/bachmann/ot1200/ot1200.c +0 -0
      return ret;

Applied to u-boot-imx, thanks !

greets
--
Christian Gmeiner, MSc

https://soundcloud.com/christian-gmeiner