t5705: Use the correct file:// URL
PATCH 1/1 t5705: Use the correct file:// URL
A URL like file;//. is (no longer) supported by Git:
Typically there is no host, and RFC1738 says that file:///<path> should be used.
Update t5705 to use a working URL.
--- t/t5705-clone-2gb.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
t/t5705-clone-2gb.sh +1 -1
@@ -46,7 +46,7 @@ test_expect_success CLONE_2GB 'clone - bare' ' test_expect_success CLONE_2GB 'clone - with worktree, file:// protocol' ' - git clone file://. clone-wt + git clone "file://$(pwd)" clone-wt '
Signature · 1 line
1.9.1.dirty
Quoted 5 lines · Torsten Bögershausen
A URL like file;//. is (no longer) supported by Git:
Typically there is no host, and RFC1738 says that file:///<path> should be used.Update t5705 to use a working URL.
Interesting. This looks like it was unintentionally lost in c59ab2e (connect.c: refactor url parsing, 2013-11-28). Given RFC1738, and that this is the first notice of it (and that it is not even a real use case, but something questionable in the test script), it's probably OK to declare the syntax dead and not treat it like a regression.
-Peff
Quoted 6 lines · Jeff King
Quoted 4 lines · Torsten Bögershausen
A URL like file;//. is (no longer) supported by Git:
Typically there is no host, and RFC1738 says that file:///<path> should be used.
Quoted 7 lines
Quoted 1 line
Update t5705 to use a working URL.
Interesting. This looks like it was unintentionally lost in c59ab2e (
connect.c: refactor url parsing, 2013-11-28). Given RFC1738, and that this is the first notice of it (and that it is not even a real use case, but something questionable in the test script), it's probably OK to declare the syntax dead and not treat it like a regression.
Yeah, I tend to agree. I do not think there is any <scheme>:// that lets you say things relative to something that is not "root" of the namespace, and it was a bug the old test depended on that we did not notice it as an error when "file://." tried to refer to "the current directory".