arm: mx6: Fix missing Kconfig option for Novena
PATCH 1/1 arm: mx6: Fix missing Kconfig option for Novena
Add two missing Kconfig options for Novena and drop the SPL from the Novena config.
--- arch/arm/Kconfig | 2 ++ configs/novena_defconfig | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-)
arch/arm/Kconfig +2 -0
@@ -629,6 +629,8 @@ config TARGET_HUMMINGBOARD config TARGET_KOSAGI_NOVENA bool "Support Kosagi Novena" + select CPU_V7 + select SUPPORT_SPL config TARGET_TQMA6 bool "TQ Systems TQMa6 board"
configs/novena_defconfig +1 -1
@@ -1,4 +1,4 @@ CONFIG_SPL=y -CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/kosagi/novena/setup.cfg,MX6Q,SPL" +CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/kosagi/novena/setup.cfg,MX6Q" +S:CONFIG_ARM=y +S:CONFIG_TARGET_KOSAGI_NOVENA=y
Signature · 1 line
2.0.0
PATCH 1/1 arm: mx6: Fix missing Kconfig option for Novena
Hi Marek,
(ccing Tom)
I posted a patch a week ago to fix this and some other boards
http://patchwork.ozlabs.org/patch/407286/
but it looks like Tom has not checked this bug fix patch.
My patch is intended to go directly to Tom's repo, whereas I guess yours is going to u-boot-imx repo.
I don't think it is a good idea to fix one problem by two patches in two places.
Unfortunately, both are imperfect.
The board/kosagi/novena/Kconfig fix is missing from yours and "select SUPPORT_SPL" is missing from mine.
So, how shall we sort out this?
Would you send v2 dropping redudant lines from board/kosagi/novena/Kconfig and shall I send v3 omitting Kosagi stuff?
Best Regards
Masahiro Yamada
Quoted 43 lines · On Thu, 13 Nov 2014 11:06:21 +0100 Marek Vasut <[email protected]> wrote:
Add two missing
Kconfigoptions for Novena and drop the SPL from the Novena config.Signed-off-by Marek Vasut <[email protected]>Cc Stefano Babic <[email protected]>Cc Sean Cross <[email protected]>Cc Marek Vasut <[email protected]>Cc Fabio Estevam <[email protected]>--- arch/arm/Kconfig | 2 ++ configs/novena_defconfig | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-)arch/arm/Kconfig +2
-0@@ -629,6 +629,8 @@ config TARGET_HUMMINGBOARD config TARGET_KOSAGI_NOVENA bool "Support Kosagi Novena" + select CPU_V7 + select SUPPORT_SPL config TARGET_TQMA6 bool "TQ Systems TQMa6 board"configs/novena_defconfig +1
-1@@ -1,4 +1,4 @@ CONFIG_SPL=y -CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/kosagi/novena/setup.cfg,MX6Q,SPL" +CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/kosagi/novena/setup.cfg,MX6Q" +S:CONFIG_ARM=y +S:CONFIG_TARGET_KOSAGI_NOVENA=ySignature · 6 lines
2.0.0 _______________________________________________ U-Boot mailing list U-Boot at lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
PATCH 1/1 arm: mx6: Fix missing Kconfig option for Novena
Quoted 2 lines · Masahiro Yamada
Hi Marek,
(ccing Tom)
Hi!
Quoted 12 lines
I posted a patch a week ago to fix this and some other boards
http://patchwork.ozlabs.org/patch/407286/
but it looks like Tom has not checked this bug fix patch.My patch is intended to go directly to Tom's repo, whereas I guess yours is going to u-boot-imx repo.
I don't think it is a good idea to fix one problem by two patches in two places.
Unfortunately, both are imperfect.
Quoted 8 lines
The board/kosagi/novena/Kconfig fix is missing from yours and "select
SUPPORT_SPL" is missing from mine.So, how shall we sort out this?
Would you send v2 dropping redudant lines from board/kosagi/novena/Kconfig and shall I send v3 omitting Kosagi stuff?
Given you're the Kconfig guru, I would gladly leave it up to you if that is not too much inconvenience, and test your result.
Best regards,
Marek Vasut
PATCH 1/1 arm: mx6: Fix missing Kconfig option for Novena
Hi Masahiro,
Quoted 3 lines · Marek Vasut
Given you're the
Kconfigguru, I would gladly leave it up to you if that is not too much inconvenience, and test your result.
That's fine with me. It means only that novena will remain broken for a while on u-boot-imx until your patch will go into Tom's tree.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH 1/1 arm: mx6: Fix missing Kconfig option for Novena
In reply to Marek VasutQuoted 18 lines · Marek Vasut
Add two missing
Kconfigoptions for Novena and drop the SPL from the Novena config.Signed-off-by Marek Vasut <[email protected]>Cc Stefano Babic <[email protected]>Cc Sean Cross <[email protected]>Cc Marek Vasut <[email protected]>Cc Fabio Estevam <[email protected]>--- arch/arm/Kconfig | 2 ++ configs/novena_defconfig | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-)arch/arm/Kconfig +0
-0
arch/arm/Kconfig config TARGET_HUMMINGBOARD · line 633
Quoted 5 lines
arch/arm/Kconfig +2
-0@@ -629,6 +629,8 @@ config TARGET_HUMMINGBOARD config TARGET_KOSAGI_NOVENA bool "Support Kosagi Novena" + select CPU_V7 + select SUPPORT_SPL
After editing things to apply on top of Masahiro's series, applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141113/f773e212/attachment.pgp>
PATCH 1/1 arm: mx6: Fix missing Kconfig option for Novena
Quoted 23 lines · Tom Rini
Quoted 22 lines · Marek Vasut
Add two missing
Kconfigoptions for Novena and drop the SPL from the Novena config.Signed-off-by Marek Vasut <[email protected]>Cc Stefano Babic <[email protected]>Cc Sean Cross <[email protected]>Cc Marek Vasut <[email protected]>Cc Fabio Estevam <[email protected]>---
arch/arm/Kconfig | 2 ++ configs/novena_defconfig | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-)arch/arm/Kconfig +0
-0@@ -629,6 +629,8 @@ config TARGET_HUMMINGBOARD config TARGET_KOSAGI_NOVENA
Quoted 7 lines
arch/arm/Kconfig config TARGET_HUMMINGBOARD · line 633
Quoted 4 lines
arch/arm/Kconfig +2
-0bool "Support Kosagi Novena" + select CPU_V7 + select SUPPORT_SPLAfter editing things to apply on top of Masahiro's series, applied to u-boot/master, thanks!
I hope I was a good ball and chain on your leg. My service is always available to you (lol) ;-)
Thanks!
Best regards,
Marek Vasut