Skip to contentSkip to conversation

qt: Script Module needs a toolchain with nptl

PATCH Superseded Vicente Olivert Riera 2 participants 3 messages Nov 14, 2014

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Vicente Olivert Riera

author
#0 lore raw

PATCH v2 1/2 qt: Script Module needs a toolchain with nptl

Qt Script Module uses pthread_getattr_np() which is implemented in toolchains with nptl. Otherwise the compilation will fail showing this error message:

../3rdparty/javascriptcore/JavaScriptCore/runtime/Collector.cpp: In function ?void* QTJSC::currentThreadStackBase()?:
../3rdparty/javascriptcore/JavaScriptCore/runtime/Collector.cpp:692:42:
error: ?pthread_getattr_np? was not declared in this scope

Signed-off-by Vicente Olivert Riera <[email protected]>

---
Changes v1 -> v2

Depend on BR2_TOOLCHAIN_HAS_THREADS_NPTL instead of BR2_PTHREADS_OLD

 package/qt/Config.in |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
package/qt/Config.in +5 -0
index da159b4..f4cb6b6 100644
@@ -402,11 +402,16 @@ config BR2_PACKAGE_QT_OPENSSL
 config BR2_PACKAGE_QT_SCRIPT
 	bool "Script Module"
 	depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # needs pthread_getattr_np()
 	default y
 	help
 	  Build the Qt Script module.
 	  if unsure, say y.
 
+comment "Script Module needs a toolchain with nptl"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
+	depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
+
 config BR2_PACKAGE_QT_SCRIPTTOOLS
 	bool "Script Tools Module"
 	depends on BR2_PACKAGE_QT_SCRIPT
Signature · 1 line
1.7.1
author
#1 lore raw

PATCH v2 2/2 qt: Webkit Module needs a toolchain with nptl

Qt Webkit Module uses pthread_getattr_np() which is implemented in toolchains with nptl. Otherwise the compilation will fail showing this error message:

wtf/StackBounds.cpp: In member function ?void WTF::StackBounds::initialize()?:
wtf/StackBounds.cpp:172:38: error: ?pthread_getattr_np? was not declared in this scope

Signed-off-by Vicente Olivert Riera <[email protected]>

---
Changes v1 -> v2

Depend on BR2_TOOLCHAIN_HAS_THREADS_NPTL instead of BR2_PTHREADS_OLD

 package/qt/Config.in |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
package/qt/Config.in +3 -1
index f4cb6b6..6c421fd 100644
@@ -375,12 +375,14 @@ config BR2_PACKAGE_QT_WEBKIT
 	depends on BR2_PACKAGE_QT_GUI_MODULE
 	depends on BR2_PACKAGE_QT_NETWORK
 	depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # needs pthread_getattr_np()
 	help
 	  Build the WebKit module.
 	  If unsure, say n.
 
-comment "WebKit needs shared library/gui/network support"
+comment "WebKit needs shared library/nptl toolchain/gui/network support"
 	depends on !(BR2_PACKAGE_QT_SHARED && BR2_PACKAGE_QT_GUI_MODULE && BR2_PACKAGE_QT_NETWORK)
+	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
 
 config BR2_PACKAGE_QT_STL
Signature · 1 line
1.7.1
#2 lore raw

PATCH v2 1/2 qt: Script Module needs a toolchain with nptl

In reply to Vicente Olivert Riera
Quoted 23 lines · Vicente Olivert Riera

Qt Script Module uses pthread_getattr_np() which is implemented in toolchains with nptl. Otherwise the compilation will fail showing this error message:

../3rdparty/javascriptcore/JavaScriptCore/runtime/Collector.cpp: In function ?void* QTJSC::currentThreadStackBase()?:
../3rdparty/javascriptcore/JavaScriptCore/runtime/Collector.cpp:692:42:
error: ?pthread_getattr_np? was not declared in this scope

Signed-off-by Vicente Olivert Riera <[email protected]>

---
Changes v1 -> v2

Depend on BR2_TOOLCHAIN_HAS_THREADS_NPTL instead of BR2_PTHREADS_OLD

 package/qt/Config.in |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
package/qt/Config.in +0 -0
index da159b4..f4cb6b6 100644

package/qt/Config.in config BR2_PACKAGE_QT_OPENSSL · line 411

Quoted 10 lines
package/qt/Config.in +2 -0
@@ -402,11 +402,16 @@ config BR2_PACKAGE_QT_OPENSSL
 config BR2_PACKAGE_QT_SCRIPT
 	bool "Script Module"
 	depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # needs pthread_getattr_np()
 	default y
 	help
 	  Build the Qt Script module.
 	  if unsure, say y.
 
+comment "Script Module needs a toolchain with nptl"

NPTL should be in capitals.

Regards,
Arnout

Quoted 7 lines
package/qt/Config.in +3 -0
+	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
+	depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
+
 config BR2_PACKAGE_QT_SCRIPTTOOLS
 	bool "Script Tools Module"
 	depends on BR2_PACKAGE_QT_SCRIPT
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F