Skip to contentSkip to conversation

genirq: Add IRQ 0 to domain debug file

PATCH In review Dmitry Eremin-Solenikov 2 participants 3 messages Nov 15, 2014

Subsystems (2)
IRQ IRQ domains (IRQ number mapping library)
lore
Share & tools
lore

Dmitry Eremin-Solenikov

author
#0 lore raw

PATCH 1/1 genirq: Add IRQ 0 to domain debug file

Currently irq_domain_mapping debugfs file dumps IRQ information starting from IRQ 1. IRQ 0 is missing from that file. Add it to have the complete picture of IRQ/domains mappings.

Signed-off-by Dmitry Eremin-Solenikov <[email protected]>
---
 kernel/irq/irqdomain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/irq/irqdomain.c +1 -1
index 6534ff6..0e0c7a8 100644
@@ -585,7 +585,7 @@ static int virq_debug_show(struct seq_file *m, void *private)
 		      "chip name", (int)(2 * sizeof(void *) + 2), "chip data",
 		      "active", "type", "domain");
 
-	for (i = 1; i < nr_irqs; i++) {
+	for (i = 0; i < nr_irqs; i++) {
 		desc = irq_to_desc(i);
 		if (!desc)
 			continue;
Signature · 1 line
2.1.1
#1 lore raw
Quoted 3 lines · Dmitry Eremin-Solenikov

Currently irq_domain_mapping debugfs file dumps IRQ information starting from IRQ 1. IRQ 0 is missing from that file. Add it to have the complete picture of IRQ/domains mappings.

Hi Dmitry,
For most irqdomain interfaces, they treat irq0 as invalid
interrupt. But on x86, it's possible to use irq0 for timer. It causes may confusion when enabling irqdomain for x86.
Regards!
Gerry

Quoted 20 lines
Signed-off-by Dmitry Eremin-Solenikov <[email protected]>
---
 kernel/irq/irqdomain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/irq/irqdomain.c +1 -1
index 6534ff6..0e0c7a8 100644
@@ -585,7 +585,7 @@ static int virq_debug_show(struct seq_file *m, void *private)
 		      "chip name", (int)(2 * sizeof(void *) + 2), "chip data",
 		      "active", "type", "domain");
 
-	for (i = 1; i < nr_irqs; i++) {
+	for (i = 0; i < nr_irqs; i++) {
 		desc = irq_to_desc(i);
 		if (!desc)
 			continue;
author
#2 lore raw

Hello,

2014-11-15 16:01 GMT+03:00 Jiang Liu <[email protected]>:

Quoted 8 lines · Dmitry Eremin-Solenikov
Quoted 3 lines

Currently irq_domain_mapping debugfs file dumps IRQ information starting from IRQ 1. IRQ 0 is missing from that file. Add it to have the complete picture of IRQ/domains mappings.

Hi Dmitry,
For most irqdomain interfaces, they treat irq0 as invalid
interrupt. But on x86, it's possible to use irq0 for timer. It causes may confusion when enabling irqdomain for x86.

I encountered with this issue when enabling IRQ domains support for one of ARM sub-architectures.

Signature · 2 lines
With best wishes
Dmitry