Skip to contentSkip to conversation

ARM: dts: sunxi: Add de_be0 clk parent pll to simplefb node

PATCH Superseded Hans de Goede 2 participants 2 messages Nov 16, 2014

Subsystems (2)
Device tree bindings Arm/Allwinner sunXi SoC support

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Hans de Goede

author
#0 lore raw

PATCH 1/1 ARM: dts: sunxi: Add de_be0 clk parent pll to simplefb node

Avoid the parent pll for the mod-clk for de_be0 getting disabled when non of the other users are enabled (which can happens on boards when non of i2c, spi and mmc are in use).

Note for now we point directly to the parent rather then to the de_be0 mod-clk as that is not modelled in our devicetree yet.

Signed-off-by Hans de Goede <[email protected]>
---
 arch/arm/boot/dts/sun4i-a10.dtsi  | 3 ++-
 arch/arm/boot/dts/sun5i-a10s.dtsi | 3 ++-
 arch/arm/boot/dts/sun6i-a31.dtsi  | 1 +
 arch/arm/boot/dts/sun7i-a20.dtsi  | 3 ++-
 4 files changed, 7 insertions(+), 3 deletions(-)
arch/arm/boot/dts/sun4i-a10.dtsi +2 -1
index cdb4708..92d8aa6 100644
@@ -34,7 +34,8 @@
 
 		framebuffer0-hdmi {
 			compatible = "simple-framebuffer";
-			clocks = <&ahb_gates 36>, <&ahb_gates 43>, <&ahb_gates 44>;
+			clocks = <&pll5 1>, <&ahb_gates 36>, <&ahb_gates 43>,
+				 <&ahb_gates 44>;
 			status = "disabled";
 		};
 	};
arch/arm/boot/dts/sun5i-a10s.dtsi +2 -1
index aee7f25..c678e56 100644
@@ -31,7 +31,8 @@
 
 		framebuffer0-hdmi {
 			compatible = "simple-framebuffer";
-			clocks = <&ahb_gates 36>, <&ahb_gates 43>, <&ahb_gates 44>;
+			clocks = <&pll5 1>, <&ahb_gates 36>, <&ahb_gates 43>,
+				 <&ahb_gates 44>;
 			status = "disabled";
 		};
 	};
arch/arm/boot/dts/sun6i-a31.dtsi +1 -0
index 04a5cb3..ccc03f3 100644
@@ -69,6 +69,7 @@
 
 		framebuffer0-hdmi {
 			compatible = "simple-framebuffer";
+			clocks = <&pll6>;
 			status = "disabled";
 		};
 	};
arch/arm/boot/dts/sun7i-a20.dtsi +2 -1
index 58c1573..89766cb 100644
@@ -71,7 +71,8 @@
 
 		framebuffer0-hdmi {
 			compatible = "simple-framebuffer";
-			clocks = <&ahb_gates 36>, <&ahb_gates 43>, <&ahb_gates 44>;
+			clocks = <&pll5 1>, <&ahb_gates 36>, <&ahb_gates 43>,
+				 <&ahb_gates 44>;
 			status = "disabled";
 		};
 	};
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/1 ARM: dts: sunxi: Add de_be0 clk parent pll to simplefb node

Hi,

Am 16.11.2014 um 11:22 schrieb Hans de Goede:

Quoted 1 line

Avoid the parent pll for the mod-clk for de_be0 getting disabled when non of

"none"

Quoted 1 line

the other users are enabled (which can happens on boards when non of i2c, spi

"can happen", "none"

Quoted 3 lines

and mmc are in use).

Note for now we point directly to the parent rather then to the de_be0 mod-clk

"than"

Quoted 9 lines

as that is not modelled in our devicetree yet.

Signed-off-by Hans de Goede <[email protected]>
---
 arch/arm/boot/dts/sun4i-a10.dtsi  | 3 ++-
 arch/arm/boot/dts/sun5i-a10s.dtsi | 3 ++-
 arch/arm/boot/dts/sun6i-a31.dtsi  | 1 +
 arch/arm/boot/dts/sun7i-a20.dtsi  | 3 ++-
 4 files changed, 7 insertions(+), 3 deletions(-)

Patch itself looks okay. Maybe Maxime can fix up when applying.

Cheers,
Andreas

Signature · 2 lines
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 21284 AG N?rnberg