ARM: dts: DRA7: Add node for RTC
PATCH 1/1 ARM: dts: DRA7: Add node for RTC
Add node for RTC.
--- arch/arm/boot/dts/dra7.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)
arch/arm/boot/dts/dra7.dtsi +9 -0
@@ -1075,6 +1075,15 @@ status = "disabled"; }; + rtc: rtcss at 48838000 { + compatible = "ti,am3352-rtc"; + reg = <0x48838000 0x100>; + interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>; + ti,hwmods = "rtcss"; + clocks = <&sys_32k_ck>; + }; + omap_control_usb2phy1: control-phy at 4a002300 { compatible = "ti,control-phy-usb2"; reg = <0x4a002300 0x4>;
Signature · 1 line
1.9.1
PATCH 1/1 ARM: dts: DRA7: Add node for RTC
Hello.
Quoted 14 lines · Lokesh Vutla
Add node for RTC.
Signed-off-by Lokesh Vutla <[email protected]>[nm at ti.com: update with rtc crossbar number]Signed-off-by Nishanth Menon <[email protected]>--- arch/arm/boot/dts/dra7.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)arch/arm/boot/dts/dra7.dtsi +0
-0
arch/arm/boot/dts/dra7.dtsi line 1078
Quoted 4 lines
arch/arm/boot/dts/dra7.dtsi +1
-0@@ -1075,6 +1075,15 @@ status = "disabled"; }; + rtc: rtcss at 48838000 {
Please just name the node "rtc at 48838000", in accordance with ePAPR.
arch/arm/boot/dts/dra7.dtsi line 1082
Quoted 4 lines
arch/arm/boot/dts/dra7.dtsi +4
-0+ compatible = "ti,am3352-rtc"; + reg = <0x48838000 0x100>; + interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>;
2 similar interrupts?
[...]
WBR, Sergei
PATCH 1/1 ARM: dts: DRA7: Add node for RTC
Hi,
Quoted 21 lines · Sergei Shtylyov
Hello.
Quoted 17 lines · Lokesh Vutla
Add node for RTC.
Signed-off-by Lokesh Vutla <[email protected]>[nm at ti.com: update with rtc crossbar number]Signed-off-by Nishanth Menon <[email protected]>--- arch/arm/boot/dts/dra7.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)arch/arm/boot/dts/dra7.dtsi +0
-0@@ -1075,6 +1075,15 @@ status = "disabled"; };
Quoted 3 lines
arch/arm/boot/dts/dra7.dtsi line 1078
Quoted 1 line
arch/arm/boot/dts/dra7.dtsi +1
-0+ rtc: rtcss at 48838000 {Please just name the node "rtc at 48838000", in accordance with ePAPR.
Okay. will update it.
Quoted 7 lines
arch/arm/boot/dts/dra7.dtsi line 1082
Quoted 5 lines
arch/arm/boot/dts/dra7.dtsi +4
-0+ compatible = "ti,am3352-rtc"; + reg = <0x48838000 0x100>; + interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>;2 similar interrupts?
both rtc timer and rtc alarm uses same interrupt on DRA7 Soc. Driver handles it accordingly.
So passing the same interrupt.
Thanks and regards,
Lokesh
Quoted 5 lines
[...]
WBR, Sergei
PATCH 1/1 ARM: dts: DRA7: Add node for RTC
Quoted 30 lines · Lokesh Vutla
Quoted 19 lines · Lokesh Vutla
Quoted 18 lines
Add node for RTC.
Signed-off-by Lokesh Vutla <[email protected]>[nm at ti.com: update with rtc crossbar number]Signed-off-by Nishanth Menon <[email protected]>--- arch/arm/boot/dts/dra7.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)arch/arm/boot/dts/dra7.dtsi +0
-0@@ -1075,6 +1075,15 @@ status = "disabled"; };Quoted 3 lines
arch/arm/boot/dts/dra7.dtsi line 1078
Quoted 1 line
arch/arm/boot/dts/dra7.dtsi +1
-0+ rtc: rtcss at 48838000 {Please just name the node "rtc at 48838000", in accordance with ePAPR.
Okay. will update it.
Quoted 4 lines
Quoted 4 lines
arch/arm/boot/dts/dra7.dtsi +4
-0+ compatible = "ti,am3352-rtc"; + reg = <0x48838000 0x100>; + interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>;
Quoted 5 lines
Quoted 1 line
2 similar interrupts?
both rtc timer and rtc alarm uses same interrupt on DRA7 Soc. Driver handles it accordingly.
So passing the same interrupt.
I think it would have been better if the driver just handled a single
interrupt.
Quoted 4 lines
Thanks and regards,
LokeshQuoted 1 line
[...]
WBR, Sergei
PATCH 1/1 ARM: dts: DRA7: Add node for RTC
Hi,
Quoted 32 lines · Sergei Shtylyov
Quoted 29 lines · Lokesh Vutla
Quoted 19 lines · Lokesh Vutla
Quoted 18 lines
Add node for RTC.
Signed-off-by Lokesh Vutla <[email protected]>[nm at ti.com: update with rtc crossbar number]Signed-off-by Nishanth Menon <[email protected]>--- arch/arm/boot/dts/dra7.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)arch/arm/boot/dts/dra7.dtsi +0
-0@@ -1075,6 +1075,15 @@ status = "disabled"; };Quoted 3 lines
arch/arm/boot/dts/dra7.dtsi line 1078
Quoted 1 line
arch/arm/boot/dts/dra7.dtsi +1
-0+ rtc: rtcss at 48838000 {Please just name the node "rtc at 48838000", in accordance with ePAPR.
Okay. will update it.
Quoted 4 lines
Quoted 4 lines
arch/arm/boot/dts/dra7.dtsi +4
-0+ compatible = "ti,am3352-rtc"; + reg = <0x48838000 0x100>; + interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>;
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
2 similar interrupts?
both rtc timer and rtc alarm uses same interrupt on DRA7 Soc. Driver handles it accordingly.
So passing the same interrupt.I think it would have been better if the driver just handled a single interrupt.
There are certain SoCs with RTC IP where timer and alarm uses different interrupts. Driver has to take care of that scenario also. So it expects two interrupts from dt.
Thanks and regards,
Lokesh
Quoted 8 lines
Quoted 5 lines
Thanks and regards,
LokeshQuoted 1 line
[...]
WBR, Sergei
PATCH 1/1 ARM: dts: DRA7: Add node for RTC
Hello.
Quoted 30 lines · Lokesh Vutla
Quoted 29 lines
Quoted 29 lines
Quoted 17 lines
Quoted 17 lines
Add node for RTC.
Signed-off-by Lokesh Vutla <[email protected]>[nm at ti.com: update with rtc crossbar number]Signed-off-by Nishanth Menon <[email protected]>--- arch/arm/boot/dts/dra7.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)arch/arm/boot/dts/dra7.dtsi +0
-0@@ -1075,6 +1075,15 @@ status = "disabled"; };Quoted 3 lines
arch/arm/boot/dts/dra7.dtsi line 1078
Quoted 1 line
arch/arm/boot/dts/dra7.dtsi +1
-0+ rtc: rtcss at 48838000 {Please just name the node "rtc at 48838000", in accordance with ePAPR.
Okay. will update it.
Quoted 6 lines
arch/arm/boot/dts/dra7.dtsi line 1082
Quoted 4 lines
arch/arm/boot/dts/dra7.dtsi +4
-0+ compatible = "ti,am3352-rtc"; + reg = <0x48838000 0x100>; + interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>;2 similar interrupts?
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
both rtc timer and rtc alarm uses same interrupt on DRA7 Soc. Driver handles it accordingly.
So passing the same interrupt.I think it would have been better if the driver just handled a single interrupt.
There are certain SoCs with RTC IP where timer and alarm uses different interrupts.
I understood.
Quoted 1 line
Driver has to take care of that scenario also. So it expects two interrupts from dt.
You could also handle the missing second interrupt. I don't insist though...
Quoted 2 lines
Thanks and regards,
Lokesh
WBR, Sergei
PATCH v2 1/1 ARM: dts: DRA7: Add node for RTC
In reply to Lokesh VutlaAdd node for RTC.
---
Changes since v1:
- Fixed rtc dt node label.
arch/arm/boot/dts/dra7.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)
arch/arm/boot/dts/dra7.dtsi +9 -0
@@ -1075,6 +1075,15 @@ status = "disabled"; }; + rtc at 48838000 { + compatible = "ti,am3352-rtc"; + reg = <0x48838000 0x100>; + interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>; + ti,hwmods = "rtcss"; + clocks = <&sys_32k_ck>; + }; + omap_control_usb2phy1: control-phy at 4a002300 { compatible = "ti,control-phy-usb2"; reg = <0x4a002300 0x4>;
Signature · 1 line
1.9.1
PATCH v2 1/1 ARM: dts: DRA7: Add node for RTC
Quoted 5 lines · Lokesh Vutla
Add node for RTC.
Signed-off-by Lokesh Vutla <[email protected]>[nm at ti.com: update with rtc crossbar number]Signed-off-by Nishanth Menon <[email protected]>
Applying into omap-for-v3.19/dt-v2 thanks.
Tony
Quoted 29 lines
---
Changes since v1:
- Fixed rtc dt node label.arch/arm/boot/dts/dra7.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)arch/arm/boot/dts/dra7.dtsi +9
-0@@ -1075,6 +1075,15 @@ status = "disabled"; }; + rtc at 48838000 { + compatible = "ti,am3352-rtc"; + reg = <0x48838000 0x100>; + interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>; + ti,hwmods = "rtcss"; + clocks = <&sys_32k_ck>; + }; + omap_control_usb2phy1: control-phy at 4a002300 { compatible = "ti,control-phy-usb2"; reg = <0x4a002300 0x4>;Signature · 1 line
1.9.1