Skip to contentSkip to conversation

exynos: dts: Correct USB vbus-gpio numbering for Snow

PATCH New Sjoerd Simons 3 participants 3 messages Nov 6, 2014 – Nov 17, 2014

Subsystems (2)
Arm (32-bit) Arm Samsung Exynos
lore
Share & tools
lore

Sjoerd Simons

author
#0 lore raw

PATCH 1/1 exynos: dts: Correct USB vbus-gpio numbering for Snow

The current vbus GPIOs on snow make very little sense, their number is far above the maximum. As a result, USB doesn't work on snow.

Correct the GPIO numbering so they match the current scheme for exynos5. Tested both EHCI and XHCI to correctly work after this change.

Signed-off-by Sjoerd Simons <[email protected]>
---
 arch/arm/dts/exynos5250-snow.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/dts/exynos5250-snow.dts +2 -2
index 6fd9275..95af025 100644
@@ -131,11 +131,11 @@
 	};
 
 	ehci at 12110000 {
-		samsung,vbus-gpio = <&gpio 0x309 0>; /* X11 */
+		samsung,vbus-gpio = <&gpio 0xb1 0>; /* X11 */
 	};
 
 	xhci at 12000000 {
-		samsung,vbus-gpio = <&gpio 0x317 0>; /* X27 */
+		samsung,vbus-gpio = <&gpio 0xbf 0>; /* X27 */
 	};
 
 	tmu at 10060000 {
Signature · 1 line
2.1.1
#1 lore raw

PATCH 1/1 exynos: dts: Correct USB vbus-gpio numbering for Snow

Quoted 7 lines · Sjoerd Simons

The current vbus GPIOs on snow make very little sense, their number is far above the maximum. As a result, USB doesn't work on snow.

Correct the GPIO numbering so they match the current scheme for exynos5. Tested both EHCI and XHCI to correctly work after this change.

Signed-off-by Sjoerd Simons <[email protected]>
Acked-by Simon Glass <[email protected]>
#2 lore raw

PATCH 1/1 exynos: dts: Correct USB vbus-gpio numbering for Snow

In reply to Sjoerd Simons
Quoted 20 lines · Sjoerd Simons

The current vbus GPIOs on snow make very little sense, their number is far above the maximum. As a result, USB doesn't work on snow.

Correct the GPIO numbering so they match the current scheme for exynos5. Tested both EHCI and XHCI to correctly work after this change.

Signed-off-by Sjoerd Simons <[email protected]>
---
 arch/arm/dts/exynos5250-snow.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/dts/exynos5250-snow.dts +0 -0
index 6fd9275..95af025 100644
@@ -131,11 +131,11 @@
 	};
 
 	ehci at 12110000 {

arch/arm/dts/exynos5250-snow.dts line 141

Quoted 10 lines
arch/arm/dts/exynos5250-snow.dts +2 -2
-		samsung,vbus-gpio = <&gpio 0x309 0>; /* X11 */
+		samsung,vbus-gpio = <&gpio 0xb1 0>; /* X11 */
 	};
 
 	xhci at 12000000 {
-		samsung,vbus-gpio = <&gpio 0x317 0>; /* X27 */
+		samsung,vbus-gpio = <&gpio 0xbf 0>; /* X27 */
 	};
 
 	tmu at 10060000 {

applied to u-boot-samsung.

Thanks,
Minkyu Kang.