can: c_can: Use syscon regmap for TI specific RAMINIT register

PATCH In review Marc Kleine-Budde 3 participants 17 messages Nov 14, 2014 – Jan 7, 2015

Subsystems (2)

Device tree bindings CAN network drivers

lore

Share & tools

lore

Marc Kleine-Budde

author maintainer

2014-11-14 18:09 UTC #0 lore raw

v8 cover can: c_can: Use syscon regmap for TI specific RAMINIT register

Picking up Roger's work:

Changes since v7:
- combined raminit start and done bit into a struct (3/8, 7/8, 8/8)
- constified struct c_can_driver_data (2/8, 7/8, 8/8)
- silenced compiler warning in c_can_hw_raminit_{wait,}_syscon (4/8)
- use platform_get_device_id in probe() instead of open coding it (2/8)

Marc

Marc Kleine-Budde

author maintainer

2014-11-14 18:09 UTC #1 lore raw

PATCH v8 1/8 can: c_can: Add timeout to c_can_hw_raminit_ti()

From: Roger Quadros <[email protected]>

TI's RAMINIT DONE mechanism is buggy on AM43xx SoC and may not always be set after the START bit is set. Although it seems to work fine even in that case. So add a timeout mechanism to c_can_hw_raminit_wait_ti(). Don't bail out in that failure case but just print an error message.

Signed-off-by Roger Quadros <[email protected]>

Signed-off-by Marc Kleine-Budde <[email protected]>

---
 drivers/net/can/c_can/c_can_platform.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

drivers/net/can/c_can/c_can_platform.c +10 -1

index fb279d6ae484..106c203fc5eb 100644
@@ -75,10 +75,19 @@ static void c_can_plat_write_reg_aligned_to_32bit(const struct c_can_priv *priv,
 static void c_can_hw_raminit_wait_ti(const struct c_can_priv *priv, u32 mask,
 				  u32 val)
 {
+	int timeout = 0;
+
 	/* We look only at the bits of our instance. */
 	val &= mask;
-	while ((readl(priv->raminit_ctrlreg) & mask) != val)
+	while ((readl(priv->raminit_ctrlreg) & mask) != val) {
 		udelay(1);
+		timeout++;
+
+		if (timeout == 1000) {
+			dev_err(&priv->dev->dev, "%s: time out\n", __func__);
+			break;
+		}
+	}
 }
 
 static void c_can_hw_raminit_ti(const struct c_can_priv *priv, bool enable)

Signature · 1 line

2.1.1

Marc Kleine-Budde

author maintainer

2014-11-14 18:09 UTC #2 lore raw

PATCH v8 2/8 can: c_can: Introduce c_can_driver_data structure

In reply to Marc Kleine-Budde

From: Roger Quadros <[email protected]>

We want to have more data than just can_dev_id to be present in the driver data e.g. TI platforms need RAMINIT register description. Introduce the c_can_driver_data structure and move the can_dev_id into it.

Tidy up the way it is used on probe().

Signed-off-by Roger Quadros <[email protected]>

Signed-off-by Marc Kleine-Budde <[email protected]>

---
 drivers/net/can/c_can/c_can.h          |  4 +++
 drivers/net/can/c_can/c_can_platform.c | 52 +++++++++++++++++++---------------
 2 files changed, 33 insertions(+), 23 deletions(-)

drivers/net/can/c_can/c_can.h +4 -0

index 99ad1aa576b0..26c975d914e3 100644
@@ -169,6 +169,10 @@ enum c_can_dev_id {
 	BOSCH_D_CAN,
 };
 
+struct c_can_driver_data {
+	enum c_can_dev_id id;
+};
+
 /* c_can private data structure */
 struct c_can_priv {
 	struct can_priv can;	/* must be the first member */

drivers/net/can/c_can/c_can_platform.c +29 ~~-23~~

90 lines not on this page · raw message

Signature · 1 line

2.1.1

Marc Kleine-Budde

author maintainer

2014-11-14 18:09 UTC #3 lore raw

PATCH v8 3/8 can: c_can: Add RAMINIT register information to driver data

In reply to Marc Kleine-Budde

From: Roger Quadros <[email protected]>

Some platforms (e.g. TI) need special RAMINIT register handling. Provide a way to store RAMINIT register description in driver data.

Signed-off-by Roger Quadros <[email protected]>

Signed-off-by Marc Kleine-Budde <[email protected]>

---
 drivers/net/can/c_can/c_can.h | 10 ++++++++++
 1 file changed, 10 insertions(+)

drivers/net/can/c_can/c_can.h +10 -0

index 26c975d914e3..3f111f4f0f6e 100644
@@ -169,8 +169,18 @@ enum c_can_dev_id {
 	BOSCH_D_CAN,
 };
 
+struct raminit_bits {
+	u8 start;
+	u8 done;
+};
+
 struct c_can_driver_data {
 	enum c_can_dev_id id;
+
+	/* RAMINIT register description. Optional. */
+	const struct raminit_bits *raminit_bits; /* Array of START/DONE bit positions */
+	u8 raminit_num;		/* Number of CAN instances on the SoC */
+	bool raminit_pulse;	/* If set, sets and clears START bit (pulse) */
 };
 
 /* c_can private data structure */

Signature · 1 line

2.1.1

Marc Kleine-Budde

author maintainer

2014-11-14 18:09 UTC #4 lore raw

PATCH v8 4/8 can: c_can: Add syscon/regmap RAMINIT mechanism

In reply to Marc Kleine-Budde

From: Roger Quadros <[email protected]>

Some TI SoCs like DRA7 have a RAMINIT register specification different from the other AMxx SoCs and as expected by the existing driver.

To add more insanity, this register is shared with other IPs like DSS, PCIe and PWM.

Provides a more generic mechanism to specify the RAMINIT register location and START/DONE bit position and use the syscon/regmap framework to access the register.

Signed-off-by Roger Quadros <[email protected]>

Signed-off-by Marc Kleine-Budde <[email protected]>

---
 .../devicetree/bindings/net/can/c_can.txt          |   3 +
 drivers/net/can/c_can/c_can.h                      |  10 +-
 drivers/net/can/c_can/c_can_platform.c             | 109 +++++++++++++--------
 3 files changed, 81 insertions(+), 41 deletions(-)

Documentation/devicetree/bindings/net/can/c_can.txt +3 -0

index 8f1ae81228e3..a3ca3ee53546 100644
@@ -12,6 +12,9 @@ Required properties:
 Optional properties:
 - ti,hwmods		: Must be "d_can<n>" or "c_can<n>", n being the
 			  instance number
+- syscon-raminit	: Handle to system control region that contains the
+			  RAMINIT register, register offset to the RAMINIT
+			  register and the CAN instance number (0 offset).
 
 Note: "ti,hwmods" field is used to fetch the base address and irq
 resources from TI, omap hwmod data base during device registration.

drivers/net/can/c_can/c_can.h +8 -2

index 3f111f4f0f6e..28a73d14ea8d 100644
@@ -183,6 +183,13 @@ struct c_can_driver_data {
 	bool raminit_pulse;	/* If set, sets and clears START bit (pulse) */
 };
 
+/* Out of band RAMINIT register access via syscon regmap */
+struct c_can_raminit {
+	struct regmap *syscon;	/* for raminit ctrl. reg. access */
+	unsigned int reg;	/* register index within syscon */
+	struct raminit_bits bits;
+};
+
 /* c_can private data structure */
 struct c_can_priv {
 	struct can_priv can;	/* must be the first member */

@@ -200,8 +207,7 @@ struct c_can_priv {
 	const u16 *regs;
 	void *priv;		/* for board-specific data */
 	enum c_can_dev_id type;
-	u32 __iomem *raminit_ctrlreg;
-	int instance;
+	struct c_can_raminit raminit_sys;	/* RAMINIT via syscon regmap */
 	void (*raminit) (const struct c_can_priv *priv, bool enable);
 	u32 comm_rcv_high;
 	u32 rxmasked;

drivers/net/can/c_can/c_can_platform.c +70 ~~-39~~

169 lines not on this page · raw message

Signature · 1 line

2.1.1

Tomi Valkeinen

2015-01-05 09:18 UTC #5 lore raw

Re: [PATCH v8 4/8] can: c_can: Add syscon/regmap RAMINIT mechanism

Hi Roger,

Quoted 6 lines · Marc Kleine-Budde

From: Roger Quadros <[email protected]>
Some TI SoCs like DRA7 have a RAMINIT register specification different from the other AMxx SoCs and as expected by the existing driver.

Quoted 6 lines

To add more insanity, this register is shared with other IPs like DSS, PCIe and PWM.
Provides a more generic mechanism to specify the RAMINIT register location and START/DONE bit position and use the syscon/regmap framework to access the register.

This patch updates the syscon regmap using regmap_read + regmap_write. That's not a safe way to update the bits, as some other driver may touch the register between the read and write. The change has to be made using regmap_update_bits.

We don't have other drivers using the register at the moment, but I presume we will sooner or later.

Tomi

Roger Quadros

2015-01-07 09:56 UTC #6 lore raw

Re: [PATCH v8 4/8] can: c_can: Add syscon/regmap RAMINIT mechanism

Tomi,

Quoted 16 lines · Tomi Valkeinen

Hi Roger,
Quoted 6 lines · Marc Kleine-Budde
From: Roger Quadros <[email protected]>
Some TI SoCs like DRA7 have a RAMINIT register specification different from the other AMxx SoCs and as expected by the existing driver.
Quoted 6 lines
To add more insanity, this register is shared with other IPs like DSS, PCIe and PWM.
Provides a more generic mechanism to specify the RAMINIT register location and START/DONE bit position and use the syscon/regmap framework to access the register.

Quoted 7 lines

This patch updates the syscon regmap using regmap_read + regmap_write. That's not a safe way to update the bits, as some other driver may touch the register between the read and write. The change has to be made using regmap_update_bits.
We don't have other drivers using the register at the moment, but I presume we will sooner or later.

I remember updating this after you pointed it out to me earlier, but it seems I picked up the older version while sending. :(. Thanks for pointing it again. I'll prepare a fix on top.

cheers,
-roger

Marc Kleine-Budde

author maintainer

2014-11-14 18:09 UTC #7 lore raw

PATCH v8 5/8 can: c_can: Add support for START pulse in RAMINIT sequence

In reply to Marc Kleine-Budde

From: Roger Quadros <[email protected]>

Some SoCs e.g. (TI DRA7xx) need a START pulse to start the RAMINIT sequence i.e. START bit must be set and cleared before checking for the DONE bit status.

Signed-off-by Roger Quadros <[email protected]>

Signed-off-by Marc Kleine-Budde <[email protected]>

---
 drivers/net/can/c_can/c_can.h          | 1 +
 drivers/net/can/c_can/c_can_platform.c | 7 +++++++
 2 files changed, 8 insertions(+)

drivers/net/can/c_can/c_can.h +1 -0

index 28a73d14ea8d..8acdc7fa4792 100644
@@ -188,6 +188,7 @@ struct c_can_raminit {
 	struct regmap *syscon;	/* for raminit ctrl. reg. access */
 	unsigned int reg;	/* register index within syscon */
 	struct raminit_bits bits;
+	bool needs_pulse;
 };
 
 /* c_can private data structure */

drivers/net/can/c_can/c_can_platform.c +7 -0

index 1fbfa1d59c29..41fa460c3592 100644
@@ -120,6 +120,12 @@ static void c_can_hw_raminit_syscon(const struct c_can_priv *priv, bool enable)
 		ctrl |= 1 << raminit->bits.start;
 		regmap_write(raminit->syscon, raminit->reg, ctrl);
 
+		/* clear START bit if start pulse is needed */
+		if (raminit->needs_pulse) {
+			ctrl &= ~(1 << raminit->bits.start);
+			regmap_write(raminit->syscon, raminit->reg, ctrl);
+		}
+
 		ctrl |= 1 << raminit->bits.done;
 		c_can_hw_raminit_wait_syscon(priv, mask, ctrl);
 	}

@@ -325,6 +331,7 @@ static int c_can_plat_probe(struct platform_device *pdev)
 			}
 
 			raminit->bits = drvdata->raminit_bits[id];
+			raminit->needs_pulse = drvdata->raminit_pulse;
 
 			priv->raminit = c_can_hw_raminit_syscon;
 		} else {

Signature · 1 line

2.1.1

Marc Kleine-Budde

author maintainer

2014-11-14 18:09 UTC #8 lore raw

PATCH v8 6/8 can: c_can: Disable pins when CAN interface is down

In reply to Marc Kleine-Budde

From: Roger Quadros <[email protected]>

DRA7 CAN IP suffers from a problem which causes it to be prevented from fully turning OFF (i.e. stuck in transition) if the module was disabled while there was traffic on the CAN_RX line.

To work around this issue we select the SLEEP pin state by default on probe and use the DEFAULT pin state on CAN up and back to the SLEEP pin state on CAN down.

Signed-off-by Roger Quadros <[email protected]>

Signed-off-by Marc Kleine-Budde <[email protected]>

---
 drivers/net/can/c_can/c_can.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

drivers/net/can/c_can/c_can.c +13 -0

index 8e78bb48f5a4..f94a9fa60488 100644
@@ -35,6 +35,7 @@
 #include <linux/list.h>
 #include <linux/io.h>
 #include <linux/pm_runtime.h>
+#include <linux/pinctrl/consumer.h>
 
 #include <linux/can.h>
 #include <linux/can/dev.h>

@@ -603,6 +604,8 @@ static int c_can_start(struct net_device *dev)
 
 	priv->can.state = CAN_STATE_ERROR_ACTIVE;
 
+	/* activate pins */
+	pinctrl_pm_select_default_state(dev->dev.parent);
 	return 0;
 }

@@ -611,6 +614,9 @@ static void c_can_stop(struct net_device *dev)
 	struct c_can_priv *priv = netdev_priv(dev);
 
 	c_can_irq_control(priv, false);
+
+	/* deactivate pins */
+	pinctrl_pm_select_sleep_state(dev->dev.parent);
 	priv->can.state = CAN_STATE_STOPPED;
 }

@@ -1244,6 +1250,13 @@ int register_c_can_dev(struct net_device *dev)
 	struct c_can_priv *priv = netdev_priv(dev);
 	int err;
 
+	/* Deactivate pins to prevent DRA7 DCAN IP from being
+	 * stuck in transition when module is disabled.
+	 * Pins are activated in c_can_start() and deactivated
+	 * in c_can_stop()
+	 */
+	pinctrl_pm_select_sleep_state(dev->dev.parent);
+
 	c_can_pm_runtime_enable(priv);
 
 	dev->flags |= IFF_ECHO;	/* we support local echo */

Signature · 1 line

2.1.1

Marc Kleine-Budde

author maintainer

2014-11-14 18:09 UTC #9 lore raw

PATCH v8 7/8 can: c_can: Add support for TI DRA7 DCAN

In reply to Marc Kleine-Budde

From: Roger Quadros <[email protected]>

DRA7 SoC has 2 CAN IPs. Provide compatible IDs and RAMINIT register data for both.

Signed-off-by Roger Quadros <[email protected]>

Signed-off-by Marc Kleine-Budde <[email protected]>

---
 Documentation/devicetree/bindings/net/can/c_can.txt |  1 +
 drivers/net/can/c_can/c_can_platform.c              | 13 +++++++++++++
 2 files changed, 14 insertions(+)

Documentation/devicetree/bindings/net/can/c_can.txt +1 -0

index a3ca3ee53546..f682fdb6d921 100644
@@ -4,6 +4,7 @@ Bosch C_CAN/D_CAN controller Device Tree Bindings
 Required properties:
 - compatible		: Should be "bosch,c_can" for C_CAN controllers and
 			  "bosch,d_can" for D_CAN controllers.
+			  Can be "ti,dra7-d_can".
 - reg			: physical base address and size of the C_CAN/D_CAN
 			  registers map
 - interrupts		: property with a value describing the interrupt

drivers/net/can/c_can/c_can_platform.c +13 -0

index 41fa460c3592..570da5f56aae 100644
@@ -190,6 +190,18 @@ static const struct c_can_driver_data d_can_drvdata = {
 	.id = BOSCH_D_CAN,
 };
 
+static const struct raminit_bits dra7_raminit_bits[] = {
+	[0] = { .start = 3, .done = 1, },
+	[1] = { .start = 5, .done = 2, },
+};
+
+static const struct c_can_driver_data dra7_dcan_drvdata = {
+	.id = BOSCH_D_CAN,
+	.raminit_num = ARRAY_SIZE(dra7_raminit_bits),
+	.raminit_bits = dra7_raminit_bits,
+	.raminit_pulse = true,
+};
+
 static struct platform_device_id c_can_id_table[] = {
 	{
 		.name = KBUILD_MODNAME,

@@ -210,6 +222,7 @@ MODULE_DEVICE_TABLE(platform, c_can_id_table);
 static const struct of_device_id c_can_of_table[] = {
 	{ .compatible = "bosch,c_can", .data = &c_can_drvdata },
 	{ .compatible = "bosch,d_can", .data = &d_can_drvdata },
+	{ .compatible = "ti,dra7-d_can", .data = &dra7_dcan_drvdata },
 	{ /* sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, c_can_of_table);

Signature · 1 line

2.1.1

Marc Kleine-Budde

author maintainer

2014-11-14 18:09 UTC #10 lore raw

PATCH v8 8/8 can: c_can: Add support for TI am3352 DCAN

In reply to Marc Kleine-Budde

From: Roger Quadros <[email protected]>

AM3352 SoC has 2 DCAN modules. Add compatible id and raminit driver data for am3352 DCAN.

Signed-off-by Roger Quadros <[email protected]>

Acked-by Wolfram Sang <[email protected]>

Signed-off-by Marc Kleine-Budde <[email protected]>

---
 Documentation/devicetree/bindings/net/can/c_can.txt |  2 +-
 drivers/net/can/c_can/c_can_platform.c              | 12 ++++++++++++
 2 files changed, 13 insertions(+), 1 deletion(-)

Documentation/devicetree/bindings/net/can/c_can.txt +1 -1

index f682fdb6d921..6731730eec0d 100644
@@ -4,7 +4,7 @@ Bosch C_CAN/D_CAN controller Device Tree Bindings
 Required properties:
 - compatible		: Should be "bosch,c_can" for C_CAN controllers and
 			  "bosch,d_can" for D_CAN controllers.
-			  Can be "ti,dra7-d_can".
+			  Can be "ti,dra7-d_can" or "ti,am3352-d_can".
 - reg			: physical base address and size of the C_CAN/D_CAN
 			  registers map
 - interrupts		: property with a value describing the interrupt

drivers/net/can/c_can/c_can_platform.c +12 -0

index 570da5f56aae..f4488e5d5d68 100644
@@ -202,6 +202,17 @@ static const struct c_can_driver_data dra7_dcan_drvdata = {
 	.raminit_pulse = true,
 };
 
+static const struct raminit_bits am3352_raminit_bits[] = {
+	[0] = { .start = 0, .done = 8, },
+	[1] = { .start = 1, .done = 9, },
+};
+
+static const struct c_can_driver_data am3352_dcan_drvdata = {
+	.id = BOSCH_D_CAN,
+	.raminit_num = ARRAY_SIZE(am3352_raminit_bits),
+	.raminit_bits = am3352_raminit_bits,
+};
+
 static struct platform_device_id c_can_id_table[] = {
 	{
 		.name = KBUILD_MODNAME,

@@ -223,6 +234,7 @@ static const struct of_device_id c_can_of_table[] = {
 	{ .compatible = "bosch,c_can", .data = &c_can_drvdata },
 	{ .compatible = "bosch,d_can", .data = &d_can_drvdata },
 	{ .compatible = "ti,dra7-d_can", .data = &dra7_dcan_drvdata },
+	{ .compatible = "ti,am3352-d_can", .data = &am3352_dcan_drvdata },
 	{ /* sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, c_can_of_table);

Signature · 1 line

2.1.1

Roger Quadros

2014-11-17 12:07 UTC #11 lore raw

In reply to Marc Kleine-Budde

Quoted 8 lines · Marc Kleine-Budde

Picking up Roger's work:
Changes since v7:
- combined raminit start and done bit into a struct (3/8, 7/8, 8/8)
- constified struct c_can_driver_data (2/8, 7/8, 8/8)
- silenced compiler warning in c_can_hw_raminit_{wait,}_syscon (4/8)
- use platform_get_device_id in probe() instead of open coding it (2/8)

Thanks for saving me one more iteration :). I've tested this to work on AM437x-evm and DRA7-evm.

Please pick patch 9 as well which I will send in response to this thread. That one adds compatible id for am4372-d_can.

cheers,
-roger

Roger Quadros

2014-11-17 12:09 UTC #12 lore raw

PATCH v8 9/9 net: can: c_can: Add support for TI am4372 DCAN

In reply to Marc Kleine-Budde

AM4372 SoC has 2 DCAN modules. Add compatible id and raminit driver data for it. The driver data is same as AM3352 but this gives us flexibility to add AM4372 specific quirks if required later.

Signed-off-by Roger Quadros <[email protected]>

---
 Documentation/devicetree/bindings/net/can/c_can.txt | 3 ++-
 drivers/net/can/c_can/c_can_platform.c              | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

Documentation/devicetree/bindings/net/can/c_can.txt +2 -1

index 6731730..5a1d8b0 100644
@@ -4,7 +4,8 @@ Bosch C_CAN/D_CAN controller Device Tree Bindings
 Required properties:
 - compatible		: Should be "bosch,c_can" for C_CAN controllers and
 			  "bosch,d_can" for D_CAN controllers.
-			  Can be "ti,dra7-d_can" or "ti,am3352-d_can".
+			  Can be "ti,dra7-d_can", "ti,am3352-d_can" or
+			  "ti,am4372-d_can".
 - reg			: physical base address and size of the C_CAN/D_CAN
 			  registers map
 - interrupts		: property with a value describing the interrupt

drivers/net/can/c_can/c_can_platform.c +1 -0

index f4488e5..a4535d2 100644
@@ -235,6 +235,7 @@ static const struct of_device_id c_can_of_table[] = {
 	{ .compatible = "bosch,d_can", .data = &d_can_drvdata },
 	{ .compatible = "ti,dra7-d_can", .data = &dra7_dcan_drvdata },
 	{ .compatible = "ti,am3352-d_can", .data = &am3352_dcan_drvdata },
+	{ .compatible = "ti,am4372-d_can", .data = &am3352_dcan_drvdata },
 	{ /* sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, c_can_of_table);

Signature · 1 line

1.8.3.2

Marc Kleine-Budde

author maintainer

2014-11-17 12:12 UTC #13 lore raw

Re: [PATCH v8 9/9] net: can: c_can: Add support for TI am4372 DCAN

Quoted 4 lines · Roger Quadros

AM4372 SoC has 2 DCAN modules. Add compatible id and raminit driver data for it. The driver data is same as AM3352 but this gives us flexibility to add AM4372 specific quirks if required later.

Strictly speaking we don't need the hunk in "drivers/net/can/c_can/c_can_platform.c" yet, iff the AM4372 dts(i) has this compatible:

"ti,am4372-d_can", "ti,am3352-d_can"

Quoted 27 lines

Signed-off-by Roger Quadros <[email protected]>

---
 Documentation/devicetree/bindings/net/can/c_can.txt | 3 ++-
 drivers/net/can/c_can/c_can_platform.c              | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

Documentation/devicetree/bindings/net/can/c_can.txt +2 -1

index 6731730..5a1d8b0 100644
@@ -4,7 +4,8 @@ Bosch C_CAN/D_CAN controller Device Tree Bindings
 Required properties:
 - compatible		: Should be "bosch,c_can" for C_CAN controllers and
 			  "bosch,d_can" for D_CAN controllers.
-			  Can be "ti,dra7-d_can" or "ti,am3352-d_can".
+			  Can be "ti,dra7-d_can", "ti,am3352-d_can" or
+			  "ti,am4372-d_can".
 - reg			: physical base address and size of the C_CAN/D_CAN
 			  registers map
 - interrupts		: property with a value describing the interrupt

drivers/net/can/c_can/c_can_platform.c +0 -0

index f4488e5..a4535d2 100644

drivers/net/can/c_can/c_can_platform.c static const struct of_device_id c_can_of_table[] = { · line 241

Quoted 7 lines

drivers/net/can/c_can/c_can_platform.c +1 -0

@@ -235,6 +235,7 @@ static const struct of_device_id c_can_of_table[] = {
 	{ .compatible = "bosch,d_can", .data = &d_can_drvdata },
 	{ .compatible = "ti,dra7-d_can", .data = &dra7_dcan_drvdata },
 	{ .compatible = "ti,am3352-d_can", .data = &am3352_dcan_drvdata },
+	{ .compatible = "ti,am4372-d_can", .data = &am3352_dcan_drvdata },
 	{ /* sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, c_can_of_table);

Marc

Signature · 4 lines

Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Roger Quadros

2014-11-17 12:31 UTC #14 lore raw

Re: [PATCH v8 9/9] net: can: c_can: Add support for TI am4372 DCAN

Quoted 11 lines · Marc Kleine-Budde

Quoted 4 lines · Roger Quadros
AM4372 SoC has 2 DCAN modules. Add compatible id and raminit driver data for it. The driver data is same as AM3352 but this gives us flexibility to add AM4372 specific quirks if required later.
Strictly speaking we don't need the hunk in "drivers/net/can/c_can/c_can_platform.c" yet, iff the AM4372 dts(i) has this compatible:
"ti,am4372-d_can", "ti,am3352-d_can"

I tried with that, but checkpatch still gives this warning
WARNING: DT compatible string "ti,am4372-d_can" appears un-documented -- check ./Documentation/devicetree/bindings/

I guess we can just live with it. Please ignore this patch in that case.

cheers,
-roger

Quoted 38 lines

Quoted 28 lines

Signed-off-by Roger Quadros <[email protected]>

---
 Documentation/devicetree/bindings/net/can/c_can.txt | 3 ++-
 drivers/net/can/c_can/c_can_platform.c              | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

Documentation/devicetree/bindings/net/can/c_can.txt +2 -1

index 6731730..5a1d8b0 100644
@@ -4,7 +4,8 @@ Bosch C_CAN/D_CAN controller Device Tree Bindings
 Required properties:
 - compatible		: Should be "bosch,c_can" for C_CAN controllers and
 			  "bosch,d_can" for D_CAN controllers.
-			  Can be "ti,dra7-d_can" or "ti,am3352-d_can".
+			  Can be "ti,dra7-d_can", "ti,am3352-d_can" or
+			  "ti,am4372-d_can".
 - reg			: physical base address and size of the C_CAN/D_CAN
 			  registers map
 - interrupts		: property with a value describing the interrupt

drivers/net/can/c_can/c_can_platform.c +0 -0

index f4488e5..a4535d2 100644

drivers/net/can/c_can/c_can_platform.c static const struct of_device_id c_can_of_table[] = { · line 241

Quoted 7 lines

drivers/net/can/c_can/c_can_platform.c +1 -0

@@ -235,6 +235,7 @@ static const struct of_device_id c_can_of_table[] = {
 	{ .compatible = "bosch,d_can", .data = &d_can_drvdata },
 	{ .compatible = "ti,dra7-d_can", .data = &dra7_dcan_drvdata },
 	{ .compatible = "ti,am3352-d_can", .data = &am3352_dcan_drvdata },
+	{ .compatible = "ti,am4372-d_can", .data = &am3352_dcan_drvdata },
 	{ /* sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, c_can_of_table);

Marc

Roger Quadros

2014-11-17 14:19 UTC #15 lore raw

Re: [PATCH v8 9/9] net: can: c_can: Add support for TI am4372 DCAN

Quoted 11 lines · Roger Quadros

Quoted 10 lines · Marc Kleine-Budde
Quoted 4 lines · Roger Quadros
AM4372 SoC has 2 DCAN modules. Add compatible id and raminit driver data for it. The driver data is same as AM3352 but this gives us flexibility to add AM4372 specific quirks if required later.
Strictly speaking we don't need the hunk in "drivers/net/can/c_can/c_can_platform.c" yet, iff the AM4372 dts(i) has this compatible:

Quoted 6 lines

Quoted 1 line
"ti,am4372-d_can", "ti,am3352-d_can"
I tried with that, but checkpatch still gives this warning
WARNING: DT compatible string "ti,am4372-d_can" appears un-documented -- check ./Documentation/devicetree/bindings/
I guess we can just live with it. Please ignore this patch in that case.

Did you meant that we still need to add it in the binding documentation? It is not usable by itself so won't it be a problem to exist in documentation?

cheers,
-roger

Quoted 40 lines

Quoted 39 lines

Quoted 29 lines

Signed-off-by Roger Quadros <[email protected]>

---
 Documentation/devicetree/bindings/net/can/c_can.txt | 3 ++-
 drivers/net/can/c_can/c_can_platform.c              | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

Documentation/devicetree/bindings/net/can/c_can.txt +2 -1

index 6731730..5a1d8b0 100644
@@ -4,7 +4,8 @@ Bosch C_CAN/D_CAN controller Device Tree Bindings
 Required properties:
 - compatible		: Should be "bosch,c_can" for C_CAN controllers and
 			  "bosch,d_can" for D_CAN controllers.
-			  Can be "ti,dra7-d_can" or "ti,am3352-d_can".
+			  Can be "ti,dra7-d_can", "ti,am3352-d_can" or
+			  "ti,am4372-d_can".
 - reg			: physical base address and size of the C_CAN/D_CAN
 			  registers map
 - interrupts		: property with a value describing the interrupt

drivers/net/can/c_can/c_can_platform.c +0 -0

index f4488e5..a4535d2 100644

drivers/net/can/c_can/c_can_platform.c static const struct of_device_id c_can_of_table[] = { · line 241

Quoted 7 lines

drivers/net/can/c_can/c_can_platform.c +1 -0

@@ -235,6 +235,7 @@ static const struct of_device_id c_can_of_table[] = {
 	{ .compatible = "bosch,d_can", .data = &d_can_drvdata },
 	{ .compatible = "ti,dra7-d_can", .data = &dra7_dcan_drvdata },
 	{ .compatible = "ti,am3352-d_can", .data = &am3352_dcan_drvdata },
+	{ .compatible = "ti,am4372-d_can", .data = &am3352_dcan_drvdata },
 	{ /* sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, c_can_of_table);

Marc

Marc Kleine-Budde

author maintainer

2014-11-17 14:31 UTC #16 lore raw

Re: [PATCH v8 9/9] net: can: c_can: Add support for TI am4372 DCAN

Quoted 14 lines · Roger Quadros

Quoted 13 lines · Roger Quadros
Quoted 11 lines · Marc Kleine-Budde
Quoted 4 lines · Roger Quadros
AM4372 SoC has 2 DCAN modules. Add compatible id and raminit driver data for it. The driver data is same as AM3352 but this gives us flexibility to add AM4372 specific quirks if required later.
Strictly speaking we don't need the hunk in "drivers/net/can/c_can/c_can_platform.c" yet, iff the AM4372 dts(i) has this compatible:
"ti,am4372-d_can", "ti,am3352-d_can"

Quoted 7 lines

Quoted 4 lines
I tried with that, but checkpatch still gives this warning
WARNING: DT compatible string "ti,am4372-d_can" appears un-documented -- check ./Documentation/devicetree/bindings/
I guess we can just live with it. Please ignore this patch in that case.
Did you meant that we still need to add it in the binding documentation? It is not usable by itself so won't it be a problem to exist in documentation?

I'll take patch 9 as is, since checkpatch is a bit more picky now :)

Marc

Signature · 4 lines

Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |