python-certifi: add new package
PATCH 1/1 python-certifi: add new package
--- package/Config.in | 1 + package/python-certifi/Config.in | 6 ++++++ package/python-certifi/python-certifi.mk | 14 ++++++++++++++ 3 files changed, 21 insertions(+) create mode 100644 package/python-certifi/Config.in create mode 100644 package/python-certifi/python-certifi.mk
package/Config.in +1 -0
@@ -482,6 +482,7 @@ endif if BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3 menu "external python modules" source "package/python-bottle/Config.in" + source "package/python-certifi/Config.in" source "package/python-cffi/Config.in" source "package/python-configobj/Config.in" source "package/python-configshell-fb/Config.in"
package/python-certifi/Config.in new file +6 -0
@@ -0,0 +1,6 @@ +config BR2_PACKAGE_PYTHON_CERTIFI + bool "python-certifi" + help + Python package for providing Mozilla's CA Bundle. + + https://pypi.python.org/pypi/certifi
package/python-certifi/python-certifi.mk new file +14 -0
@@ -0,0 +1,14 @@ +################################################################################ +# +# python-certifi +# +################################################################################ + +PYTHON_CERTIFI_VERSION = 14.05.14 +PYTHON_CERTIFI_SOURCE = certifi-$(PYTHON_CERTIFI_VERSION).tar.gz +PYTHON_CERTIFI_SITE = https://pypi.python.org/packages/source/c/certifi +PYTHON_CERTIFI_SETUP_TYPE = setuptools +PYTHON_CERTIFI_LICENSE = ISC +PYTHON_CERTIFI_LICENSE_FILES = LICENSE + +$(eval $(python-package))
Signature · 1 line
1.8.3.2
PATCH 1/1 python-certifi: add new package
Dear Yegor Yefremov,
I was going to commit this one, but...
Quoted 27 lines · Yegor Yefremov
Signed-off-by Yegor Yefremov <[email protected]>--- package/Config.in | 1 + package/python-certifi/Config.in | 6 ++++++ package/python-certifi/python-certifi.mk | 14 ++++++++++++++ 3 files changed, 21 insertions(+) create mode 100644 package/python-certifi/Config.in create mode 100644 package/python-certifi/python-certifi.mkpackage/Config.in +1
-0@@ -482,6 +482,7 @@ endif if BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3 menu "external python modules" source "package/python-bottle/Config.in" + source "package/python-certifi/Config.in" source "package/python-cffi/Config.in" source "package/python-configobj/Config.in" source "package/python-configshell-fb/Config.in"package/python-certifi/Config.in new file +0
-0
package/python-certifi/Config.in line 2
Quoted 2 lines
package/python-certifi/Config.in new file +2
-0@@ -0,0 +1,6 @@ +config BR2_PACKAGE_PYTHON_CERTIFI + bool "python-certifi"
We need a depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3 here. I know it's not very useful since Python packages can anyway only be selected when either Python or Python 3 are enabled, but we have this conditional for all Python packages, so we should remain consistent and have it there as well.
Maybe one day we'll remove this conditional on packages that support both Python 2 and Python 3.
But that's not the biggest problem (I added the conditional myself).
package/python-certifi/Config.in
Quoted 6 lines
package/python-certifi/Config.in new file +6
-0+PYTHON_CERTIFI_VERSION = 14.05.14 +PYTHON_CERTIFI_SOURCE = certifi-$(PYTHON_CERTIFI_VERSION).tar.gz +PYTHON_CERTIFI_SITE = https://pypi.python.org/packages/source/c/certifi +PYTHON_CERTIFI_SETUP_TYPE = setuptools +PYTHON_CERTIFI_LICENSE = ISC +PYTHON_CERTIFI_LICENSE_FILES = LICENSE
The biggest problem is the licensing information. Indeed PKG-INFO indicates that it's licensed under the ISC, but the LICENSE file is pretty unclear about, it doesn't mention the ISC at all, and instead talks about the Mozilla Public License.
So the licensing details of this package are pretty unclear. Can you dig a little bit, and see what is the actual license for this package?
I've Cc'ed a bunch of licensing aware folks, in case they have an opinion.
Thanks a lot!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 python-certifi: add new package
Quoted 32 lines · Thomas Petazzoni
Dear Yegor Yefremov,
I was going to commit this one, but...
Quoted 27 lines · Yegor Yefremov
Signed-off-by Yegor Yefremov <[email protected]>--- package/Config.in | 1 + package/python-certifi/Config.in | 6 ++++++ package/python-certifi/python-certifi.mk | 14 ++++++++++++++ 3 files changed, 21 insertions(+) create mode 100644 package/python-certifi/Config.in create mode 100644 package/python-certifi/python-certifi.mkpackage/Config.in +1
-0@@ -482,6 +482,7 @@ endif if BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3 menu "external python modules" source "package/python-bottle/Config.in" + source "package/python-certifi/Config.in" source "package/python-cffi/Config.in" source "package/python-configobj/Config.in" source "package/python-configshell-fb/Config.in"package/python-certifi/Config.in new file +0
-0@@ -0,0 +1,6 @@
Quoted 8 lines
package/python-certifi/Config.in line 2
Quoted 2 lines
package/python-certifi/Config.in new file +2
-0+config BR2_PACKAGE_PYTHON_CERTIFI + bool "python-certifi"We need a depends on
BR2_PACKAGE_PYTHON||BR2_PACKAGE_PYTHON3here. I know it's not very useful since Python packages can anyway only be selected when either Python or Python 3 are enabled, but we have this conditional for all Python packages, so we should remain consistent and have it there as well.
Well, a quick grep in next shows that we have 8 packages without this depends,
and 14 packages with the depends.
However, since the python packages that have recently been added by Peter do
not have the depends, and since he told Yegor to remove the depends in python-webpy, I think the rule now is _not_ to have the depends.
Quoted 18 lines
Maybe one day we'll remove this conditional on packages that support both Python 2 and Python 3.
But that's not the biggest problem (I added the conditional myself).
package/python-certifi/Config.in
Quoted 6 lines
package/python-certifi/Config.in new file +6
-0+PYTHON_CERTIFI_VERSION = 14.05.14 +PYTHON_CERTIFI_SOURCE = certifi-$(PYTHON_CERTIFI_VERSION).tar.gz +PYTHON_CERTIFI_SITE = https://pypi.python.org/packages/source/c/certifi +PYTHON_CERTIFI_SETUP_TYPE = setuptools +PYTHON_CERTIFI_LICENSE = ISC +PYTHON_CERTIFI_LICENSE_FILES = LICENSEThe biggest problem is the licensing information. Indeed PKG-INFO indicates that it's licensed under the ISC, but the LICENSE file is pretty unclear about, it doesn't mention the ISC at all, and instead talks about the Mozilla Public License.
Quoted 2 lines
So the licensing details of this package are pretty unclear. Can you dig a little bit, and see what is the actual license for this package?
It's pretty clear to me: the certificate database itself is MPL, the python
code around it is ISC.
Actually, since it's only about 5 lines of code, I doubt the python code is even copyrightable, but let's ignore that :-)
Regards,
Arnout
Quoted 8 lines
I've Cc'ed a bunch of licensing aware folks, in case they have an opinion.
Thanks a lot!
Thomas
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 1/1 python-certifi: add new package
Dear Arnout Vandecappelle,
Quoted 6 lines · Arnout Vandecappelle
Quoted 5 lines
We need a depends on
BR2_PACKAGE_PYTHON||BR2_PACKAGE_PYTHON3here. I know it's not very useful since Python packages can anyway only be selected when either Python or Python 3 are enabled, but we have this conditional for all Python packages, so we should remain consistent and have it there as well.
Quoted 6 lines
Well, a quick grep in next shows that we have 8 packages without this depends,
and 14 packages with the depends.However, since the python packages that have recently been added by Peter do
not have the depends, and since he told Yegor to remove the depends in python-webpy, I think the rule now is _not_ to have the depends.
Damn, so the guy doing most of the Python maintenance, and who did introduce the possibility of building modules with both Python 2 and Python 3, doesn't have a word into such decisions? Where are we going? :-)
Quoted 7 lines
Quoted 2 lines
So the licensing details of this package are pretty unclear. Can you dig a little bit, and see what is the actual license for this package?
It's pretty clear to me: the certificate database itself is MPL, the python
code around it is ISC.
Actually, since it's only about 5 lines of code, I doubt the python code is even copyrightable, but let's ignore that :-)
So probably we need a more precise <pkg>_LICENSE data than just "ISC", no?
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 python-certifi: add new package
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas Petazzoni <[email protected]> writes:
Hi,
Quoted 9 lines
Quoted 9 lines
Quoted 5 lines
We need a depends on
BR2_PACKAGE_PYTHON||BR2_PACKAGE_PYTHON3here. I know it's not very useful since Python packages can anyway only be selected when either Python or Python 3 are enabled, but we have this conditional for all Python packages, so we should remain consistent and have it there as well.Well, a quick grep in next shows that we have 8 packages without this depends, and 14 packages with the depends.
Quoted 8 lines
Quoted 3 lines
However, since the python packages that have recently been added by Peter do not have the depends, and since he told Yegor to remove the depends in python-webpy, I think the rule now is _not_ to have the depends.
Damn, so the guy doing most of the Python maintenance, and who did introduce the possibility of building modules with both Python 2 and Python 3, doesn't have a word into such decisions? Where are we going? :-)
Everything is open for discussion, but why would you want to add it? Consistency?
To me it makes pretty good sense that the modules are only visible if python || python3, and the individual modules can add further restrictions if needed (only for python2 or python3, needing some other package or toolchain options).
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 python-certifi: add new package
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Peter" == Peter Korsgaard <[email protected]> writes:
Hi,
Quoted 5 lines
Quoted 4 lines
Damn, so the guy doing most of the Python maintenance, and who did introduce the possibility of building modules with both Python 2 and Python 3, doesn't have a word into such decisions? Where are we going? :-)
Quoted 7 lines
Everything is open for discussion, but why would you want to add it? Consistency?
To me it makes pretty good sense that the modules are only visible if python || python3, and the individual modules can add further restrictions if needed (only for python2 or python3, needing some other package or toolchain options).
After discussing it on IRC we agreed that the extra dependencies inside the package Config.in doesn't make sense, but we should be consistent all over the tree, so I will remove the extra depends on lines in next.
Thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 python-certifi: add new package
In reply to Arnout VandecappelleQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Arnout" == Arnout Vandecappelle <[email protected]> writes:
Hi,
Quoted 9 lines
Quoted 8 lines
package/python-certifi/Config.in line 2
Quoted 2 lines
package/python-certifi/Config.in new file +2
-0+config BR2_PACKAGE_PYTHON_CERTIFI + bool "python-certifi"We need a depends on
BR2_PACKAGE_PYTHON||BR2_PACKAGE_PYTHON3here. I know it's not very useful since Python packages can anyway only be selected when either Python or Python 3 are enabled, but we have this conditional for all Python packages, so we should remain consistent and have it there as well.
Quoted 6 lines
Well, a quick grep in next shows that we have 8 packages without this depends,
and 14 packages with the depends.However, since the python packages that have recently been added by Peter do
not have the depends, and since he told Yegor to remove the depends in python-webpy, I think the rule now is _not_ to have the depends.
Everything is open for discussion, but it's completely redundant because of the conditional in package/Config.in. Why would we want to add it?
I didn't add it to the packages I recently added because I knew about the toplevel conditional. I hadn't noticed that (some of) the existing modules had it in their Config.in as well.
Signature · 1 line
Bye, Peter Korsgaard