ARM: multi_v7_defconfig: fix failure setting CPU voltage by enabling dependent I2C controller
Subsystems (2)
PATCH 1/1 ARM: multi_v7_defconfig: fix failure setting CPU voltage by enabling dependent I2C controller
This patch fixes a long standing issue introduced during the 3.16 merge window. Shortly after the merge, exynos5250-based arndale boards began to produce the following errors:
kern.err kernel: exynos-cpufreq exynos-cpufreq: failed to set cpu voltage kern.err kernel: cpufreq: __target_index: Failed to change cpu frequency: -22
Further analysis revealed that the S5M8767 voltage regulator used on the exynos5250-based arndale board utilizes the S3C2410 I2C controller. If the S3C2410 I2C controller driver is not enabled, the S5M8767 voltage regulator fails to probe. Therefore a dependency exists between these two drivers. In the exynos_defconfig both CONFIG_REGULATOR_S5M8767 and CONFIG_I2C_S3C2410 options are enabled, and no errors are produced. However, in the multi_v7_defconfig only the CONFIG_REGULATOR_S5M8767 option is enabled and the errors are present. So let's enable the CONFIG_I2C_S3C2410 option in the multi_v7_defconfig to allow the S5M8767 voltage regulator to probe.
---
This issue was reported [1]. I've also confirmed this fix on two different arndale boards.
[1] https://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg38765.html
arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+)
arch/arm/configs/multi_v7_defconfig +1 -0
@@ -217,6 +217,7 @@ CONFIG_I2C_CADENCE=y CONFIG_I2C_DESIGNWARE_PLATFORM=y CONFIG_I2C_EXYNOS5=y CONFIG_I2C_MV64XXX=y +CONFIG_I2C_S3C2410=y CONFIG_I2C_SIRF=y CONFIG_I2C_TEGRA=y CONFIG_I2C_ST=y
Signature · 1 line
2.1.3
PATCH 1/1 ARM: multi_v7_defconfig: fix failure setting CPU voltage by enabling dependent I2C controller
On 11/19/14 04:10, Tyler Baker wrote:
Hi,
+ Arnd, Olof and Kevin
Quoted 17 lines
This patch fixes a long standing issue introduced during the 3.16 merge window. Shortly after the merge, exynos5250-based arndale boards began to produce the following errors:
kern.err kernel: exynos-cpufreq exynos-cpufreq: failed to set cpu voltage kern.err kernel: cpufreq: __target_index: Failed to change cpu frequency: -22Further analysis revealed that the S5M8767 voltage regulator used on the exynos5250-based arndale board utilizes the S3C2410 I2C controller. If the S3C2410 I2C controller driver is not enabled, the S5M8767 voltage regulator fails to probe. Therefore a dependency exists between these two drivers. In the
exynos_defconfigbothCONFIG_REGULATOR_S5M8767andCONFIG_I2C_S3C2410options are enabled, and no errors are produced. However, in themulti_v7_defconfigonly theCONFIG_REGULATOR_S5M8767option is enabled and the errors are present. So let's enable theCONFIG_I2C_S3C2410option in themulti_v7_defconfigto allow the S5M8767 voltage regulator to probe.
Quoted 1 line
Signed-off-by Tyler Baker <[email protected]>
Thanks,
Kukjin
Quoted 21 lines
---
This issue was reported [1]. I've also confirmed this fix on two different arndale boards.[1] https://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg38765.html
arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+)arch/arm/configs/multi_v7_defconfig +1
-0@@ -217,6 +217,7 @@ CONFIG_I2C_CADENCE=y CONFIG_I2C_DESIGNWARE_PLATFORM=y CONFIG_I2C_EXYNOS5=y CONFIG_I2C_MV64XXX=y +CONFIG_I2C_S3C2410=y CONFIG_I2C_SIRF=y CONFIG_I2C_TEGRA=y CONFIG_I2C_ST=y
Kevin Hilman
AppliedPATCH 1/1 ARM: multi_v7_defconfig: fix failure setting CPU voltage by enabling dependent I2C controller
Quoted 23 lines · Kukjin Kim
On 11/19/14 04:10, Tyler Baker wrote:
Hi,
+ Arnd, Olof and Kevin
Quoted 17 lines
This patch fixes a long standing issue introduced during the 3.16 merge window. Shortly after the merge, exynos5250-based arndale boards began to produce the following errors:
kern.err kernel: exynos-cpufreq exynos-cpufreq: failed to set cpu voltage kern.err kernel: cpufreq: __target_index: Failed to change cpu frequency: -22Further analysis revealed that the S5M8767 voltage regulator used on the exynos5250-based arndale board utilizes the S3C2410 I2C controller. If the S3C2410 I2C controller driver is not enabled, the S5M8767 voltage regulator fails to probe. Therefore a dependency exists between these two drivers. In the
exynos_defconfigbothCONFIG_REGULATOR_S5M8767andCONFIG_I2C_S3C2410options are enabled, and no errors are produced. However, in themulti_v7_defconfigonly theCONFIG_REGULATOR_S5M8767option is enabled and the errors are present. So let's enable theCONFIG_I2C_S3C2410option in themulti_v7_defconfigto allow the S5M8767 voltage regulator to probe.
Quoted 3 lines
Quoted 1 line
Signed-off-by Tyler Baker <[email protected]>Acked-by Kukjin Kim <[email protected]>
Applied to arm-soc/fixes, which is merged into arm-soc/for-next.
Thanks,
Kevin