ARM: dts: Specify Odroid X2/U3 audio clock parents and rates
Subsystems (2)
PATCH 1/1 ARM: dts: Specify Odroid X2/U3 audio clock parents and rates
This ensures the core and the audio subsystem clocks are configured properly, as expected by the sound machine driver. These bits are missing to obtain proper audio sample rates in kernel v3.17, where audio support for Odroid X2/U3 was first added.
---
It would be good to have it applied as a fix for v3.17.
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)
arch/arm/boot/dts/exynos4412-odroid-common.dtsi +10 -0
@@ -45,6 +45,16 @@ compatible = "samsung,odroidx2-audio"; samsung,i2s-controller = <&i2s0>; samsung,audio-codec = <&max98090>; + assigned-clocks = <&clock_audss EXYNOS_MOUT_AUDSS>, + <&clock_audss EXYNOS_MOUT_I2S>, + <&clock_audss EXYNOS_DOUT_SRP>, + <&clock_audss EXYNOS_DOUT_AUD_BUS>; + assigned-clock-parents = <&clock CLK_FOUT_EPLL>, + <&clock_audss EXYNOS_MOUT_AUDSS>; + assigned-clock-rates = <0>, + <0>, + <192000000>, + <19200000>; }; mmc at 12550000 {
--
1.7.9.5
PATCH 1/1 ARM: dts: Specify Odroid X2/U3 audio clock parents and rates
Quoted 8 lines · Sylwester Nawrocki
This ensures the core and the audio subsystem clocks are configured properly, as expected by the sound machine driver. These bits are missing to obtain proper audio sample rates in kernel v3.17, where audio support for Odroid X2/U3 was first added.
Signed-off-by Sylwester Nawrocki <[email protected]>---
It would be good to have it applied as a fix for v3.17.
Anything happened to this patch ? I can't see it neither in Linus' nor -next tree. And we are already at 3.18 merge window.
Quoted 26 lines
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)arch/arm/boot/dts/exynos4412-odroid-common.dtsi +10
-1@@ -45,6 +45,16 @@ compatible = "samsung,odroidx2-audio"; samsung,i2s-controller = <&i2s0>; samsung,audio-codec = <&max98090>; + assigned-clocks = <&clock_audss EXYNOS_MOUT_AUDSS>, + <&clock_audss EXYNOS_MOUT_I2S>, + <&clock_audss EXYNOS_DOUT_SRP>, + <&clock_audss EXYNOS_DOUT_AUD_BUS>; + assigned-clock-parents = <&clock CLK_FOUT_EPLL>, + <&clock_audss EXYNOS_MOUT_AUDSS>; + assigned-clock-rates = <0>, + <0>, + <192000000>, + <19200000>; }; mmc at 12550000 { --1.7.9.5
PATCH 1/1 ARM: dts: Specify Odroid X2/U3 audio clock parents and rates
Quoted 7 lines · Sylwester Nawrocki
Quoted 5 lines · Sylwester Nawrocki
This ensures the core and the audio subsystem clocks are configured properly, as expected by the sound machine driver. These bits are missing to obtain proper audio sample rates in kernel v3.17, where audio support for Odroid X2/U3 was first added.
Quoted 7 lines
Quoted 3 lines
Signed-off-by Sylwester Nawrocki <[email protected]>---
It would be good to have it applied as a fix for v3.17.Anything happened to this patch ? I can't see it neither in Linus' nor -next tree. And we are already at 3.18 merge window.
Hi Sylwester,
Sorry about that. I'll queue this one into fixes for -3.18 and stable maybe +3.17 only if stable-3.17 is available...
Thanks for your gentle reminder.
- Kukjin
Quoted 27 lines
arch/arm/boot/dts/exynos4412-odroid-
Quoted 4 lines
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)arch/arm/boot/dts/exynos4412-odroid- renamed from arch/arm/boot/dts/exynos4412-odroid-common.dtsi +0
-0
common.dtsiQuoted 22 lines
index adadaf9..b40f766 100644
arch/arm/boot/dts/exynos4412-odroid-common.dtsi +10
-1@@ -45,6 +45,16 @@ compatible = "samsung,odroidx2-audio"; samsung,i2s-controller = <&i2s0>; samsung,audio-codec = <&max98090>; + assigned-clocks = <&clock_audss EXYNOS_MOUT_AUDSS>, + <&clock_audss EXYNOS_MOUT_I2S>, + <&clock_audss EXYNOS_DOUT_SRP>, + <&clock_audss EXYNOS_DOUT_AUD_BUS>; + assigned-clock-parents = <&clock CLK_FOUT_EPLL>, + <&clock_audss EXYNOS_MOUT_AUDSS>; + assigned-clock-rates = <0>, + <0>, + <192000000>, + <19200000>; }; mmc at 12550000 { --1.7.9.5
PATCH 1/1 ARM: dts: Specify Odroid X2/U3 audio clock parents and rates
Quoted 10 lines · Kukjin Kim
Quoted 10 lines
Quoted 10 lines · Sylwester Nawrocki
Quoted 8 lines
Quoted 8 lines
This ensures the core and the audio subsystem clocks are configured properly, as expected by the sound machine driver. These bits are missing to obtain proper audio sample rates in kernel v3.17, where audio support for Odroid X2/U3 was first added.
Signed-off-by Sylwester Nawrocki <[email protected]>---
It would be good to have it applied as a fix for v3.17.
Quoted 7 lines
Quoted 3 lines
Quoted 3 lines
Anything happened to this patch ? I can't see it neither in Linus' nor -next tree. And we are already at 3.18 merge window.
Hi Sylwester,
Sorry about that. I'll queue this one into fixes for -3.18 and stable maybe +3.17 only if stable-3.17 is available...
Kukjin,
You didn't forget about this patch, did you ?
It's been over 2 months since I've sent it and sound on Odroid X2/U3 is still broken as it was then. Please send the patch upstream.
--
Thanks,
Sylwester
Kukjin Kim
AppliedPATCH 1/1 ARM: dts: Specify Odroid X2/U3 audio clock parents and rates
Quoted 16 lines · Sylwester Nawrocki
Quoted 15 lines · Kukjin Kim
Quoted 6 lines
Quoted 6 lines · Sylwester Nawrocki
Quoted 5 lines
Quoted 5 lines
This ensures the core and the audio subsystem clocks are configured properly, as expected by the sound machine driver. These bits are missing to obtain proper audio sample rates in kernel v3.17, where audio support for Odroid X2/U3 was first added.
Quoted 7 lines
Quoted 7 lines
Quoted 3 lines
Quoted 3 lines
Signed-off-by Sylwester Nawrocki <[email protected]>---
It would be good to have it applied as a fix for v3.17.Anything happened to this patch ? I can't see it neither in Linus' nor -next tree. And we are already at 3.18 merge window.
Hi Sylwester,
Quoted 9 lines
Quoted 2 lines
Sorry about that. I'll queue this one into fixes for -3.18 and stable maybe +3.17 only if stable-3.17 is available...
Kukjin,
You didn't forget about this patch, did you ?
It's been over 2 months since I've sent it and sound on Odroid X2/U3 is still broken as it was then. Please send the patch upstream.
Sylwester,
I've applied this just now and if required, we need to send out to stable tree as well...sorry for that.
Thanks,
Kukjin