Skip to contentSkip to conversation

Remove redundant CONFIG_SPL_START_S_PATH

PATCH New Masahiro Yamada 3 participants 9 messages Nov 21, 2014 – Dec 8, 2014 Arm i.MX and Layerscape

lore
Share & tools
lore

Masahiro Yamada

author
#0 lore raw

cover Remove redundant CONFIG_SPL_START_S_PATH

Daniel has posted a nice patch to introduce arch/$ARCH/Makefile.
http://patchwork.ozlabs.org/patch/412497/

Because it is touching CONFIG_SPL_START_S_PATH,
I'd like to remove redundant CONFIG_SPL_START_S_PATH beforehand in order to help to review Daniel's patch.

It turned out all the CONFIG_SPL_START_S_PATH defines on powerpc boards are totally bogus.
Now it is very clear why Daniel did not add START_S_PATH handling in arch/powerpc/Makefile.

Masahiro Yamada (3):
powerpc: lwmon5: remove redundant CONFIG_SPL_* defines
powerpc: a3m071: remove redundant CONFIG_SPL_* defines
imx6: remove redudant CONFIG_SPL_START_S_PATH define

 include/configs/a3m071.h   | 2 --
 include/configs/imx6_spl.h | 1 -
 include/configs/lwmon5.h   | 2 --
 3 files changed, 5 deletions(-)
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 1/3 powerpc: lwmon5: remove redundant CONFIG_SPL_* defines

The CPU directory of this board is arch/powerpc/cpu/ppc4xx. Without the CONFIG_SPL_START_S_PATH and CONFIG_SPL_LDSCRIPT defines, the same start.o and u-boot-spl.lds are selected by default.

Signed-off-by Masahiro Yamada <[email protected]>
Cc Wolfgang Denk <[email protected]>

---

 include/configs/lwmon5.h | 2 --
 1 file changed, 2 deletions(-)
include/configs/lwmon5.h +0 -2
index 58e7295..d43db52 100644
@@ -671,8 +671,6 @@
 #define CONFIG_SPL_TEXT_BASE		0xffff0000 /* last 64 KiB for SPL */
 #define CONFIG_SYS_SPL_MAX_LEN		(64 << 10)
 #define CONFIG_UBOOT_PAD_TO		458752	/* decimal for 'dd' */
-#define	CONFIG_SPL_START_S_PATH	"arch/powerpc/cpu/ppc4xx"
-#define CONFIG_SPL_LDSCRIPT	"arch/powerpc/cpu/ppc4xx/u-boot-spl.lds"
 #define CONFIG_SPL_LIBCOMMON_SUPPORT	/* image.c */
 #define CONFIG_SPL_LIBGENERIC_SUPPORT	/* string.c */
 #define CONFIG_SPL_SERIAL_SUPPORT
Signature · 1 line
1.9.1
#3 lore raw

PATCH 1/3 powerpc: lwmon5: remove redundant CONFIG_SPL_* defines

In reply to Masahiro Yamada
Quoted 7 lines · Masahiro Yamada

The CPU directory of this board is arch/powerpc/cpu/ppc4xx. Without the CONFIG_SPL_START_S_PATH and CONFIG_SPL_LDSCRIPT defines, the same start.o and u-boot-spl.lds are selected by default.

Signed-off-by Masahiro Yamada <[email protected]>
Cc Wolfgang Denk <[email protected]>
Acked-by Stefan Roese <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141208/38fd9068/attachment.pgp>
author
#4 lore raw

PATCH 2/3 powerpc: a3m071: remove redundant CONFIG_SPL_* defines

In reply to Masahiro Yamada

The CPU directory of this board is arch/powerpc/cpu/mpc5xxx. Without the CONFIG_SPL_START_S_PATH and CONFIG_SPL_LDSCRIPT defines, the same start.o and u-boot-spl.lds are selected by default.

Signed-off-by Masahiro Yamada <[email protected]>
Cc Stefan Roese <[email protected]>

---

 include/configs/a3m071.h | 2 --
 1 file changed, 2 deletions(-)
include/configs/a3m071.h +0 -2
index a4050f3..565f258 100644
@@ -416,8 +416,6 @@
 #define CONFIG_SPL_BOARD_INIT
 #define CONFIG_SPL_NOR_SUPPORT
 #define CONFIG_SPL_TEXT_BASE	0xfc000000
-#define	CONFIG_SPL_START_S_PATH	"arch/powerpc/cpu/mpc5xxx"
-#define CONFIG_SPL_LDSCRIPT	"arch/powerpc/cpu/mpc5xxx/u-boot-spl.lds"
 #define CONFIG_SPL_LIBCOMMON_SUPPORT	/* image.c */
 #define CONFIG_SPL_LIBGENERIC_SUPPORT	/* string.c */
 #define CONFIG_SPL_SERIAL_SUPPORT
Signature · 1 line
1.9.1
#6 lore raw

PATCH 2/3 powerpc: a3m071: remove redundant CONFIG_SPL_* defines

In reply to Masahiro Yamada
Quoted 7 lines · Masahiro Yamada

The CPU directory of this board is arch/powerpc/cpu/mpc5xxx. Without the CONFIG_SPL_START_S_PATH and CONFIG_SPL_LDSCRIPT defines, the same start.o and u-boot-spl.lds are selected by default.

Signed-off-by Masahiro Yamada <[email protected]>
Cc Stefan Roese <[email protected]>
Acked-by Stefan Roese <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141208/a02c6f21/attachment.pgp>
author
#7 lore raw

PATCH 3/3 imx6: remove redudant CONFIG_SPL_START_S_PATH define

In reply to Masahiro Yamada

The CPU directory of IMX6 is arch/arm/cpu/armv7, so setting CONFIG_SPL_START_S_PATH to arch/arm/cpu/armv7 is totally redundant.

Signed-off-by Masahiro Yamada <[email protected]>
Cc Stefano Babic <[email protected]>

---

 include/configs/imx6_spl.h | 1 -
 1 file changed, 1 deletion(-)
include/configs/imx6_spl.h +0 -1
index 5a5f940..2fb1cc9 100644
@@ -28,7 +28,6 @@
 #define CONFIG_SPL_LDSCRIPT	"arch/arm/cpu/armv7/omap-common/u-boot-spl.lds"
 #define CONFIG_SPL_TEXT_BASE		0x00908000
 #define CONFIG_SPL_MAX_SIZE		0x10000
-#define CONFIG_SPL_START_S_PATH		"arch/arm/cpu/armv7"
 #define CONFIG_SPL_STACK		0x0091FFB8
 #define CONFIG_SPL_LIBCOMMON_SUPPORT
 #define CONFIG_SPL_LIBGENERIC_SUPPORT
Signature · 1 line
1.9.1
#8 lore raw

PATCH 3/3 imx6: remove redudant CONFIG_SPL_START_S_PATH define

Quoted 5 lines · Masahiro Yamada

The CPU directory of IMX6 is arch/arm/cpu/armv7, so setting CONFIG_SPL_START_S_PATH to arch/arm/cpu/armv7 is totally redundant.

Signed-off-by Masahiro Yamada <[email protected]>
Cc Stefano Babic <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141208/c62d7393/attachment.pgp>