Skip to contentSkip to conversation

bluez5_utils: bumped version number to 5.25

PATCH New Jaap Crezee 4 participants 7 messages Nov 21, 2014 – Nov 26, 2014

lore
Share & tools
lore

Jaap Crezee

author
#0 lore raw

PATCH 1/1 bluez5_utils: bumped version number to 5.25

---
 package/bluez5_utils/bluez5_utils.hash | 3 +++
 package/bluez5_utils/bluez5_utils.mk   | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
 create mode 100644 package/bluez5_utils/bluez5_utils.hash
package/bluez5_utils/bluez5_utils.hash new file +3 -0
new file mode 100644
index 0000000..9166f7e
@@ -0,0 +1,3 @@
+# No upstream hashes for the following:
+sha1    8f65a7076d83116cfacbb84374b99269cd15f1d6                            bluez-5.25.tar.xz
+sha256  5ca62f3f45e2638a0f7a81658d6c8813ee01487436ae8e53e9fe395e23d1fd30    bluez-5.25.tar.xz
package/bluez5_utils/bluez5_utils.mk +1 -1
index f34513c..21f792c 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-BLUEZ5_UTILS_VERSION = 5.21
+BLUEZ5_UTILS_VERSION = 5.25
 BLUEZ5_UTILS_SOURCE = bluez-$(BLUEZ5_UTILS_VERSION).tar.xz
 BLUEZ5_UTILS_SITE = $(BR2_KERNEL_MIRROR)/linux/bluetooth
 BLUEZ5_UTILS_INSTALL_STAGING = YES
Signature · 1 line
2.1.3
#1 lore raw

PATCH 1/1 bluez5_utils: bumped version number to 5.25

Dear Jaap Crezee,

Quoted 21 lines · Jaap Crezee
---
 package/bluez5_utils/bluez5_utils.hash | 3 +++
 package/bluez5_utils/bluez5_utils.mk   | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
 create mode 100644 package/bluez5_utils/bluez5_utils.hash
package/bluez5_utils/bluez5_utils.hash new file +3 -0
new file mode 100644
index 0000000..9166f7e
@@ -0,0 +1,3 @@
+# No upstream hashes for the following:
+sha1    8f65a7076d83116cfacbb84374b99269cd15f1d6                            bluez-5.25.tar.xz
+sha256  5ca62f3f45e2638a0f7a81658d6c8813ee01487436ae8e53e9fe395e23d1fd30    bluez-5.25.tar.xz
package/bluez5_utils/bluez5_utils.mk +0 -0
index f34513c..21f792c 100644

package/bluez5_utils/bluez5_utils.mk line 10

Quoted 8 lines
package/bluez5_utils/bluez5_utils.mk +1 -1
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-BLUEZ5_UTILS_VERSION = 5.21
+BLUEZ5_UTILS_VERSION = 5.25
 BLUEZ5_UTILS_SOURCE = bluez-$(BLUEZ5_UTILS_VERSION).tar.xz
 BLUEZ5_UTILS_SITE = $(BR2_KERNEL_MIRROR)/linux/bluetooth
 BLUEZ5_UTILS_INSTALL_STAGING = YES

thanks for sending an improved version of your patch. Is much better now :)

Here you have my:

Reviewed-by Vicente Olivert Riera <[email protected]>
Tested-by Vicente Olivert Riera <[email protected]>

Just a few more things for the next time you send patches to Buildroot. After sending a new version of a patch, we usually mark the former patch as "superseded" in patchwork. To be able to do that, you need to be logged in in patchwork. If you don't have an account, you can create one here:

http://patchwork.ozlabs.org/register/

Another one. When you create the patch using "git format-patch", before sending it, please edit the patch using your favourite text editor and add the version number in the "Subject" line. Here is an example using your own patch:

Subject: [PATCH v2] bluez5_utils: bumped version number to 5.25

Also, is useful if you explain the differences between the patch versions. You can add that information just below the "---" line of you patch. Here is an example using your own patch:

# [snip] #
Subject: [PATCH] bluez5_utils: bumped version number to 5.25

---
Changes v1 -> v2:
- Improved subject
- Add a hash file

 package/bluez5_utils/bluez5_utils.hash |    3 +++

# [snip] #

And the last thing. Having only the sha256 hash is enough. And, if there are no upstream hashes we can use, then we usually say "Locally calculated" as a comment, instead of saying that there are no upstream hashes, as you did.

I hope my comments help you in the future.

Cheers,

Signature · 5 lines
Vicente Olivert Riera
Graduate Software Engineer, MIPS Processor IP
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com
#2 lore raw

PATCH 1/1 bluez5_utils: bumped version number to 5.25

Dear Vicente Olivert Riera,

Quoted 6 lines · Vicente Olivert Riera

Another one. When you create the patch using "git format-patch", before sending it, please edit the patch using your favourite text editor and add the version number in the "Subject" line. Here is an example using your own patch:

Subject: [PATCH v2] bluez5_utils: bumped version number to 5.25

Just a quick comment: there's no need to fire up a text editor to do this. Just do:

	git format-patch --subject-prefix="PATCHv2"

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 bluez5_utils: bumped version number to 5.25

Hi Thomas, Vicente,

Quoted 9 lines · Thomas Petazzoni

Dear Vicente Olivert Riera,

Quoted 5 lines · Vicente Olivert Riera

Another one. When you create the patch using "git format-patch", before sending it, please edit the patch using your favourite text editor and add the version number in the "Subject" line. Here is an example using your own patch:

Quoted 6 lines
Quoted 1 line

Subject: [PATCH v2] bluez5_utils: bumped version number to 5.25

Just a quick comment: there's no need to fire up a text editor to do this. Just do:

	git format-patch --subject-prefix="PATCHv2"

Since you mentioned it I'll add that with a recent enough version of git you can shorten it to

git format-patch -v 2

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#4 lore raw

PATCH 1/1 bluez5_utils: bumped version number to 5.25

In reply to Thomas Petazzoni

Dear Thomas Petazzoni,

Quoted 11 lines · Thomas Petazzoni

Dear Vicente Olivert Riera,

Quoted 6 lines · Vicente Olivert Riera

Another one. When you create the patch using "git format-patch", before sending it, please edit the patch using your favourite text editor and add the version number in the "Subject" line. Here is an example using your own patch:

Subject: [PATCH v2] bluez5_utils: bumped version number to 5.25

Quoted 9 lines

Just a quick comment: there's no need to fire up a text editor to do this. Just do:

	git format-patch --subject-prefix="PATCHv2"

Best regards,

Thomas

I didn't know that. Thanks for the info :-)

Cheers,

Signature · 5 lines
Vicente Olivert Riera
Graduate Software Engineer, MIPS Processor IP
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com
#5 lore raw

PATCH 1/1 bluez5_utils: bumped version number to 5.25

In reply to Jaap Crezee

Dear Jaap Crezee,

Quoted 5 lines · Jaap Crezee
---
 package/bluez5_utils/bluez5_utils.hash | 3 +++
 package/bluez5_utils/bluez5_utils.mk   | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
 create mode 100644 package/bluez5_utils/bluez5_utils.hash

Your Signed-off-by line is missing in the patch.

Can you resend after adding your SoB line?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#6 lore raw

PATCH 1/1 bluez5_utils: bumped version number to 5.25

Hello,

Quoted 9 lines · Thomas Petazzoni

Dear Jaap Crezee,

Quoted 5 lines · Jaap Crezee
---
 package/bluez5_utils/bluez5_utils.hash | 3 +++
 package/bluez5_utils/bluez5_utils.mk   | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
 create mode 100644 package/bluez5_utils/bluez5_utils.hash
Quoted 3 lines

Your Signed-off-by line is missing in the patch.

Can you resend after adding your SoB line?

Ping? Could you resend with your SoB line added? Without this, I cannot commit your patch.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com