Skip to contentSkip to conversation

drivers:staging:iio: fix checkpatch complaint about space before comma

PATCH In review Zachary Warren 2 participants 2 messages Nov 22, 2014

Subsystems (4)
Staging IIO Analog Devices IIO drivers Staging - industrial io
lore
Share & tools
lore

Zachary Warren

author
#0 lore raw

PATCH 1/1 drivers:staging:iio: fix checkpatch complaint about space before comma

Fixes:
drivers/staging/iio/adc/ad7192.c:615: ERROR: space prohibited before that ',' drivers/staging/iio/meter/ade7759.c:119: ERROR: space prohibited before that ','

Signed-off-by Zachary Warren <[email protected]>

---

This is for Eudyptula Challenge Task 10 which requires sending a checkpatch fix in linux-next drivers/staging to a maintainer and public mailing list. Apologies for mistakes and any inconvenience.

 drivers/staging/iio/adc/ad7192.c    | 2 +-
 drivers/staging/iio/meter/ade7759.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/iio/adc/ad7192.c +1 -1
index f6526aa..6f8ce6c 100644
@@ -612,7 +612,7 @@ static int ad7192_probe(struct spi_device *spi)
 	const struct ad7192_platform_data *pdata = spi->dev.platform_data;
 	struct ad7192_state *st;
 	struct iio_dev *indio_dev;
-	int ret , voltage_uv = 0;
+	int ret, voltage_uv = 0;
 
 	if (!pdata) {
 		dev_err(&spi->dev, "no platform data?\n");
drivers/staging/iio/meter/ade7759.c +1 -1
index 7d21743..b0c7dbc 100644
@@ -116,7 +116,7 @@ static int ade7759_spi_read_reg_40(struct device *dev,
 
 	mutex_lock(&st->buf_lock);
 	st->tx[0] = ADE7759_READ_REG(reg_address);
-	memset(&st->tx[1], 0 , 5);
+	memset(&st->tx[1], 0, 5);
 
 	ret = spi_sync_transfer(st->us, xfers, ARRAY_SIZE(xfers));
 	if (ret) {
Signature · 1 line
2.1.0
maintainer
#1 lore raw
Quoted 5 lines · Zachary Warren

Fixes:
drivers/staging/iio/adc/ad7192.c:615: ERROR: space prohibited before that ',' drivers/staging/iio/meter/ade7759.c:119: ERROR: space prohibited before that ','

Signed-off-by Zachary Warren <[email protected]>

Correctly formatted patch fixing a small issue - but, rare for for Eudyptula patches, one that isn't just a matter of taste.

Nicely done. Applied to the togreg branch iio.git, initially pushed out as testing because there is some other stuff in the tree that I'd like the autobuilders to stomp all over before pushing a non rebasable patch out.

Thanks,

Jonathan

Quoted 37 lines

---

This is for Eudyptula Challenge Task 10 which requires sending a checkpatch fix in linux-next drivers/staging to a maintainer and public mailing list. Apologies for mistakes and any inconvenience.

 drivers/staging/iio/adc/ad7192.c    | 2 +-
 drivers/staging/iio/meter/ade7759.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/iio/adc/ad7192.c +1 -1
index f6526aa..6f8ce6c 100644
@@ -612,7 +612,7 @@ static int ad7192_probe(struct spi_device *spi)
 	const struct ad7192_platform_data *pdata = spi->dev.platform_data;
 	struct ad7192_state *st;
 	struct iio_dev *indio_dev;
-	int ret , voltage_uv = 0;
+	int ret, voltage_uv = 0;
 
 	if (!pdata) {
 		dev_err(&spi->dev, "no platform data?\n");
drivers/staging/iio/meter/ade7759.c +1 -1
index 7d21743..b0c7dbc 100644
@@ -116,7 +116,7 @@ static int ade7759_spi_read_reg_40(struct device *dev,
 
 	mutex_lock(&st->buf_lock);
 	st->tx[0] = ADE7759_READ_REG(reg_address);
-	memset(&st->tx[1], 0 , 5);
+	memset(&st->tx[1], 0, 5);
 
 	ret = spi_sync_transfer(st->us, xfers, ARRAY_SIZE(xfers));
 	if (ret) {