Skip to contentSkip to conversation

FIX ME in xsysace.c

DISCUSSION nick 2 participants 4 messages Nov 24, 2014

lore
Share & tools
lore

nick

author
#0 lore raw

Greetings Michal and others,
I am wondering about the FIX ME in xsysace.c as it seems not correct due to my knowledge of most hardware protocols using a predetermined bit wide and therefore this could be hard coded. If someone can respond on if I am correct in removing this fix me it would be greatly appreciated. Cheers

#1 lore raw

Hi,

Quoted 2 lines · nick

Greetings Michal and others,
I am wondering about the FIX ME in xsysace.c as it seems not correct due to my knowledge of most hardware protocols using a predetermined bit wide and therefore this could be hard coded. If someone can respond on if I am correct in removing this fix me it would be greatly appreciated.

I think that will be the best to c&p that fixme which you are talking about. Definitely feel free to fix whatever fixme is there and send the patch for fixing it.

Thanks,
Michal

author
#2 lore raw
Quoted 6 lines · Michal Simek

Hi,

Quoted 2 lines · nick

Greetings Michal and others,
I am wondering about the FIX ME in xsysace.c as it seems not correct due to my knowledge of most hardware protocols using a predetermined bit wide and therefore this could be hard coded. If someone can respond on if I am correct in removing this fix me it would be greatly appreciated.

Quoted 7 lines

I think that will be the best to c&p that fixme which you are talking about. Definitely feel free to fix whatever fixme is there and send the patch for fixing it.

Thanks,
Michal

Here is the fix me.
int bus_width = ACE_BUS_WIDTH_16; /* FIXME: should not be hard coded */ Cheers Nick

#3 lore raw

Hi,

Quoted 13 lines · nick
Quoted 10 lines · Michal Simek

Hi,

Quoted 2 lines · nick

Greetings Michal and others,
I am wondering about the FIX ME in xsysace.c as it seems not correct due to my knowledge of most hardware protocols using a predetermined bit wide and therefore this could be hard coded. If someone can respond on if I am correct in removing this fix me it would be greatly appreciated.

I think that will be the best to c&p that fixme which you are talking about. Definitely feel free to fix whatever fixme is there and send the patch for fixing it.

Quoted 5 lines
Quoted 3 lines

Thanks,
Michal

Here is the fix me.
int bus_width = ACE_BUS_WIDTH_16; /* FIXME: should not be hard coded */

FIXME is totally bogus and should be removed.

I expect you want to use 8bit bus mode which driver itself supports. This line is just default setup to 16bit mode.

If you add 8-bit property to dts you are there.

	if (of_find_property(dev->dev.of_node, "8-bit", NULL))
		bus_width = ACE_BUS_WIDTH_8;

Thanks,
Michal