Skip to contentSkip to conversation

omap24xx/tcm825x: remove pointless Makefile entry

PATCH In review Paul Bolle 2 participants 3 messages Nov 24, 2014

Subsystems (2)
Media (V4L/DVB) Staging
lore
Share & tools
lore

Paul Bolle

author
#0 lore raw

PATCH 1/1 omap24xx/tcm825x: remove pointless Makefile entry

The deprecated omap2 camera drivers were recently removed. Both the Kconfig symbol VIDEO_TCM825X and the drivers/staging/media/omap24xx directory are gone. So the Makefile entry that references both is now pointless. Remove it too.

Signed-off-by Paul Bolle <[email protected]>

---
Tested by grepping the tree.

Triggered by commit db85a0403be4 ("[media] omap24xx/tcm825x: remove deprecated omap2 camera drivers."), which is included in next-20141124. What happened is that it removed only one of the two Makefile entries for omap24xx.

 drivers/staging/media/Makefile | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/media/Makefile +0 -1
index 97bfef97f838..30fb352fc4a9 100644
@@ -4,7 +4,6 @@ obj-$(CONFIG_LIRC_STAGING)	+= lirc/
 obj-$(CONFIG_VIDEO_DT3155)	+= dt3155v4l/
 obj-$(CONFIG_VIDEO_DM365_VPFE)	+= davinci_vpfe/
 obj-$(CONFIG_VIDEO_OMAP4)	+= omap4iss/
-obj-$(CONFIG_VIDEO_TCM825X)     += omap24xx/
 obj-$(CONFIG_DVB_MN88472)       += mn88472/
 obj-$(CONFIG_DVB_MN88473)       += mn88473/
Signature · 1 line
1.9.3
#1 lore raw

I found the same thing and it is already part of my pull request to Mauro.

I'm setting this patch as Obsoleted in patchwork.

It's unclear what happened. My original patch definitely removed both Makefile lines.

Regards,

Hans

Quoted 30 lines · Paul Bolle

The deprecated omap2 camera drivers were recently removed. Both the Kconfig symbol VIDEO_TCM825X and the drivers/staging/media/omap24xx directory are gone. So the Makefile entry that references both is now pointless. Remove it too.

Signed-off-by Paul Bolle <[email protected]>

---
Tested by grepping the tree.

Triggered by commit db85a0403be4 ("[media] omap24xx/tcm825x: remove deprecated omap2 camera drivers."), which is included in next-20141124. What happened is that it removed only one of the two Makefile entries for omap24xx.

 drivers/staging/media/Makefile | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/media/Makefile +0 -1
index 97bfef97f838..30fb352fc4a9 100644
@@ -4,7 +4,6 @@ obj-$(CONFIG_LIRC_STAGING)	+= lirc/
 obj-$(CONFIG_VIDEO_DT3155)	+= dt3155v4l/
 obj-$(CONFIG_VIDEO_DM365_VPFE)	+= davinci_vpfe/
 obj-$(CONFIG_VIDEO_OMAP4)	+= omap4iss/
-obj-$(CONFIG_VIDEO_TCM825X)     += omap24xx/
 obj-$(CONFIG_DVB_MN88472)       += mn88472/
 obj-$(CONFIG_DVB_MN88473)       += mn88473/
author
#2 lore raw
Quoted 2 lines · Hans Verkuil

I found the same thing and it is already part of my pull request to Mauro.

Either way, this trivial issue will be solved.

Thanks,

Paul Bolle