drivers:block Remove unneeded Fix me message in xsyace.c
PATCH 1/1 drivers:block Remove unneeded Fix me message in xsyace.c
Removes unneeded FIXME message related to using a hard coded value for ACE_BUS_WIDTH due to it needing to be 8 bits, this is wrong as this function here needs all 16 bits of the bus width and not just the lower or higher 16 depending on the machine's bit order.
--- drivers/block/xsysace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/block/xsysace.c +1 -1
@@ -1152,7 +1152,7 @@ static void ace_free(struct device *dev)static int ace_probe (struct platform_device *dev) {resource_size_t physaddr =0 ; -int bus_width =ACE_BUS_WIDTH_16 ;/* FIXME: should not be hard coded */ +int bus_width =ACE_BUS_WIDTH_16 ;u32 id = dev->id;int irq =0 ;int i;
Signature · 1 line
1.9.1
Quoted 16 lines · Nicholas Krause
Removes unneeded FIXME message related to using a hard coded value for
ACE_BUS_WIDTHdue to it needing to be 8 bits, this is wrong as this function here needs all 16 bits of the bus width and not just the lower or higher 16 depending on the machine's bit order.Signed-off-by Nicholas Krause <[email protected]>--- drivers/block/xsysace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/block/xsysace.c +0
-0
drivers/block/xsysace.c static void ace_free(struct device *dev) · line 1158
Quoted 8 lines
drivers/block/xsysace.c +1
-1@@ -1152,7 +1152,7 @@ static void ace_free(struct device *dev)static int ace_probe (struct platform_device *dev) {resource_size_t physaddr =0 ; -int bus_width =ACE_BUS_WIDTH_16 ;/* FIXME: should not be hard coded */ +int bus_width =ACE_BUS_WIDTH_16 ;u32 id = dev->id;int irq =0 ;int i;
Thanks,
Michal
Quoted 11 lines · Michal Simek
Quoted 10 lines · Nicholas Krause
Removes unneeded FIXME message related to using a hard coded value for
ACE_BUS_WIDTHdue to it needing to be 8 bits, this is wrong as this function here needs all 16 bits of the bus width and not just the lower or higher 16 depending on the machine's bit order.Signed-off-by Nicholas Krause <[email protected]>--- drivers/block/xsysace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 16 lines
Quoted 6 lines
drivers/block/xsysace.c +0
-0drivers/block/xsysace.c static void ace_free(struct device *dev) · line 1158
Quoted 8 lines
drivers/block/xsysace.c +1
-1@@ -1152,7 +1152,7 @@ static void ace_free(struct device *dev)static int ace_probe (struct platform_device *dev) {resource_size_t physaddr =0 ; -int bus_width =ACE_BUS_WIDTH_16 ;/* FIXME: should not be hard coded */ +int bus_width =ACE_BUS_WIDTH_16 ;u32 id = dev->id;int irq =0 ;int i;Reviewed-by Michal Simek <[email protected]>
I find the commit message rather misleading, but the change is OK.
S?ren
PATCH 1/1 drivers:block Remove unneeded Fix me message in xsyace.c
Soren,
If you want me to change it I would be glad, I wasn't sure what to write to be honest but if you have a better message in mind please let me known.
Cheers Nick
Quoted 33 lines · S?ren Brinkmann
Quoted 11 lines · Michal Simek
Quoted 10 lines · Nicholas Krause
Removes unneeded FIXME message related to using a hard coded value for
ACE_BUS_WIDTHdue to it needing to be 8 bits, this is wrong as this function here needs all 16 bits of the bus width and not just the lower or higher 16 depending on the machine's bit order.Signed-off-by Nicholas Krause <[email protected]>--- drivers/block/xsysace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 16 lines
Quoted 6 lines
drivers/block/xsysace.c +0
-0drivers/block/xsysace.c static void ace_free(struct device *dev) · line 1158
Quoted 8 lines
drivers/block/xsysace.c +1
-1@@ -1152,7 +1152,7 @@ static void ace_free(struct device *dev)static int ace_probe (struct platform_device *dev) {resource_size_t physaddr =0 ; -int bus_width =ACE_BUS_WIDTH_16 ;/* FIXME: should not be hard coded */ +int bus_width =ACE_BUS_WIDTH_16 ;u32 id = dev->id;int irq =0 ;int i;Reviewed-by Michal Simek <[email protected]>I find the commit message rather misleading, but the change is OK.
S?ren