Skip to contentSkip to conversation

bb.codeparser.py: Remove reference for oe.utils.contains

PATCH New Otavio Salvador 3 participants 6 messages Nov 12, 2014 – Nov 26, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 bb.codeparser.py: Remove reference for oe.utils.contains

The oe.utils.contains function has been removed from OE-Core metadata as the references for it has been replaced to use the bb.utils.contains.

---
 bitbake/lib/bb/codeparser.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
bitbake/lib/bb/codeparser.py +1 -1
index 8b8f91a..21a36f6 100644
@@ -178,7 +178,7 @@ class BufferedLogger(Logger):
 
 class PythonParser():
     getvars = (".getVar", ".appendVar", ".prependVar")
-    containsfuncs = ("bb.utils.contains", "base_contains", "oe.utils.contains", "bb.utils.contains_any")
+    containsfuncs = ("bb.utils.contains", "base_contains", "bb.utils.contains_any")
     execfuncs = ("bb.build.exec_func", "bb.build.exec_task")
 
     def warn(self, func, arg):
Signature · 1 line
2.1.1
#1 lore raw

PATCH 2/4 toolchain-scripts.bbclass: Export KCFLAGS to ensure sysroot is provided

When building the U-Boot the lack of a proper sysroot can trigger following error:

,----

| arm-poky-linux-gnueabi-ld.bfd: cannot find -lgcc
| make[2]: *** [examples/standalone/hello_world] Error 1
| make[1]: *** [examples/standalone] Error 2
| make: *** [examples] Error 2

`----

Guillaume Fournier has posted a very complete analysis of the problem[1].

1. https://lists.yoctoproject.org/pipermail/meta-freescale/2014-November/011270.html

The use of KCFLAGS makes the build of U-Boot work out of box, now that it uses the Linux kernel build system.

---
 meta/classes/toolchain-scripts.bbclass | 1 +
 1 file changed, 1 insertion(+)
meta/classes/toolchain-scripts.bbclass +1 -0
index 2244cf7..cf99c73 100644
@@ -68,6 +68,7 @@ toolchain_shared_env_script () {
 	echo 'export CXXFLAGS="${TARGET_CXXFLAGS}"' >> $script
 	echo 'export LDFLAGS="${TARGET_LDFLAGS}"' >> $script
 	echo 'export CPPFLAGS="${TARGET_CPPFLAGS}"' >> $script
+	echo 'export KCFLAGS="--sysroot=$SDKTARGETSYSROOT"' >> $script
 	echo 'export OECORE_DISTRO_VERSION="${DISTRO_VERSION}"' >> $script
 	echo 'export OECORE_SDK_VERSION="${SDK_VERSION}"' >> $script
 	echo 'export ARCH=${ARCH}' >> $script
Signature · 1 line
2.1.1
#2 lore raw

PATCH 3/4 sysvinit-inittab: Disable the carrier detect requirement for serial consoles

In reply to Otavio Salvador

This aligns the params of getty with the ones used in Debian. From the getty(8) manpage:

,----[ getty(8) manpage ]

|  -L, --local-line
|
|    Force the line to be a local line with no need for carrier
| 	 detect. This can be useful when you have a locally attached
| 	 terminal where the serial line does not set the carrier detect
| 	 signal.

`----

---
 meta/recipes-core/sysvinit/sysvinit-inittab_2.88dsf.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/sysvinit/sysvinit-inittab_2.88dsf.bb +1 -1
index c3244b4..657ef02 100644
@@ -23,7 +23,7 @@ do_install() {
     do
 	j=`echo ${i} | sed s/\;/\ /g`
 	label=`echo ${i} | sed -e 's/^.*;tty//' -e 's/;.*//'`
-	echo "$label:12345:respawn:${base_sbindir}/getty ${j}" >> ${D}${sysconfdir}/inittab
+	echo "$label:12345:respawn:${base_sbindir}/getty -L ${j}" >> ${D}${sysconfdir}/inittab
     done
 
     if [ "${USE_VT}" = "1" ]; then
Signature · 1 line
2.1.1
#3 lore raw

PATCH 3/4 sysvinit-inittab: Disable the carrier detect requirement for serial consoles

I see this patch has been committed in master. Could it be backported to dizzy?

This fixes a problem with some commands (for example busybox 'less' applet) that become unresponsive when used in a serial console on some hardware platforms (for example a FSL mx28).

A basic: 'less /etc/passwd' just hangs showing nothing and you can only stop it with CRTL-C.

As the backport seems pretty safe in general, could it be backported?

-
Regards,

Javier Viguera

#4 lore raw

Re: [dizzy backport] [PATCH 3/4] sysvinit-inittab: Disable the carrier detect requirement for serial consoles

Quoted 2 lines · Javier Viguera

I see this patch has been committed in master. Could it be backported to dizzy?

Will look into.

Quoted 9 lines

This fixes a problem with some commands (for example busybox 'less' applet) that become unresponsive when used in a serial console on some hardware platforms (for example a FSL mx28).

A basic: 'less /etc/passwd' just hangs showing nothing and you can only stop it with CRTL-C.

As the backport seems pretty safe in general, could it be backported?

sure.

- Armin

Quoted 5 lines

-
Regards,

Javier Viguera

#5 lore raw

PATCH 4/4 systemd-serialgetty: Disable the carrier detect requirement for serial consoles

In reply to Otavio Salvador

This aligns the params of getty with the ones used in Debian. From the getty(8) manpage:

,----[ getty(8) manpage ]

|  -L, --local-line
|
|    Force the line to be a local line with no need for carrier
|    detect. This can be useful when you have a locally attached
|    terminal where the serial line does not set the carrier detect
|    signal.

`----

---
 meta/recipes-core/systemd/systemd-serialgetty/[email protected] | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/systemd/systemd-serialgetty/[email protected] +1 -1
index 6dd335c..182167b 100644
@@ -21,7 +21,7 @@ IgnoreOnIsolate=yes
 
 [Service]
 Environment="TERM=xterm"
-ExecStart=-/sbin/agetty -8 --keep-baud %I @BAUDRATE@ $TERM
+ExecStart=-/sbin/agetty -8 -L --keep-baud %I @BAUDRATE@ $TERM
 Type=idle
 Restart=always
 RestartSec=0
Signature · 1 line
2.1.1