Skip to contentSkip to conversation

sunxi: Align PSCI stack calculation to comment

PATCH New Jan Kiszka 4 participants 5 messages Nov 27, 2014 – Dec 15, 2014

Subsystems (2)
Arm (32-bit) Arm/Allwinner sunXi SoC support
lore
Share & tools
lore

Jan Kiszka

author
#0 lore raw

PATCH 1/1 sunxi: Align PSCI stack calculation to comment

0x400 is true 1K.

Signed-off-by Jan Kiszka <[email protected]>

---

Hans, are you collecting sunxi-related patches? This is just a trivial one, there will be more.

 arch/arm/cpu/armv7/sunxi/psci.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/cpu/armv7/sunxi/psci.S +1 -1
index b9ea78b..a84807d 100644
@@ -68,7 +68,7 @@ psci_arch_init:
 
 	mrc	p15, 0, r4, c0, c0, 5	@ MPIDR
 	and	r4, r4, #3		@ cpu number in cluster
-	mov	r5, #400		@ 1kB of stack per CPU
+	mov	r5, #0x400		@ 1kB of stack per CPU
 	mul	r4, r4, r5
 
 	adr	r5, text_end		@ end of text
Signature · 1 line
1.8.4.5
#1 lore raw

PATCH 1/1 sunxi: Align PSCI stack calculation to comment

Quoted 17 lines · Jan Kiszka

0x400 is true 1K.

Signed-off-by Jan Kiszka <[email protected]>

---

Hans, are you collecting sunxi-related patches? This is just a trivial one, there will be more.

 arch/arm/cpu/armv7/sunxi/psci.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/cpu/armv7/sunxi/psci.S +0 -0
index b9ea78b..a84807d 100644

arch/arm/cpu/armv7/sunxi/psci.S psci_arch_init: · line 74

Quoted 8 lines
arch/arm/cpu/armv7/sunxi/psci.S +1 -1
@@ -68,7 +68,7 @@ psci_arch_init:
 
 	mrc	p15, 0, r4, c0, c0, 5	@ MPIDR
 	and	r4, r4, #3		@ cpu number in cluster
-	mov	r5, #400		@ 1kB of stack per CPU
+	mov	r5, #0x400		@ 1kB of stack per CPU
 	mul	r4, r4, r5
 
 	adr	r5, text_end		@ end of text

(with a brown paper bag on)

Acked-by Marc Zyngier <[email protected]>

Thanks,

	M.
Signature · 1 line
Jazz is not dead. It just smells funny...
#2 lore raw

PATCH 1/1 sunxi: Align PSCI stack calculation to comment

In reply to Jan Kiszka
Quoted 3 lines · Jan Kiszka

0x400 is true 1K.

Signed-off-by Jan Kiszka <[email protected]>

Thanks. Applied to u-boot-sunxi#next. I don't think this is so urgent as to require a PR for v2015.01 in its own right, but if we do one for another reason I think we should include this trivial fix. Hans, sound ok?

Quoted 2 lines

Hans, are you collecting sunxi-related patches? This is just a trivial one, there will be more.

Were there any more in the end? If yes then I've not seen them/can't find them. In general please CC both Hans and myself on sunxi patches.

Thanks,
Ian.

#3 lore raw

PATCH 1/1 sunxi: Align PSCI stack calculation to comment

Hi,

Quoted 9 lines · Ian Campbell
Quoted 3 lines · Jan Kiszka

0x400 is true 1K.

Signed-off-by Jan Kiszka <[email protected]>

Thanks. Applied to u-boot-sunxi#next. I don't think this is so urgent as to require a PR for v2015.01 in its own right, but if we do one for another reason I think we should include this trivial fix. Hans, sound ok?

Sounds fine to me.

Regards,

Hans

author
#4 lore raw

PATCH 1/1 sunxi: Align PSCI stack calculation to comment

In reply to Ian Campbell
Quoted 9 lines · Ian Campbell
Quoted 3 lines · Jan Kiszka

0x400 is true 1K.

Signed-off-by Jan Kiszka <[email protected]>

Thanks. Applied to u-boot-sunxi#next. I don't think this is so urgent as to require a PR for v2015.01 in its own right, but if we do one for another reason I think we should include this trivial fix. Hans, sound ok?

This is only a cosmetic fix.

Quoted 6 lines
Quoted 3 lines

Hans, are you collecting sunxi-related patches? This is just a trivial one, there will be more.

Were there any more in the end? If yes then I've not seen them/can't find them. In general please CC both Hans and myself on sunxi patches.

They got delayed. I only now finished full PSCI v0.2 support for the A20. Will CC you all when sending those out.

Jan

Signature · 2 lines
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux