Skip to contentSkip to conversation

mtd/nand/vf610_nfc: Disable subpage writes

PATCH New Sanchayan Maity 1 participant 2 messages Nov 24, 2014 – Nov 28, 2014

Subsystems (2)
Memory technology devices (MTD) NAND flash
lore
Share & tools
lore

Sanchayan Maity

author
#0 lore raw

PATCH 1/1 mtd/nand/vf610_nfc: Disable subpage writes

This patch disables subpage writes for vf610_nfc nand driver. This is required, as without this fix, writing unaligned u-boot images with DFU results in a hang. Trying to write unalgined binary images also results in a hang, without disabling subpage writes.

Patch has been tested on a Colibri VF61 module.

Signed-off-by Sanchayan Maity <[email protected]>
---
 drivers/mtd/nand/vf610_nfc.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/mtd/nand/vf610_nfc.c +3 -0
index 7feb3a7..928d58b 100644
@@ -611,6 +611,9 @@ static int vf610_nfc_nand_init(int devnum, void __iomem *addr)
 		vf610_nfc_clear(mtd, NFC_FLASH_CONFIG, CONFIG_16BIT);
 	}
 
+	/* Disable subpage writes as we do not provide ecc->hwctl */
+	chip->options |= NAND_NO_SUBPAGE_WRITE;
+
 	chip->dev_ready = vf610_nfc_dev_ready;
 	chip->cmdfunc = vf610_nfc_command;
 	chip->read_byte = vf610_nfc_read_byte;
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 1/1 mtd/nand/vf610_nfc: Disable subpage writes

Quoted 19 lines · Sanchayan Maity

This patch disables subpage writes for vf610_nfc nand driver. This is required, as without this fix, writing unaligned u-boot images with DFU results in a hang. Trying to write unalgined binary images also results in a hang, without disabling subpage writes.

Patch has been tested on a Colibri VF61 module.

Signed-off-by Sanchayan Maity <[email protected]>
---
 drivers/mtd/nand/vf610_nfc.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/mtd/nand/vf610_nfc.c +0 -0
index 7feb3a7..928d58b 100644

drivers/mtd/nand/vf610_nfc.c static int vf610_nfc_nand_init(int devnum, void __iomem *addr) · line 619

Quoted 9 lines
drivers/mtd/nand/vf610_nfc.c +3 -0
@@ -611,6 +611,9 @@ static int vf610_nfc_nand_init(int devnum, void __iomem *addr)
 		vf610_nfc_clear(mtd, NFC_FLASH_CONFIG, CONFIG_16BIT);
 	}
 
+	/* Disable subpage writes as we do not provide ecc->hwctl */
+	chip->options |= NAND_NO_SUBPAGE_WRITE;
+
 	chip->dev_ready = vf610_nfc_dev_ready;
 	chip->cmdfunc = vf610_nfc_command;
 	chip->read_byte = vf610_nfc_read_byte;

Ping?

-Regards,
Sanchayan.