Skip to contentSkip to conversation

thermal: imx_thermal: Do not display calibration data

PATCH New Fabio Estevam 2 participants 2 messages Nov 24, 2014 – Dec 1, 2014

Subsystems (2)
Arm i.MX and Layerscape Thermal
lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 thermal: imx_thermal: Do not display calibration data

Printing the calibration data on every boot does not provide really useful information:

U-Boot 2015.01-rc1-18266-ge7eb277 (Nov 24 2014 - 11:29:51)

CPU:   Freescale i.MX6Q rev1.2 at 792 MHz                                       
CPU:   Thermal calibration data: 0x5d85067d                                     
CPU:   Temperature 33 C                                                         
Reset cause: POR                                                                
Board: MX6-SabreSD

Do not display the calibration data in order to have a cleaner boot log.

Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/thermal/imx_thermal.c | 2 --
 1 file changed, 2 deletions(-)
drivers/thermal/imx_thermal.c +0 -2
index 1161585..0bd9cfd 100644
@@ -156,8 +156,6 @@ static int imx_thermal_probe(struct udevice *dev)
 	if (fuse == 0 || fuse == ~0) {
 		printf("CPU:   Thermal invalid data, fuse: 0x%x\n", fuse);
 		return -EPERM;
-	} else {
-		printf("CPU:   Thermal calibration data: 0x%x\n", fuse);
 	}
 
 	*priv = fuse;
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 thermal: imx_thermal: Do not display calibration data

Quoted 24 lines · Fabio Estevam

Printing the calibration data on every boot does not provide really useful information:

U-Boot 2015.01-rc1-18266-ge7eb277 (Nov 24 2014 - 11:29:51)

CPU:   Freescale i.MX6Q rev1.2 at 792 MHz                                       
CPU:   Thermal calibration data: 0x5d85067d                                     
CPU:   Temperature 33 C                                                         
Reset cause: POR                                                                
Board: MX6-SabreSD

Do not display the calibration data in order to have a cleaner boot log.

Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/thermal/imx_thermal.c | 2 --
 1 file changed, 2 deletions(-)
drivers/thermal/imx_thermal.c +0 -0
index 1161585..0bd9cfd 100644

drivers/thermal/imx_thermal.c static int imx_thermal_probe(struct udevice *dev) · line 161

Quoted 8 lines
drivers/thermal/imx_thermal.c +0 -2
@@ -156,8 +156,6 @@ static int imx_thermal_probe(struct udevice *dev)
 	if (fuse == 0 || fuse == ~0) {
 		printf("CPU:   Thermal invalid data, fuse: 0x%x\n", fuse);
 		return -EPERM;
-	} else {
-		printf("CPU:   Thermal calibration data: 0x%x\n", fuse);
 	}
 
 	*priv = fuse;

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================