Skip to contentSkip to conversation

ARM: dts: sabrelite I2C and HDMI additions

PATCH RESEND Superseded Eric Nelson 3 participants 7 messages Dec 2, 2014 – Dec 16, 2014

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Eric Nelson

author
#0 lore raw

cover ARM: dts: sabrelite I2C and HDMI additions

This set of patches adds support for I2C2/3 busses and HDMI output for the SABRE Lite board.

The content was gratuitously copied from the following commits for the Nitrogen6X board made by Lucas Stach, Michael Olbrich, and Philipp Zabel at Pengutronix:

	43c3c00 - ARM: dts: nitrogen6x: add i2c2
	d653620 - ARM: dts: nitrogen6x: add hdmi
	1dffdd6 - ARM: dts: nitrogen6x: add i2c3

Eric Nelson (3):
ARM: dts: sabrelite: add i2c2
ARM: dts: sabrelite: add hdmi
ARM: dts: sabrelite: add i2c3

 arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 33 ++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

Re-sending to add Shawn Guo to the CC list.

Signature · 1 line
1.9.1
author
#1 lore raw

PATCH RESEND 1/3 ARM: dts: sabrelite: add i2c2

Signed-off-by Eric Nelson <[email protected]>
---
 arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm/boot/dts/imx6qdl-sabrelite.dtsi +14 -0
index 0a36129..37f53f3 100644
@@ -188,6 +188,13 @@
 	};
 };
 
+&i2c2 {
+	clock-frequency = <100000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c2>;
+	status = "okay";
+};
+
 &iomuxc {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_hog>;

@@ -265,6 +272,13 @@
 			>;
 		};
 
+		pinctrl_i2c2: i2c2grp {
+			fsl,pins = <
+				MX6QDL_PAD_KEY_COL3__I2C2_SCL		0x4001b8b1
+				MX6QDL_PAD_KEY_ROW3__I2C2_SDA		0x4001b8b1
+			>;
+		};
+
 		pinctrl_pwm1: pwm1grp {
 			fsl,pins = <
 				MX6QDL_PAD_SD1_DAT3__PWM1_OUT 0x1b0b1
Signature · 1 line
1.9.1
author
#2 lore raw

PATCH RESEND 2/3 ARM: dts: sabrelite: add hdmi

In reply to Eric Nelson
Signed-off-by Eric Nelson <[email protected]>
---
 arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/imx6qdl-sabrelite.dtsi +5 -0
index 37f53f3..3bddc8f 100644
@@ -173,6 +173,11 @@
 	status = "okay";
 };
 
+&hdmi {
+	ddc-i2c-bus = <&i2c2>;
+	status = "okay";
+};
+
 &i2c1 {
 	clock-frequency = <100000>;
 	pinctrl-names = "default";
Signature · 1 line
1.9.1
author
#3 lore raw

PATCH RESEND 3/3 ARM: dts: sabrelite: add i2c3

In reply to Eric Nelson
Signed-off-by Eric Nelson <[email protected]>
---
 arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm/boot/dts/imx6qdl-sabrelite.dtsi +14 -0
index 3bddc8f..0b28a9d 100644
@@ -200,6 +200,13 @@
 	status = "okay";
 };
 
+&i2c3 {
+	clock-frequency = <100000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c3>;
+	status = "okay";
+};
+
 &iomuxc {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_hog>;

@@ -284,6 +291,13 @@
 			>;
 		};
 
+		pinctrl_i2c3: i2c3grp {
+			fsl,pins = <
+				MX6QDL_PAD_GPIO_5__I2C3_SCL		0x4001b8b1
+				MX6QDL_PAD_GPIO_16__I2C3_SDA		0x4001b8b1
+			>;
+		};
+
 		pinctrl_pwm1: pwm1grp {
 			fsl,pins = <
 				MX6QDL_PAD_SD1_DAT3__PWM1_OUT 0x1b0b1
Signature · 1 line
1.9.1
#4 lore raw

cover ARM: dts: sabrelite I2C and HDMI additions

In reply to Eric Nelson

Eric, All,

Quoted 16 lines · Eric Nelson

This set of patches adds support for I2C2/3 busses and HDMI output for the SABRE Lite board.

The content was gratuitously copied from the following commits for the Nitrogen6X board made by Lucas Stach, Michael Olbrich, and Philipp Zabel at Pengutronix:

        43c3c00 - ARM: dts: nitrogen6x: add i2c2
        d653620 - ARM: dts: nitrogen6x: add hdmi
        1dffdd6 - ARM: dts: nitrogen6x: add i2c3

Eric Nelson (3):
ARM: dts: sabrelite: add i2c2
ARM: dts: sabrelite: add hdmi
ARM: dts: sabrelite: add i2c3

Quoted 8 lines
 arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 33 ++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

Re-sending to add Shawn Guo to the CC list.

--
1.9.1

Tested on a SabreLite (iMX6q rev1.2), it works great once the ldb node is removed from imx6qdl-sabrelite.dtsi.
It is to be noted that I've applied the patches on top of the linux-stable tree. Eric, are you using Shawn's tree? I'll try with that latter to see if I can keep both ldb and hdmi nodes at the same time.

Thanks,
Gary

author
#5 lore raw

cover ARM: dts: sabrelite I2C and HDMI additions

Hi Gary,

Quoted 29 lines · Gary Bisson

Eric, All,

Quoted 16 lines · Eric Nelson

This set of patches adds support for I2C2/3 busses and HDMI output for the SABRE Lite board.

The content was gratuitously copied from the following commits for the Nitrogen6X board made by Lucas Stach, Michael Olbrich, and Philipp Zabel at Pengutronix:

        43c3c00 - ARM: dts: nitrogen6x: add i2c2
        d653620 - ARM: dts: nitrogen6x: add hdmi
        1dffdd6 - ARM: dts: nitrogen6x: add i2c3

Eric Nelson (3):
ARM: dts: sabrelite: add i2c2
ARM: dts: sabrelite: add hdmi
ARM: dts: sabrelite: add i2c3

Quoted 8 lines
 arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 33 ++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

Re-sending to add Shawn Guo to the CC list.

--
1.9.1

Quoted 7 lines

Tested on a SabreLite (iMX6q rev1.2), it works great once the ldb node is removed from imx6qdl-sabrelite.dtsi.
It is to be noted that I've applied the patches on top of the linux-stable tree. Eric, are you using Shawn's tree? I'll try with that latter to see if I can keep both ldb and hdmi nodes at the same time.

The patches were generated based on Shawn's imx/dt branch, but I also tested against linux-stable.

I didn't need to remove the LDB node in either case. HDMI just worked.

Regards,

Eric

Applied
#6 lore raw

cover ARM: dts: sabrelite I2C and HDMI additions

In reply to Eric Nelson
Quoted 4 lines · Eric Nelson

Eric Nelson (3):
ARM: dts: sabrelite: add i2c2
ARM: dts: sabrelite: add hdmi
ARM: dts: sabrelite: add i2c3

Applied all, thanks.