Skip to contentSkip to conversation

tools/kwboot: Allow just -t to function

PATCH New Suriyan Ramasami 2 participants 3 messages Nov 25, 2014 – Dec 4, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools/kwboot: Allow just -t to function

When kwboot is invoked with -t <tty> the code implicitly assumes that one of -b (boot message) or -d (debug message) with an image file is specified. This is not necessarily true.

This allows kwboot -t <tty> to function.

---

Changes in v1:
- First try

 tools/kwboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/kwboot.c +1 -1
index 1368b4c..449564e 100644
@@ -785,7 +785,7 @@ main(int argc, char **argv)
 			perror("debugmsg");
 			goto out;
 		}
-	} else {
+	} else if (bootmsg) {
 		rc = kwboot_bootmsg(tty, bootmsg);
 		if (rc) {
 			perror("bootmsg");
Signature · 1 line
1.8.3.1
#1 lore raw

PATCH 1/1 tools/kwboot: Allow just -t to function

Just a gentle ping to see if this can be commented on/Acked/Merged ? Thanks
- Suiryan

Quoted 31 lines · Suriyan Ramasami

When kwboot is invoked with -t <tty> the code implicitly assumes that one of -b (boot message) or -d (debug message) with an image file is specified. This is not necessarily true.

This allows kwboot -t <tty> to function.

---

Changes in v1:
- First try

 tools/kwboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/kwboot.c +1 -2
index 1368b4c..449564e 100644
@@ -785,7 +785,7 @@ main(int argc, char **argv)
                        perror("debugmsg");
                        goto out;
                }
-       } else {
+       } else if (bootmsg) {
                rc = kwboot_bootmsg(tty, bootmsg);
                if (rc) {
                        perror("bootmsg");
--

1.8.3.1