ARM:dts:sun7i:ps2 added nodes for Sun7i A20 PS2 controller. added ps2 nodes in lime2 board dts.
Subsystems (2)
PATCH 3/3 ARM:dts:sun7i:ps2 added nodes for Sun7i A20 PS2 controller. added ps2 nodes in lime2 board dts.
--- arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 10 ++++++++ arch/arm/boot/dts/sun7i-a20.dtsi | 30 ++++++++++++++++++++++- 2 files changed, 39 insertions(+), 1 deletion(-)
arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts +10 -0
@@ -112,6 +112,16 @@ pinctrl-0 = <&uart0_pins_a>; status = "okay"; }; + ps20: ps2 at 0x01c2a000 { + pinctrl-names = "default"; + pinctrl-0 = <&ps2_0_pins>; + status = "okay"; + }; + ps21: ps2 at 0x01c2a400 { + pinctrl-names = "default"; + pinctrl-0 = <&ps2_1_pins>; + status = "okay"; + }; i2c0: i2c at 01c2ac00 { pinctrl-names = "default";
arch/arm/boot/dts/sun7i-a20.dtsi +29 -1
@@ -357,7 +357,7 @@ usb_clk: clk at 01c200cc { #clock-cells = <1>; - #reset-cells = <1>; + #reset-cells = <1>; compatible = "allwinner,sun4i-a10-usb-clk"; reg = <0x01c200cc 0x4>; clocks = <&pll6 1>;
@@ -852,6 +852,19 @@ allwinner,drive = <0>; allwinner,pull = <0>; }; + ps2_0_pins: ps2_0 at 0 { + allwinner,pins = "PI20","PI21"; + allwinner,function = "ps2"; + allwinner,drive = <0>; + allwinner,pull = <0>; + }; + ps2_1_pins: ps2_1 at 0 { + allwinner,pins = "PH12","PH13"; + allwinner,function = "ps2"; + allwinner,drive = <0>; + allwinner,pull = <0>; + }; + }; timer at 01c20c00 {
@@ -1079,5 +1092,20 @@ #interrupt-cells = <3>; interrupts = <1 9 0xf04>; }; + ps20: ps2 at 0x01c2a000 { + compatible = "allwinner,sun7i-a20-ps2"; + reg = <0x01c2a000 0x400>; + interrupts = <0 62 4>; + clocks = <&apb1_gates 6>; + status = "disabled"; + }; + ps21: ps2 at 0x01c2a400 { + compatible = "allwinner,sun7i-a20-ps2"; + reg = <0x01c2a400 0x400>; + interrupts = <0 63 4>; + clocks = <&apb1_gates 7>; + status = "disabled"; + }; + }; };
Signature · 1 line
1.7.9.5
PATCH 3/3 ARM:dts:sun7i:ps2 added nodes for Sun7i A20 PS2 controller. added ps2 nodes in lime2 board dts.
Hi,
Quoted 13 lines · vishnupatekar
--- arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 10 ++++++++ arch/arm/boot/dts/sun7i-a20.dtsi | 30 ++++++++++++++++++++++- 2 files changed, 39 insertions(+), 1 deletion(-)arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts +0
-0@@ -112,6 +112,16 @@ pinctrl-0 = <&uart0_pins_a>; status = "okay"; };
arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts line 124
Quoted 10 lines
arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts +10
-0+ ps20: ps2 at 0x01c2a000 { + pinctrl-names = "default"; + pinctrl-0 = <&ps2_0_pins>; + status = "okay"; + }; + ps21: ps2 at 0x01c2a400 { + pinctrl-names = "default"; + pinctrl-0 = <&ps2_1_pins>; + status = "okay"; + };
I don't think this should be enabled by default, since there is no ps2 connector on the board, and the pins can be used in a different manner too.
I do think it is useful to have it in there as an example for people who want to use it, but commented out, please also add a comment stating that using ps20 conflicts with using the hdmi connector.
Regards,
Hans
Quoted 58 lines
arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts +0
-0i2c0: i2c at 01c2ac00 { pinctrl-names = "default";arch/arm/boot/dts/sun7i-a20.dtsi +29
-1@@ -357,7 +357,7 @@ usb_clk: clk at 01c200cc { #clock-cells = <1>; - #reset-cells = <1>; + #reset-cells = <1>; compatible = "allwinner,sun4i-a10-usb-clk"; reg = <0x01c200cc 0x4>; clocks = <&pll6 1>;@@ -852,6 +852,19 @@ allwinner,drive = <0>; allwinner,pull = <0>; }; + ps2_0_pins: ps2_0 at 0 { + allwinner,pins = "PI20","PI21"; + allwinner,function = "ps2"; + allwinner,drive = <0>; + allwinner,pull = <0>; + }; + ps2_1_pins: ps2_1 at 0 { + allwinner,pins = "PH12","PH13"; + allwinner,function = "ps2"; + allwinner,drive = <0>; + allwinner,pull = <0>; + }; + }; timer at 01c20c00 {@@ -1079,5 +1092,20 @@ #interrupt-cells = <3>; interrupts = <1 9 0xf04>; }; + ps20: ps2 at 0x01c2a000 { + compatible = "allwinner,sun7i-a20-ps2"; + reg = <0x01c2a000 0x400>; + interrupts = <0 62 4>; + clocks = <&apb1_gates 6>; + status = "disabled"; + }; + ps21: ps2 at 0x01c2a400 { + compatible = "allwinner,sun7i-a20-ps2"; + reg = <0x01c2a400 0x400>; + interrupts = <0 63 4>; + clocks = <&apb1_gates 7>; + status = "disabled"; + }; + }; };
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 26 lines · Hans de Goede
Hi,
Quoted 22 lines · vishnupatekar
--- arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 10 ++++++++ arch/arm/boot/dts/sun7i-a20.dtsi | 30 ++++++++++++++++++++++- 2 files changed, 39 insertions(+), 1 deletion(-)arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts +7
-0@@ -112,6 +112,16 @@ pinctrl-0 = <&uart0_pins_a>; status = "okay"; }; + ps20: ps2@0x01c2a000 { + pinctrl-names = "default"; + pinctrl-0 = <&ps2_0_pins>; + status = "okay"; + }; + ps21: ps2@0x01c2a400 { + pinctrl-names = "default";
Quoted 9 lines
arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts line 125
Quoted 4 lines
arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts +3
-0+ pinctrl-0 = <&ps2_1_pins>; + status = "okay"; + };I don't think this should be enabled by default, since there is no ps2 connector on the board, and the pins can be used in a different manner too.
I do think it is useful to have it in there as an example for people who
Quoted 6 lines
want to use
it, but commented out, please also add a comment stating that using ps20 conflicts
with using the hdmi connector.Okie, For lime2 board dts file, I'll comment out these ps20 and ps21 nodes
stating that In case uncommented this will confilt with hdmi connector.
This also will be included in next patch version.
Quoted 65 lines
Regards,
Hans
Quoted 59 lines
arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts +0
-0i2c0: i2c@01c2ac00 { pinctrl-names = "default";arch/arm/boot/dts/sun7i-a20.dtsi +29
-1@@ -357,7 +357,7 @@ usb_clk: clk@01c200cc { #clock-cells = <1>; - #reset-cells = <1>; + #reset-cells = <1>; compatible = "allwinner,sun4i-a10-usb-clk"; reg = <0x01c200cc 0x4>; clocks = <&pll6 1>;@@ -852,6 +852,19 @@ allwinner,drive = <0>; allwinner,pull = <0>; }; + ps2_0_pins: ps2_0@0 { + allwinner,pins = "PI20","PI21"; + allwinner,function = "ps2"; + allwinner,drive = <0>; + allwinner,pull = <0>; + }; + ps2_1_pins: ps2_1@0 { + allwinner,pins = "PH12","PH13"; + allwinner,function = "ps2"; + allwinner,drive = <0>; + allwinner,pull = <0>; + }; + }; timer@01c20c00 {@@ -1079,5 +1092,20 @@ #interrupt-cells = <3>; interrupts = <1 9 0xf04>; }; + ps20: ps2@0x01c2a000 { + compatible = "allwinner,sun7i-a20-ps2"; + reg = <0x01c2a000 0x400>; + interrupts = <0 62 4>; + clocks = <&apb1_gates 6>; + status = "disabled"; + }; + ps21: ps2@0x01c2a400 { + compatible = "allwinner,sun7i-a20-ps2"; + reg = <0x01c2a400 0x400>; + interrupts = <0 63 4>; + clocks = <&apb1_gates 7>; + status = "disabled"; + }; + }; };
Signature · 3 lines
You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/[email protected] For more options, visit https://groups.google.com/d/optout.