Skip to contentSkip to conversation

km/km82xx: remove CONFIG_SYS_RAMBOOT

PATCH New Holger Brunck 2 participants 2 messages Nov 6, 2014 – Dec 5, 2014

lore
Share & tools
lore

Holger Brunck

author
#0 lore raw

PATCH 1/1 km/km82xx: remove CONFIG_SYS_RAMBOOT

This define is never set in our setup, so we can remove it safely. The former code causes cppcheck to complain about:
[board/keymile/km82xx/km82xx.c:311]: (error) Uninitialized variable:
psize

Signed-off-by Holger Brunck <[email protected]>
cc Valentin Longchamp <[email protected]>
cc Wolfgang Denk <[email protected]>
---
 board/keymile/km82xx/km82xx.c | 2 --
 include/configs/km82xx.h      | 3 ---
 2 files changed, 5 deletions(-)
board/keymile/km82xx/km82xx.c +0 -2
index dfbfab8..cb13a0b 100644
@@ -300,11 +300,9 @@ phys_size_t initdram(int board_type)
 	out_8(&memctl->memc_psrt, CONFIG_SYS_PSRT);
 	out_be16(&memctl->memc_mptpr, CONFIG_SYS_MPTPR);
 
-#ifndef CONFIG_SYS_RAMBOOT
 	/* 60x SDRAM setup:
 	 */
 	psize = probe_sdram(memctl);
-#endif /* CONFIG_SYS_RAMBOOT */
 
 	icache_enable();
include/configs/km82xx.h +0 -3
index 029c348..220975d 100644
@@ -204,9 +204,6 @@
 	""
 
 #define CONFIG_SYS_MONITOR_BASE	CONFIG_SYS_TEXT_BASE
-#if (CONFIG_SYS_MONITOR_BASE < CONFIG_SYS_FLASH_BASE)
-#define CONFIG_SYS_RAMBOOT
-#endif
 
 #define CONFIG_SYS_MONITOR_LEN		(768 << 10)
Signature · 1 line
2.1.2
#1 lore raw

PATCH 1/1 km/km82xx: remove CONFIG_SYS_RAMBOOT

Quoted 9 lines · Holger Brunck

This define is never set in our setup, so we can remove it safely. The former code causes cppcheck to complain about:
[board/keymile/km82xx/km82xx.c:311]: (error) Uninitialized variable:
psize

Signed-off-by Holger Brunck <[email protected]>
cc Valentin Longchamp <[email protected]>
cc Wolfgang Denk <[email protected]>

---

Applied to u-boot-mpc85xx, awaiting upstream.

York