sunvnet: fix incorrect rcu_read_unlock() in vnet_start_xmit()
Subsystems (2)
PATCH 1/1 sunvnet: fix incorrect rcu_read_unlock() in vnet_start_xmit()
This patch removes an extra rcu_read_unlock() on an allocation failure in vnet_skb_shape(). The needed rcu_read_unlock() is already done in the out_dropped label.
Reported-by Rashmi Narasimhan <[email protected]>
Signed-off-by David L Stevens <[email protected]>
--- drivers/net/ethernet/sun/sunvnet.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
drivers/net/ethernet/sun/sunvnet.c +1 -3
@@ -1317,10 +1317,8 @@ static int vnet_start_xmit(struct sk_buff *skb, struct net_device *dev) skb =vnet_skb_shape (skb,2 ); -if (unlikely (!skb)) { -rcu_read_unlock (); +if (unlikely (!skb)) goto out_dropped; - }if (skb->ip_summed ==CHECKSUM_PARTIAL )vnet_fullcsum (skb);
Signature · 1 line
1.7.1
From: David L Stevens <[email protected]>
Date: Mon, 08 Dec 2014 21:46:09 -0500
Quoted 6 lines
This patch removes an extra
rcu_read_unlock()on an allocation failure invnet_skb_shape(). The neededrcu_read_unlock()is already done in theout_droppedlabel.Reported-by Rashmi Narasimhan <[email protected]>Signed-off-by David L Stevens <[email protected]>
Applied, thanks.