package/nmap: fix shared-only build
PATCH 1/1 package/nmap: fix shared-only build
Changeset f1d3e09 (Build shared libraries only as the default) broke the nmap package.
nmap builds an internal version of libdnet, and tries to statically link against it. Of course, this breaks for shared-only builds, since in that case there is no static lib ever built.
Using an external libdnet is not really an option:
- libdnet comes from dnprogs, from the linux-decnet project; unfortunately, their build-system is not ammenable to cross-compilation, and is a real pain to deal with;
- nmap's bundled libdnet is anyway heavily modified, which precludes using an external libdnet.
Fix that by considering libdnet to be a purely internal library, and by configuring it with --enable-static, always.
nmap's ./configure uses AC_CONFIG_SUBDIRS() to configure the libdnet sub-directory; AC_CONFIG_SUBDIRS() calls ./configure in all the sub-directories it is passed as arguments. Unfortunately, it is not possible to specify extra ./configure arguments whith AC_CONFIG_SUBDIRS.
We are using an autoconf trick, which is, when configuring sub-directories with AC_CONFIG_SUBDIRS(), it will first try to execute configure.gnu if it exists, before it fallbacks to running plain configure. See:
https://www.gnu.org/software/autoconf/manual/autoconf.html#Subdirectories
So, we provide a configure.gnu that is just a wrapper around the real configure, which sole purpose is to append --enable-static when calling the real configure.
Note1: since this libdnet is considered a purely internal library, we also always pass --disable-shared, since it is not needed at all.
Note2: since this libdnet is considered a purely internal library, it should not be exposed to other packages, and thus nmap does not install it, neither in target nor in staging, neither static nor shared, which is what we want.
--- package/nmap/0001-libdnet-wrapper-configure.patch | 11 +++++++++++ package/nmap/nmap.mk | 5 +++++ 2 files changed, 16 insertions(+) create mode 100644 package/nmap/0001-libdnet-wrapper-configure.patch
package/nmap/0001-libdnet-wrapper-configure.patch new file +11 -0
@@ -0,0 +1,11 @@ +libdnet: always build a static library + +Signed-off-by: "Yann E. MORIN" <[email protected]> + +diff --git a/libdnet-stripped/configure.gnu b/libdnet-stripped/configure.gnu +--- /dev/null ++++ b/libdnet-stripped/configure.gnu +@@ -0,0 +1,3 @@ ++#!/bin/sh ++ ++exec "${0%.gnu}" "${@}" --enable-static --disable-shared
package/nmap/nmap.mk +5 -0
@@ -14,6 +14,11 @@ NMAP_CONF_OPTS = --without-liblua --without-zenmap \ NMAP_LICENSE = GPLv2 NMAP_LICENSE_FILES = COPYING +define NMAP_WRAPPER_EXEC + chmod +x $(@D)/libdnet-stripped/configure.gnu +endef +NMAP_POST_PATCH_HOOKS += NMAP_WRAPPER_EXEC + ifeq ($(BR2_PACKAGE_OPENSSL),y) NMAP_CONF_OPTS += --with-openssl="$(STAGING_DIR)/usr" NMAP_DEPENDENCIES += openssl
Signature · 1 line
1.9.1
PATCH 1/1 package/nmap: fix shared-only build
Hi Yann, all,
Le 14/12/2014 12:51, Yann E. MORIN a ?crit :
Quoted 11 lines
Changeset f1d3e09 (Build shared libraries only as the default) broke the nmap package.
nmap builds an internal version of libdnet, and tries to statically link against it. Of course, this breaks for shared-only builds, since in that case there is no static lib ever built.
Using an external libdnet is not really an option:
- libdnet comes from dnprogs, from the linux-decnet project; unfortunately, their build-system is not ammenable to
s/ammenable/amenable
Quoted 26 lines
cross-compilation, and is a real pain to deal with;- nmap's bundled libdnet is anyway heavily modified, which precludes using an external libdnet.
Fix that by considering libdnet to be a purely internal library, and by configuring it with --enable-static, always.
nmap's ./configure uses
AC_CONFIG_SUBDIRS()to configure the libdnet sub-directory;AC_CONFIG_SUBDIRS()calls ./configure in all the sub-directories it is passed as arguments. Unfortunately, it is not possible to specify extra ./configure arguments whithAC_CONFIG_SUBDIRS.We are using an autoconf trick, which is, when configuring sub-directories with
AC_CONFIG_SUBDIRS(), it will first try to execute configure.gnu if it exists, before it fallbacks to running plain configure. See:
https://www.gnu.org/software/autoconf/manual/autoconf.html#SubdirectoriesSo, we provide a configure.gnu that is just a wrapper around the real configure, which sole purpose is to append --enable-static when calling the real configure.
Note1: since this libdnet is considered a purely internal library, we also always pass --disable-shared, since it is not needed at all.
Quoted 8 lines
Note2: since this libdnet is considered a purely internal library, it should not be exposed to other packages, and thus nmap does not install it, neither in target nor in staging, neither static nor shared, which is what we want.
Signed-off-by "Yann E. MORIN" <[email protected]>Cc Romain Naour <[email protected]>---
Thanks for your help during investigation about this issue.
Indeed, the static build for libdnet must forced for shared-only case.
On my side, I tried to use an external liblinear library instead of the bundled one. It appears that the nmap's external liblinear library support is broken and never tested. Also bundled liblinear contains some modifications to be able to build a static library.
But, as you said, since nmap properly builds liblinear, there's no reason to package it in Buildroot for now.
So, liblinear like libdnet, must be considered as a purely internal library.
Best regards,
Signature · 8 lines
Romain Naour OPEN WIDE Ing?nierie - Paris 23/25, rue Daviel| 75013 PARIS http://ingenierie.openwide.fr Le blog des technologies libres et embarqu?es : http://www.linuxembedded.fr
PATCH 1/1 package/nmap: fix shared-only build
In reply to Yann E. MORINQuoted 54 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Yann" == Yann E MORIN <[email protected]> writes:
Changeset f1d3e09 (Build shared libraries only as the default) broke the nmap package.
nmap builds an internal version of libdnet, and tries to statically link against it. Of course, this breaks for shared-only builds, since in that case there is no static lib ever built.
Using an external libdnet is not really an option:
- libdnet comes from dnprogs, from the linux-decnet project; unfortunately, their build-system is not ammenable to cross-compilation, and is a real pain to deal with;
- nmap's bundled libdnet is anyway heavily modified, which precludes using an external libdnet.
Fix that by considering libdnet to be a purely internal library, and by configuring it with --enable-static, always.
nmap's ./configure uses
AC_CONFIG_SUBDIRS()to configure the libdnet sub-directory;AC_CONFIG_SUBDIRS()calls ./configure in all the sub-directories it is passed as arguments. Unfortunately, it is not possible to specify extra ./configure arguments whithAC_CONFIG_SUBDIRS.We are using an autoconf trick, which is, when configuring sub-directories with
AC_CONFIG_SUBDIRS(), it will first try to execute configure.gnu if it exists, before it fallbacks to running plain configure. See:
https://www.gnu.org/software/autoconf/manual/autoconf.html#SubdirectoriesSo, we provide a configure.gnu that is just a wrapper around the real configure, which sole purpose is to append --enable-static when calling the real configure.
Note1: since this libdnet is considered a purely internal library, we also always pass --disable-shared, since it is not needed at all.
Note2: since this libdnet is considered a purely internal library, it should not be exposed to other packages, and thus nmap does not install it, neither in target nor in staging, neither static nor shared, which is what we want.
Signed-off-by "Yann E. MORIN" <[email protected]>Cc Romain Naour <[email protected]>--- package/nmap/0001-libdnet-wrapper-configure.patch | 11 +++++++++++ package/nmap/nmap.mk | 5 +++++ 2 files changed, 16 insertions(+) create mode 100644 package/nmap/0001-libdnet-wrapper-configure.patch+++
b/package/nmap/nmap.mk
package/nmap/nmap.mk NMAP_CONF_OPTS = --without-liblua --without-zenmap \ · line 15
Quoted 2 lines
package/nmap/nmap.mk +0
-0@@ -14,6 +14,11 @@ NMAP_CONF_OPTS = --without-liblua --without-zenmap \ NMAP_LICENSE = GPLv2 NMAP_LICENSE_FILES = COPYING
I added a comment explaining why we're doing this. It would be nice if patch / apply-patches.sh would learn the git permissions / rename handling extensions.
Committed with this and the typo pointed out by Romain fixed, thanks.
Signature · 1 line
Bye, Peter Korsgaard