platform/x86/acerhdf: still depends on THERMAL
PATCH 1/1 platform/x86/acerhdf: still depends on THERMAL
From: Randy Dunlap <[email protected]>
acerhdf uses thermal interfaces so it should depend on THERMAL. It also should not select a thermal driver without checking that THERMAL is enabled.
This fixes the following build errors when THERMAL=m and ACERHDF=y.
drivers/built-in.o: In function `acerhdf_set_mode':
acerhdf.c:(.text+0x3e02e1): undefined reference to thermal_zone_device_update' drivers/built-in.o: In function acerhdf_unbind':
acerhdf.c:(.text+0x3e052d): undefined reference to thermal_zone_unbind_cooling_device' drivers/built-in.o: In function acerhdf_bind':
acerhdf.c:(.text+0x3e0593): undefined reference to thermal_zone_bind_cooling_device' drivers/built-in.o: In function acerhdf_init':
acerhdf.c:(.init.text+0x1c2f5): undefined reference to thermal_cooling_device_register' acerhdf.c:(.init.text+0x1c360): undefined reference to thermal_zone_device_register' drivers/built-in.o: In function `acerhdf_unregister_thermal':
acerhdf.c:(.text.unlikely+0x3c67): undefined reference to thermal_cooling_device_unregister' acerhdf.c:(.text.unlikely+0x3c91): undefined reference to thermal_zone_device_unregister'
--- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/Kconfig +1 -1
@@ -38,8 +38,8 @@ config ACER_WMI config ACERHDF tristate "Acer Aspire One temperature and fan driver" + depends on ACPI && THERMAL select THERMAL_GOV_BANG_BANG - depends on ACPI ---help--- This is a driver for Acer Aspire One netbooks. It allows to access the temperature sensor and to control the fan.
Quoted 32 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
acerhdf uses thermal interfaces so it should depend on THERMAL. It also should not select a thermal driver without checking that THERMAL is enabled.
This fixes the following build errors when THERMAL=m and ACERHDF=y.
drivers/built-in.o: In function `acerhdf_set_mode':
acerhdf.c:(.text+0x3e02e1): undefined reference tothermal_zone_device_update' drivers/built-in.o: In functionacerhdf_unbind':
acerhdf.c:(.text+0x3e052d): undefined reference tothermal_zone_unbind_cooling_device' drivers/built-in.o: In functionacerhdf_bind':
acerhdf.c:(.text+0x3e0593): undefined reference tothermal_zone_bind_cooling_device' drivers/built-in.o: In functionacerhdf_init':
acerhdf.c:(.init.text+0x1c2f5): undefined reference tothermal_cooling_device_register' acerhdf.c:(.init.text+0x1c360): undefined reference tothermal_zone_device_register'drivers/built-in.o: In function `acerhdf_unregister_thermal':
acerhdf.c:(.text.unlikely+0x3c67): undefined reference tothermal_cooling_device_unregister' acerhdf.c:(.text.unlikely+0x3c91): undefined reference tothermal_zone_device_unregister'Signed-off-by Randy Dunlap <[email protected]>Cc Peter Feuerer <[email protected]>Cc Darren Hart <[email protected]>--- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/Kconfig config ACER_WMI · line 45
Quoted 9 lines
drivers/platform/x86/Kconfig +1
-1@@ -38,8 +38,8 @@ config ACER_WMI config ACERHDF tristate "Acer Aspire One temperature and fan driver" + depends on ACPI && THERMAL select THERMAL_GOV_BANG_BANG - depends on ACPI ---help--- This is a driver for Acer Aspire One netbooks. It allows to access the temperature sensor and to control the fan.
Thanks.
--peter;
Quoted 8 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
acerhdf uses thermal interfaces so it should depend on THERMAL. It also should not select a thermal driver without checking that THERMAL is enabled.
This fixes the following build errors when THERMAL=m and ACERHDF=y.
Thank you Randy, I'll include this in my pull request later this week. Now in for-next.
Signature · 2 lines
Darren Hart Intel Open Source Technology Center