configure: Fix for --with-initrd=no
PATCH 1/1 configure: Fix for --with-initrd=no
Our configure.ac script wasn't handle --with-initrd=no, when this was passed, we got error:
...
aarch64-linux-gnu-ld -o linux-system.axf --script=model.lds
aarch64-linux-gnu-ld: cannot find no
make: *** [linux-system.axf] Error 1
Fix this by adding a line to check this.
And this also fixed --without-initrd.
--- configure.ac | 1 + 1 file changed, 1 insertion(+)
configure.ac +1 -0
@@ -58,6 +58,7 @@ AC_SUBST([CPU_IDS], [$C_CPU_IDS]) AC_ARG_WITH([initrd], AS_HELP_STRING([--with-initrd], [embed an initrd in the kernel image]), USE_INITRD=$withval) +AS_IF([test "x$USE_INITRD" = "xno"], [USE_INITRD=], []) AC_SUBST([FILESYSTEM], [$USE_INITRD]) AM_CONDITIONAL([INITRD], [test "x$USE_INITRD" != "x"])
PATCH 1/1 configure: Fix for --with-initrd=no
Quoted 2 lines · Qiang Huang
Our configure.ac script wasn't handle --with-initrd=no, when this was passed, we got error:
The parameter to --with-initrd should be the name of the initrd to use; "yes" or "no" are not valid parameters. I note that the help text is misleading in this regard, it should probably be fixed up to say something like "Specify an initrd to use".
While it's unlikely that someone will have an initrd called "no", this issue can only occur with incorrect usage of the bootwrapper configure script. I'd happily accept a patch fixing up the help text, though.
Thanks,
Mark.
Quoted 34 lines
...
aarch64-linux-gnu-ld -o linux-system.axf --script=model.lds
aarch64-linux-gnu-ld: cannot find no
make: *** [linux-system.axf] Error 1Fix this by adding a line to check this.
And this also fixed --without-initrd.Signed-off-by Qiang Huang <[email protected]>Cc Geoff Levand <[email protected]>--- configure.ac | 1 + 1 file changed, 1 insertion(+)configure.ac +1
-0@@ -58,6 +58,7 @@ AC_SUBST([CPU_IDS], [$C_CPU_IDS]) AC_ARG_WITH([initrd], AS_HELP_STRING([--with-initrd], [embed an initrd in the kernel image]), USE_INITRD=$withval) +AS_IF([test "x$USE_INITRD" = "xno"], [USE_INITRD=], []) AC_SUBST([FILESYSTEM], [$USE_INITRD]) AM_CONDITIONAL([INITRD], [test "x$USE_INITRD" != "x"])Signature · 4 lines
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH 1/1 configure: Fix for --with-initrd=no
Quoted 8 lines · Mark Rutland
Quoted 2 lines · Qiang Huang
Our configure.ac script wasn't handle --with-initrd=no, when this was passed, we got error:
The parameter to --with-initrd should be the name of the initrd to use; "yes" or "no" are not valid parameters. I note that the help text is misleading in this regard, it should probably be fixed up to say something like "Specify an initrd to use".
Yeah, sorry I didn't see the help message, I just thought this should be the standard way.
According to autoconf's man page:
https://www.gnu.org/software/autoconf/manual/autoconf-2.65/html_node/External-Software.html
All packages should support --with-package=no and --with-package=yes and --without-package, these should be the standard usage right? Seems if we follow these usage, lots of entries needs to be modified, so maybe we can just leave them as they were?
Quoted 45 lines
While it's unlikely that someone will have an initrd called "no", this issue can only occur with incorrect usage of the bootwrapper configure script. I'd happily accept a patch fixing up the help text, though.
Thanks,
Mark.Quoted 34 lines
...
aarch64-linux-gnu-ld -o linux-system.axf --script=model.lds
aarch64-linux-gnu-ld: cannot find no
make: *** [linux-system.axf] Error 1Fix this by adding a line to check this.
And this also fixed --without-initrd.Signed-off-by Qiang Huang <[email protected]>Cc Geoff Levand <[email protected]>--- configure.ac | 1 + 1 file changed, 1 insertion(+)configure.ac +1
-0@@ -58,6 +58,7 @@ AC_SUBST([CPU_IDS], [$C_CPU_IDS]) AC_ARG_WITH([initrd], AS_HELP_STRING([--with-initrd], [embed an initrd in the kernel image]), USE_INITRD=$withval) +AS_IF([test "x$USE_INITRD" = "xno"], [USE_INITRD=], []) AC_SUBST([FILESYSTEM], [$USE_INITRD]) AM_CONDITIONAL([INITRD], [test "x$USE_INITRD" != "x"])Signature · 4 lines
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel.